[YARN-9121] Replace GpuDiscoverer.getInstance() to a readable object for easy access control - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 3.3.0, 3.2.1, 3.1.3
Component/s: None
Labels:
None

Hadoop Flags:

Reviewed

Description

The clients of GpuDiscoverer are very hard to test as they call GpuDiscoverer.getInstance() internally.
For example, writing tests for org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.gpu.GpuResourcePlugin#getNMResourceInfo is quite hard as the GpuDeviceInformation returned by GpuDiscoverer is not interchangeable as GpuDiscoverer is not mockable since we cannot inject it in tests.

Attachments

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending

Attachments

YARN-9121.branch-3.1.004.patch
27/Feb/19 09:12
15 kB
Szilard Nemeth
YARN-9121.branch-3.2.003.patch
25/Feb/19 13:04
16 kB
Szilard Nemeth
YARN-9121.branch-3.1.003.patch
25/Feb/19 13:04
16 kB
Szilard Nemeth
YARN-9121-branch-3.1.001.patch
25/Feb/19 07:47
16 kB
Szilard Nemeth
YARN-9121.branch-3.2.001.patch
25/Feb/19 07:42
16 kB
Szilard Nemeth
YARN-9121.003.patch
23/Feb/19 18:07
15 kB
Szilard Nemeth
YARN-9121.002.patch
22/Feb/19 18:21
15 kB
Szilard Nemeth
YARN-9121.001.patch
13/Dec/18 17:37
15 kB
Szilard Nemeth

Issue Links

is depended upon by

YARN-9235 If linux container executor is not set for a GPU cluster GpuResourceHandlerImpl is not initialized and NPE is thrown

Resolved

Activity

People

Assignee:

Szilard Nemeth

Reporter:

Szilard Nemeth

Votes:

0 Vote for this issue

Watchers:

6 Start watching this issue

Dates

Created:

13/Dec/18 17:09

Updated:

28/Feb/19 10:27

Resolved:

27/Feb/19 12:17