Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9118

Handle exceptions with parsing user defined GPU devices in GpuDiscoverer

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0, 3.2.1, 3.1.3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      getGpusUsableByYarn has the following issues:

      • Duplicate GPU device definitions are not denied: This seems to be the biggest issue as it could increase the number of devices on the node if the device ID is defined 2 or more times.
      • An empty-string is accepted, it works like the user would not want to use auto-discovery and haven't defined any GPU devices: This will result in an empty device list, but the empty-string check is never explicitly there in the code, so this behavior just coincidental.
      • Number validation does not happen on GPU device IDs (separated by commas)

      Many testcases are added as the coverage was already very low.

        Attachments

        1. YARN-9118.001.patch
          15 kB
          Szilard Nemeth
        2. YARN-9118.002.patch
          16 kB
          Szilard Nemeth
        3. YARN-9118.003.patch
          16 kB
          Szilard Nemeth
        4. YARN-9118.004.patch
          19 kB
          Szilard Nemeth
        5. YARN-9118.005.patch
          25 kB
          Szilard Nemeth
        6. YARN-9118.006.patch
          25 kB
          Szilard Nemeth
        7. YARN-9118.007.patch
          27 kB
          Szilard Nemeth
        8. YARN-9118.008.patch
          27 kB
          Szilard Nemeth
        9. YARN-9118.009.patch
          29 kB
          Szilard Nemeth

          Issue Links

            Activity

              People

              • Assignee:
                snemeth Szilard Nemeth
                Reporter:
                snemeth Szilard Nemeth
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: