Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9052

Replace all MockRM submit method definitions with a builder

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      MockRM has 31 definitions of submitApp, most of them having more than acceptable number of parameters, ranging from 2 to even 22 parameters, which makes the code completely unreadable.
      On top of unreadability, it's very hard to follow what RmApp will be produced for tests as they often pass a lot of empty / null values as parameters.

        Attachments

        1. YARN-9052.003.patch
          491 kB
          Szilard Nemeth
        2. YARN-9052.002.patch
          492 kB
          Szilard Nemeth
        3. YARN-9052.001.patch
          492 kB
          Szilard Nemeth

          Activity

            People

            • Assignee:
              snemeth Szilard Nemeth
              Reporter:
              snemeth Szilard Nemeth
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: