Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9052

Replace all MockRM submit method definitions with a builder

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MockRM has 31 definitions of submitApp, most of them having more than acceptable number of parameters, ranging from 2 to even 22 parameters, which makes the code completely unreadable.
      On top of unreadability, it's very hard to follow what RmApp will be produced for tests as they often pass a lot of empty / null values as parameters.

        Attachments

        1. YARN-9052.001.patch
          492 kB
          Szilard Nemeth
        2. YARN-9052.002.patch
          492 kB
          Szilard Nemeth
        3. YARN-9052.003.patch
          491 kB
          Szilard Nemeth
        4. YARN-9052.004.patch
          532 kB
          Szilard Nemeth
        5. YARN-9052.004.withlogs.patch
          535 kB
          Szilard Nemeth
        6. YARN-9052.005.patch
          532 kB
          Szilard Nemeth
        7. YARN-9052.006.patch
          532 kB
          Szilard Nemeth
        8. YARN-9052.007.patch
          540 kB
          Szilard Nemeth
        9. YARN-9052.008.patch
          542 kB
          Szilard Nemeth
        10. YARN-9052.009.patch
          544 kB
          Szilard Nemeth
        11. YARN-9052.009.patch
          544 kB
          Szilard Nemeth
        12. YARN-9052.testlogs.002.patch
          7 kB
          Szilard Nemeth
        13. YARN-9052.testlogs.002.patch
          7 kB
          Szilard Nemeth
        14. YARN-9052.testlogs.003.patch
          7 kB
          Szilard Nemeth
        15. YARN-9052.testlogs.patch
          5 kB
          Szilard Nemeth
        16. YARN-9052-004withlogs-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          3.31 MB
          Szilard Nemeth
        17. YARN-9052-testlogs003-justfailed.txt
          33 kB
          Szilard Nemeth
        18. YARN-9052-testlogs003-patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          3.72 MB
          Szilard Nemeth
        19. YARN-9052-testlogs004-justfailed.txt
          19 kB
          Szilard Nemeth

          Activity

            People

            • Assignee:
              snemeth Szilard Nemeth
              Reporter:
              snemeth Szilard Nemeth
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: