[YARN-8997] [Submarine] Small refactors of modifier, condition check and redundant local variables

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Assignee: Zhankun Tang
• Reporter: Zhankun Tang
• Created: 09/Nov/18 07:21
• Updated: 13/Nov/18 01:54
• Resolved: 12/Nov/18 23:07

Description

In YarnServiceJobSubmitter#needHdfs. Below code can be simplified to just one line.

if (content != null && content.contains("hdfs://")) {
  return true;
}
return false;

return content != null && content.contains("hdfs://");

In CliUtils#argsForHelp

if (args[0].equals("-h") || args[0].equals("--help")) {
  return true;
}

Can be simlified to:

 return args[0].equals("-h") || args[0].equals("--help");

And several redundant variables can be removed.