Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-8472 YARN Container Phase 2
  3. YARN-8801

javadoc comments in docker-util.h is confusing

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.2.0, 3.1.2
    • None

    Description

       /**
      + * Get the Docker exec command line string. The function will verify that the params file is meant for the exec command.
      + * @param command_file File containing the params for the Docker start command
      + * @param conf Configuration struct containing the container-executor.cfg details
      + * @param out Buffer to fill with the exec command
      + * @param outlen Size of the output buffer
      + * @return Return code with 0 indicating success and non-zero codes indicating error
      + */
      +int get_docker_exec_command(const char* command_file, const struct configuration* conf, args *args);

      The method param list have out an outlen which didn't match the signature, and we miss description for param args. 

      Attachments

        1. YARN-8801.001.patch
          7 kB
          Zian Chen

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Zian Chen Zian Chen
            Zian Chen Zian Chen
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment