[YARN-8506] Make GetApplicationsRequestPBImpl thread safe

• Type: Task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.2.0, 3.1.1
• Hadoop Flags: Reviewed
• Assignee: Wangda Tan
• Reporter: Wangda Tan
• Created: 09/Jul/18 16:45
• Updated: 09/Jul/18 18:56
• Resolved: 09/Jul/18 18:48

Description

When GetApplicationRequestPBImpl is used in multi-thread environment, exceptions like below will occur because we don't protect write ops.

java.lang.ArrayIndexOutOfBoundsException
	at java.lang.System.arraycopy(Native Method)
	at java.util.ArrayList.addAll(ArrayList.java:613)
	at com.google.protobuf.LazyStringArrayList.addAll(LazyStringArrayList.java:132)
	at com.google.protobuf.LazyStringArrayList.addAll(LazyStringArrayList.java:123)
	at com.google.protobuf.AbstractMessageLite$Builder.addAll(AbstractMessageLite.java:327)
	at org.apache.hadoop.yarn.proto.YarnServiceProtos$GetApplicationsRequestProto$Builder.addAllApplicationTags(YarnServiceProtos.java:24450)
	at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetApplicationsRequestPBImpl.mergeLocalToBuilder(GetApplicationsRequestPBImpl.java:100)
	at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetApplicationsRequestPBImpl.mergeLocalToProto(GetApplicationsRequestPBImpl.java:78)
	at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetApplicationsRequestPBImpl.getProto(GetApplicationsRequestPBImpl.java:69)

We need to make GetApplicationRequestPBImpl thread safe. We saw the issue happens frequently when RequestHedgingRMFailoverProxyProvider is being used.