[YARN-8325] Miscellaneous QueueManager code clean up

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.2.0
• Component/s: fairscheduler
• Hadoop Flags: Reviewed
• Assignee: Szilard Nemeth
• Reporter: Haibo Chen
• Created: 18/May/18 21:43
• Updated: 12/Jun/18 17:50
• Resolved: 12/Jun/18 17:12

Description

getLeafQueue(String name, boolean create, boolean recomputeSteadyShares) and

getLeafQueue(String name,  boolean create,  boolean recomputeSteadyShares),  setChildResourceLimits() can be declared as private.

 ensureRootPrefix() should be static.

The static LOG field should be private.

The log in

      if (!parent.getPolicy().isChildPolicyAllowed(childPolicy))

{         LOG.error("Can't create queue '" + queueName + "'.");         return null;       }

can be improved by the specific reason, ie. the child scheduling policy is not allowed by that of its parent.