Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-8325

Miscellaneous QueueManager code clean up

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2.0
    • Component/s: fairscheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      getLeafQueue(String name, boolean create, boolean recomputeSteadyShares) and

      getLeafQueue(String name,  boolean create,  boolean recomputeSteadyShares),  setChildResourceLimits() can be declared as private.

       ensureRootPrefix() should be static.

      The static LOG field should be private.

      The log in

            if (!parent.getPolicy().isChildPolicyAllowed(childPolicy))

      {         LOG.error("Can't create queue '" + queueName + "'.");         return null;       }

      can be improved by the specific reason, ie. the child scheduling policy is not allowed by that of its parent.

        Attachments

        1. YARN-8325.001.patch
          6 kB
          Szilard Nemeth
        2. YARN-8325.002.patch
          6 kB
          Szilard Nemeth

          Activity

            People

            • Assignee:
              snemeth Szilard Nemeth
              Reporter:
              haibochen Haibo Chen
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: