Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2.0, 3.1.1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

              if (ContainerExecutor.Signal.KILL.equals(signal)
                  || ContainerExecutor.Signal.TERM.equals(signal)) {
                handleContainerStop(containerId, env);
      

      Currently in the code, we are handling both SIGKILL and SIGTERM as equivalent for docker containers. However, they should actually be separate. When YARN sends a SIGKILL to a process, it means for it to die immediately and not sit around waiting for anything. This ensures an immediate reclamation of resources. Additionally, if a SIGTERM is sent before the SIGKILL, the task might not handle the signal correctly, and will then end up as a failed task instead of a killed task. This is especially bad for preemption.

        Attachments

        1. YARN-8206.001.patch
          3 kB
          Eric Badger
        2. YARN-8206.002.patch
          4 kB
          Eric Badger
        3. YARN-8206.003.patch
          11 kB
          Eric Badger
        4. YARN-8206.004.patch
          12 kB
          Eric Badger
        5. YARN-8206.005.patch
          28 kB
          Eric Badger
        6. YARN-8206.006.patch
          30 kB
          Eric Badger
        7. YARN-8206.007.patch
          794 kB
          Eric Badger
        8. YARN-8206.008.patch
          29 kB
          Eric Badger
        9. YARN-8206.009.patch
          30 kB
          Eric Badger
        10. YARN-8206.010.patch
          29 kB
          Eric Badger
        11. YARN-8206.011.patch
          29 kB
          Eric Badger

          Issue Links

            Activity

              People

              • Assignee:
                ebadger Eric Badger
                Reporter:
                ebadger Eric Badger
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: