Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-8057

Inadequate information for handling catch clauses

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.0.0
    • Fix Version/s: None
    • Component/s: api, yarn
    • Labels:

      Description

      Their are some situations that different exception types are caught, but the handling of those exceptions can not show the differences of those types. Here are the code snippets we found which have this problem:

      org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java

      https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java

      At Line 125 and Line 129. We can see that two exception types are caught, but the logging statements here can not show the exception type at all. It may cause confusions to the person who is reading the log, the person can not know what exception happened here.

       

      Maybe adding stack trace information to these two logging statements is a simple way to improve it.

       

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              lzh3636 Zhenhao Li
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated: