[YARN-7796] Container-executor fails with segfault on certain OS configurations

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.1.0, 3.0.1
• Component/s: nodemanager
• Hadoop Flags: Reviewed
• Assignee: Gergo Repas
• Reporter: Gergo Repas
• Created: 23/Jan/18 16:23
• Updated: 30/Jan/18 20:47
• Resolved: 24/Jan/18 05:34

Description

There is a relatively big (128K) buffer allocated on the stack in container-executor.c for the purpose of copying files. As indicated by the below gdb stack trace, this allocation can fail with SIGSEGV. This happens only on certain OS configurations - I can reproduce this issue on RHEL 6.9:

[Thread debugging using libthread_db enabled]
main : command provided 0
main : run as user is ***
main : requested yarn user is ***

Program received signal SIGSEGV, Segmentation fault.
0x00000000004069bc in copy_file (input=7, in_filename=0x7ffd669fd2d6 "/yarn/nm/nmPrivate/container_1516711246952_0001_02_000001.tokens", out_filename=0x932930 "/yarn/nm/usercache/systest/appcache/application_1516711246952_0001/container_1516711246952_0001_02_000001.tokens", perm=384)
    at /root/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c:966
966	  char buffer[buffer_size];
(gdb) bt
#0  0x00000000004069bc in copy_file (input=7, in_filename=0x7ffd669fd2d6 "/yarn/nm/nmPrivate/container_1516711246952_0001_02_000001.tokens", out_filename=0x932930 "/yarn/nm/usercache/systest/appcache/application_1516711246952_0001/container_1516711246952_0001_02_000001.tokens", perm=384)
    at /root/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c:966
#1  0x0000000000409a81 in initialize_app (user=<value optimized out>, app_id=0x7ffd669fd2b7 "application_1516711246952_0001", nmPrivate_credentials_file=0x7ffd669fd2d6 "/yarn/nm/nmPrivate/container_1516711246952_0001_02_000001.tokens", local_dirs=0x9331c8, log_roots=<value optimized out>, args=0x7ffd669fb168)
    at /root/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/container-executor.c:1122
#2  0x0000000000403f90 in main (argc=<value optimized out>, argv=<value optimized out>) at /root/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c:558

Issue Links

• is related to: YARN-7857 -fstack-check compilation flag causes binary incompatibility for container-executor between RHEL 6 and RHEL 7