[YARN-7661] NodeManager metrics return wrong value after update node resource

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.7.0
• Fix Version/s: 3.1.0, 2.10.0, 2.9.1, 3.0.1, 2.8.4, 2.7.6
• Target Version/s: 2.7.5, 3.1.0, 2.9.1, 3.0.1, 2.8.4
• Hadoop Flags: Reviewed
• Assignee: Yang Wang
• Reporter: Yang Wang
• Created: 15/Dec/17 08:52
• Updated: 19/Dec/17 05:24
• Resolved: 18/Dec/17 21:46

Description

NodeManagerMetrics.java

  public void addResource(Resource res) {
    availableMB = availableMB + res.getMemorySize();
    availableGB.incr((int)Math.floor(availableMB/1024d));
    availableVCores.incr(res.getVirtualCores());
  }

When the node resource was updated through RM-NM heartbeat, the NM metric will get wrong value.
The root cause of this issue is that new resource has been added to availableMB, so not needed to increase for availableGB again.

Issue Links

• is broken by: YARN-1156 Enhance NodeManager AllocatedGB and AvailableGB metrics for aggregation of decimal values
• is duplicated by: YARN-7659 NodeManager metrics return wrong value after update resource