Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-7578

Extend TestDiskFailures.waitForDiskHealthCheck() sleeping time.

    Details

    • Type: Test
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.1.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
    • Environment:

      ARMv8 AArch64, Ubuntu16.04

    • Target Version/s:
    • Flags:
      Patch

      Description

      Thread.sleep() function is called to wait for NodeManager to identify disk failures. But in some cases, for example the lower-end hardware computer, the sleep time is too short so that the NodeManager may haven't finished identifying disk failures. This will occur test errors:

      	Running org.apache.hadoop.yarn.server.TestDiskFailures
      	Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 17.686 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.TestDiskFailures
      	testLocalDirsFailures(org.apache.hadoop.yarn.server.TestDiskFailures)  Time elapsed: 10.412 sec  <<< FAILURE!
      	java.lang.AssertionError: NodeManager could not identify disk failure.
      			at org.junit.Assert.fail(Assert.java:88)
      			at org.junit.Assert.assertTrue(Assert.java:41)
      			at org.apache.hadoop.yarn.server.TestDiskFailures.verifyDisksHealth(TestDiskFailures.java:239)
      			at org.apache.hadoop.yarn.server.TestDiskFailures.testDirsFailures(TestDiskFailures.java:186)
      			at org.apache.hadoop.yarn.server.TestDiskFailures.testLocalDirsFailures(TestDiskFailures.java:99)
      
      	testLogDirsFailures(org.apache.hadoop.yarn.server.TestDiskFailures)  Time elapsed: 5.99 sec  <<< FAILURE!
      	java.lang.AssertionError: NodeManager could not identify disk failure.
      			at org.junit.Assert.fail(Assert.java:88)
      			at org.junit.Assert.assertTrue(Assert.java:41)
      			at org.apache.hadoop.yarn.server.TestDiskFailures.verifyDisksHealth(TestDiskFailures.java:239)
      			at org.apache.hadoop.yarn.server.TestDiskFailures.testDirsFailures(TestDiskFailures.java:186)
      			at org.apache.hadoop.yarn.server.TestDiskFailures.testLogDirsFailures(TestDiskFailures.java:111)
      
      

      So extend the sleep time from 1000ms to 1500ms to avoid some unit test errors.

        Attachments

        1. YARN-7578.0.patch
          2 kB
          Guangming Zhang

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                guangming Guangming Zhang
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 48h
                  48h
                  Remaining:
                  Remaining Estimate - 48h
                  48h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified