[YARN-7576] Findbug warning for Resource exposing internal representation

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.0.0
• Component/s: api
• Assignee: Unassigned
• Reporter: Jason Darrell Lowe
• Created: 28/Nov/17 19:25
• Updated: 26/Feb/20 05:29
• Resolved: 19/Feb/20 01:23

Description

Precommit builds are complaining about a findbugs warning:

EI 	org.apache.hadoop.yarn.api.records.Resource.getResources() may expose internal representation by returning Resource.resources
	
Bug type EI_EXPOSE_REP (click for details)
In class org.apache.hadoop.yarn.api.records.Resource
In method org.apache.hadoop.yarn.api.records.Resource.getResources()
Field org.apache.hadoop.yarn.api.records.Resource.resources
At Resource.java:[line 213]

Returning a reference to a mutable object value stored in one of the object's fields exposes the internal representation of the object.  If instances are accessed by untrusted code, and unchecked changes to the mutable object would compromise security or other important properties, you will need to do something different. Returning a new copy of the object is better approach in many situations.

Issue Links

• Is contained by: YARN-7556 Fair scheduler configuration should allow resource types in the minResources and maxResources properties
• relates to: YARN-7136 Additional Performance Improvement for Resource Profile Feature