[YARN-7486] Race condition in service AM that can cause NPE

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.1.0
• Assignee: Jian He
• Reporter: Jian He
• Created: 14/Nov/17 00:54
• Updated: 16/Nov/17 16:20
• Resolved: 16/Nov/17 16:00

Description

1. container1 completed for instance1
2. instance1 is added to pending list, and send an event asynchronously to instance1 to run ContainerStoppedTransition
3. container2 allocated, and assigned to instance1, it records the container2 inside instance1
4. in the meantime, instance1 ContainerStoppedTransition is called and that set the container back to null.
This cause the recorded container lost.

		java.lang.NullPointerException
			at org.apache.hadoop.yarn.service.provider.ProviderUtils.initCompTokensForSubstitute(ProviderUtils.java:402)
			at org.apache.hadoop.yarn.service.provider.AbstractProviderService.buildContainerLaunchContext(AbstractProviderService.java:70)
			at org.apache.hadoop.yarn.service.containerlaunch.ContainerLaunchService$ContainerLauncher.run(ContainerLaunchService.java:89)
			at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
			at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
			at java.lang.Thread.run(Thread.java:745)