[YARN-744] Race condition in ApplicationMasterService.allocate .. It might process same allocate request twice resulting in additional containers getting allocated.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Component/s: resourcemanager
• Hadoop Flags: Reviewed
• Assignee: Omkar Vinit Joshi
• Reporter: Bikas Saha
• Created: 22/Feb/12 23:19
• Updated: 05/Feb/16 07:45
• Resolved: 20/Nov/13 05:23

Description

Looks like the lock taken in this is broken. It takes a lock on lastResponse object and then puts a new lastResponse object into the map. At this point a new thread entering this function will get a new lastResponse object and will be able to take its lock and enter the critical section. Presumably we want to limit one response per app attempt. So the lock could be taken on the ApplicationAttemptId key of the response map object.

Issue Links

• is related to: YARN-4673 race condition in ResourceTrackerService#nodeHeartBeat while processing deduplicated msg