Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-7373

The atomicity of container update in RM is not clear

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Information Provided
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: resourcemanager
    • Labels:
      None

      Description

      While reviewing YARN-4511, Miklos noticed that

      342	    // notify schedulerNode of the update to correct resource accounting
      343	    node.containerUpdated(existingRMContainer, existingContainer);
      344	
      345	    ((RMContainerImpl)tempRMContainer).setContainer(updatedTempContainer);
      346	    // notify SchedulerNode of the update to correct resource accounting
      347	    node.containerUpdated(tempRMContainer, tempContainer);
      348	
      

      I think that it would be nicer to lock around these two calls to become atomic.

      Container update, and thus container swap as part of that, is atomic according to Arun Suresh.
      It'd be nice to discuss this in more details to see if we want to be more conservative.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                haibochen Haibo Chen
                Reporter:
                haibochen Haibo Chen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: