[YARN-7221] Add security check for privileged docker container

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0, 3.1.0
• Fix Version/s: 3.2.0, 3.1.1
• Component/s: security
• Hadoop Flags: Reviewed
• Assignee: Eric Yang
• Reporter: Eric Yang
• Created: 19/Sep/17 22:04
• Updated: 18/Apr/19 08:20
• Resolved: 11/Apr/18 20:26

Description

When a docker is running with privileges, majority of the use case is to have some program running with root then drop privileges to another user. i.e. httpd to start with privileged and bind to port 80, then drop privileges to www user.

1. We should add security check for submitting users, to verify they have "sudo" access to run privileged container.
2. We should remove --user=uid:gid for privileged containers.

Docker can be launched with --privileged=true, and --user=uid:gid flag. With this parameter combinations, user will not have access to become root user. All docker exec command will be drop to uid:gid user to run instead of granting privileges. User can gain root privileges if container file system contains files that give user extra power, but this type of image is considered as dangerous. Non-privileged user can launch container with special bits to acquire same level of root power. Hence, we lose control of which image should be run with --privileges, and who have sudo rights to use privileged container images. As the result, we should check for sudo access then decide to parameterize --privileged=true OR --user=uid:gid. This will avoid leading developer down the wrong path.

Issue Links

• causes: YARN-8485 Priviledged container app launch is failing intermittently
• causes: YARN-8622 NodeManager native build fails due to getgrouplist not found on macOS
• is blocked by: YARN-4266 Allow users to enter containers as UID:GID pair instead of by username
• is part of: YARN-3611 Support Docker Containers In LinuxContainerExecutor
• is related to: YARN-7430 Enable user re-mapping for Docker containers by default
• relates to: YARN-7654 Support ENTRY_POINT for docker container