[YARN-7208] CMAKE_C_STANDARD take effect in NodeManager package.

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Duplicate
• Target Version/s: 3.0.0-beta1
• Assignee: Unassigned
• Reporter: Wangda Tan
• Created: 16/Sep/17 00:06
• Updated: 16/Sep/17 00:09
• Resolved: 16/Sep/17 00:08

Description

I just checked changes of this JIRA doesn't relate to issues I saw, I tried to revert this patch but issue is still the same.

It seems the set (CMAKE_C_STANDARD) doesn't work for the nodemanager project.
I hardcoded to change set (CMAKE_C_STANDARD 99) to set (CMAKE_C_STANDARD 90) in nodemanager project. (Since we have code uses C99-only syntax, so changing to 90 should fail build).

I tried on two different environment:
1) Centos 6, cmake version 3.1.0, gcc 4.4.7
For both 99/90 standard, all fail.
2) OSX v10.12.4, cmake version 3.5.2, cc = "Apple LLVM version 8.1.0 (clang-802.0.42)".
For both 99/90 standard, all succeeded.
At least for the for loop in gpu-module.c is C99 only:

for (int i = 0; i < n_minor_devices_to_block; i++) {
   // ...
}

Issue Links

• duplicates: HADOOP-14873 force cmake to exit if it can't detect a C99 compiler