Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6996

Change javax.cache library implementation from JSR107 to Apache Geronimo

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-beta1
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      With YARN Federation, we added YARN-3672, which adds the following to

          <groupId>javax.cache</groupId>
          <artifactId>cache-api</artifactId>
      

      This third-party library has some murky license history, as documented in this really long comment thread. The summary of the thread is that "the library is officially APL (take our word for it), but there hasn't been a subsequent release with the license file change".

      LEGAL-325 has been filed to discuss the validity of this license for Apache.

      Before we get to final Hadoop 3 release, I'm wondering if anyone else has concerns about using this library. Just from looking at the various javax Maven artifacts in our pom.xml files, I see a lot of other javax.* library entries (although we may not ship the .jars if they're part of the Java runtime).

        Issue Links

          Activity

          Hide
          rchiang Ray Chiang added a comment -

          Based on a comment from LEGAL-325, trying out a patch that swaps to the Apache Geronimo jcache implementation.

          Show
          rchiang Ray Chiang added a comment - Based on a comment from LEGAL-325 , trying out a patch that swaps to the Apache Geronimo jcache implementation.
          Hide
          rchiang Ray Chiang added a comment -

          Subru Krishnan, let me know what you think about this change.

          Show
          rchiang Ray Chiang added a comment - Subru Krishnan , let me know what you think about this change.
          Hide
          busbey Sean Busbey added a comment -

          patch looks reasonable, presuming compiling works.

          is there no license / notice change to back out when moving to the Geronimo jar?

          Show
          busbey Sean Busbey added a comment - patch looks reasonable, presuming compiling works. is there no license / notice change to back out when moving to the Geronimo jar?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          0 mvndep 0m 28s Maven dependency ordering for branch
          +1 mvninstall 15m 59s trunk passed
          +1 compile 15m 34s trunk passed
          +1 mvnsite 0m 45s trunk passed
          +1 javadoc 0m 35s trunk passed
                Patch Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 0m 31s the patch passed
          +1 compile 12m 1s the patch passed
          +1 javac 12m 1s the patch passed
          +1 mvnsite 0m 44s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 3s The patch has no ill-formed XML file.
          +1 javadoc 0m 35s the patch passed
                Other Tests
          +1 unit 0m 13s hadoop-project in the patch passed.
          +1 unit 1m 37s hadoop-yarn-server-common in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          51m 26s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6996
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881543/YARN-6996.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
          uname Linux aff4e8ca0768 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bbbf0e2
          Default Java 1.8.0_144
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16860/testReport/
          modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: .
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16860/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 15m 59s trunk passed +1 compile 15m 34s trunk passed +1 mvnsite 0m 45s trunk passed +1 javadoc 0m 35s trunk passed       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 0m 31s the patch passed +1 compile 12m 1s the patch passed +1 javac 12m 1s the patch passed +1 mvnsite 0m 44s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 javadoc 0m 35s the patch passed       Other Tests +1 unit 0m 13s hadoop-project in the patch passed. +1 unit 1m 37s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 51m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6996 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881543/YARN-6996.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux aff4e8ca0768 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bbbf0e2 Default Java 1.8.0_144 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16860/testReport/ modules C: hadoop-project hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: . Console output https://builds.apache.org/job/PreCommit-YARN-Build/16860/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Compiling works. Unit test that tests the class that uses the jcache library passes.

          Show
          rchiang Ray Chiang added a comment - Compiling works. Unit test that tests the class that uses the jcache library passes.
          Hide
          subru Subru Krishnan added a comment - - edited

          Thanks Ray Chiang for bringing this up. We had looked at jsr license and looks like even though they have Apache 2.0, they have not updated their release yet.

          The patch itself LGTM.

          Show
          subru Subru Krishnan added a comment - - edited Thanks Ray Chiang for bringing this up. We had looked at jsr license and looks like even though they have Apache 2.0, they have not updated their release yet. The patch itself LGTM.
          Hide
          subru Subru Krishnan added a comment - - edited

          Sean Busbey, thanks for validating the fix. Like I mentioned above we (mistakenly) assumed the jsr 107 license was Apache 2.0 and so we don't need any license / notice change to back out when moving to the (Apache) Geronimo.

          Show
          subru Subru Krishnan added a comment - - edited Sean Busbey , thanks for validating the fix. Like I mentioned above we (mistakenly) assumed the jsr 107 license was Apache 2.0 and so we don't need any license / notice change to back out when moving to the (Apache) Geronimo.
          Hide
          busbey Sean Busbey added a comment -

          +1 (non-binding) on patch as-is then.

          Show
          busbey Sean Busbey added a comment - +1 (non-binding) on patch as-is then.
          Hide
          subru Subru Krishnan added a comment -

          Thanks Ray Chiang for identifying/fixing this and Sean Busbey for the review, I just committed this to trunk.

          Show
          subru Subru Krishnan added a comment - Thanks Ray Chiang for identifying/fixing this and Sean Busbey for the review, I just committed this to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12179 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12179/)
          YARN-6996. Change javax.cache library implementation from JSR107 to (subru: rev 18f3603bce37e0e07c9075811b1179afc2c227eb)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml
          • (edit) hadoop-project/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12179 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12179/ ) YARN-6996 . Change javax.cache library implementation from JSR107 to (subru: rev 18f3603bce37e0e07c9075811b1179afc2c227eb) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/pom.xml (edit) hadoop-project/pom.xml
          Hide
          rchiang Ray Chiang added a comment -
          Show
          rchiang Ray Chiang added a comment - Thanks Subru Krishnan and Sean Busbey !

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              rchiang Ray Chiang
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development