[YARN-6982] Potential issue on setting AMContainerSpec#tokenConf to null before app is completed

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-beta1
• Hadoop Flags: Reviewed
• Assignee: Manikandan R
• Reporter: Rohith Sharma K S
• Created: 10/Aug/17 12:31
• Updated: 01/Sep/17 04:39
• Resolved: 30/Aug/17 05:29

Description

While reviewing patch for YARN-65, I found that many places RMAppImpl#submissionContext sets containerLaunchcontext#setTokensConf has been set to null i.e

// set the memory free
app.submissionContext.getAMContainerSpec().setTokensConf(null);

This appears be a issue if application is updated may be because queue move or lifetime or priority, then submission context will be restored again into state store. Consider after app update, if RM is restarted then submission context will have null tokenConf. This could be a potential issue.

Issue Links

• is required by: YARN-65 Reduce RM app memory footprint once app has completed