Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6712 Moving logging APIs over to slf4j in hadoop-yarn
  3. YARN-6961

Remove commons-logging dependency from hadoop-yarn-server-applicationhistoryservice module

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: build
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      commons-logging dependency was removed from hadoop-yarn-server-applicationhistoryservice. If you rely on the transitive commons-logging dependency, please define the dependency explicitly.

      Description

      YARN-6873 removed the usage of commons-logging APIs, so the dependency can be removed.

        Activity

        Hide
        Cyl Yeliang Cang added a comment -

        Submit a patch, please review it, Akira Ajisaka, thank you!

        Show
        Cyl Yeliang Cang added a comment - Submit a patch, please review it, Akira Ajisaka , thank you!
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 14m 5s trunk passed
        +1 compile 0m 20s trunk passed
        +1 mvnsite 0m 22s trunk passed
        +1 javadoc 0m 15s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 19s the patch passed
        +1 javac 0m 19s the patch passed
        +1 mvnsite 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 0m 12s the patch passed
              Other Tests
        +1 unit 2m 58s hadoop-yarn-server-applicationhistoryservice in the patch passed.
        +1 asflicense 0m 14s The patch does not generate ASF License warnings.
        20m 21s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6961
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880638/YARN-6961.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 900b6c2210ff 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0b67436
        Default Java 1.8.0_131
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16739/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16739/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 5s trunk passed +1 compile 0m 20s trunk passed +1 mvnsite 0m 22s trunk passed +1 javadoc 0m 15s trunk passed       Patch Compile Tests +1 mvninstall 0m 19s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed +1 mvnsite 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 12s the patch passed       Other Tests +1 unit 2m 58s hadoop-yarn-server-applicationhistoryservice in the patch passed. +1 asflicense 0m 14s The patch does not generate ASF License warnings. 20m 21s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6961 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880638/YARN-6961.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 900b6c2210ff 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0b67436 Default Java 1.8.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16739/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice Console output https://builds.apache.org/job/PreCommit-YARN-Build/16739/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, checking this in.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, checking this in.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk. Thanks Yeliang Cang for the contribution!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Yeliang Cang for the contribution!
        Hide
        Cyl Yeliang Cang added a comment -

        Thank you for the review, Akira Ajisaka!

        Show
        Cyl Yeliang Cang added a comment - Thank you for the review, Akira Ajisaka !

          People

          • Assignee:
            Cyl Yeliang Cang
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development