Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6727

Improve getQueueUserAcls API to query for specific queue and user

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Currently ApplicationClientProtocol#getQueueUserAcls return data for all the queues available in scheduler for user.

      User wants to know whether he has rights of a particular queue only. For systems with 5K queues returning all queues list is not efficient.

      Suggested change: support additional parameters userName and queueName as optional. Admin user should be able to query other users ACL for a particular queueName.

      1. YARN-6727.001.patch
        26 kB
        Bibin A Chundatt
      2. YARN-6727.002.patch
        25 kB
        Bibin A Chundatt
      3. YARN-6727.003.patch
        26 kB
        Bibin A Chundatt
      4. YARN-6727.004.patch
        25 kB
        Bibin A Chundatt
      5. YARN-6727.005.patch
        26 kB
        Bibin A Chundatt
      6. YARN-6727.006.patch
        26 kB
        Bibin A Chundatt
      7. YARN-6727.WIP.patch
        9 kB
        Bibin A Chundatt

        Activity

        Hide
        Naganarasimha Naganarasimha G R added a comment - - edited

        Thanks Bibin A Chundatt for raising this issue. Agree that it can be simplified in the server side if we modify it support for the qiven user and the queue. if any thing is not provided we can map it to defaults, (like user -> current UGI user & Queue -> all queues)

        Show
        Naganarasimha Naganarasimha G R added a comment - - edited Thanks Bibin A Chundatt for raising this issue. Agree that it can be simplified in the server side if we modify it support for the qiven user and the queue. if any thing is not provided we can map it to defaults, (like user -> current UGI user & Queue -> all queues)
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attaching patch.. Yet to add testcase for the same.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Attaching patch.. Yet to add testcase for the same.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        0 mvndep 0m 41s Maven dependency ordering for branch
        +1 mvninstall 14m 11s trunk passed
        +1 compile 9m 15s trunk passed
        +1 checkstyle 0m 51s trunk passed
        +1 mvnsite 1m 56s trunk passed
        +1 findbugs 3m 26s trunk passed
        +1 javadoc 1m 34s trunk passed
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 30s the patch passed
        +1 compile 5m 31s the patch passed
        +1 cc 5m 31s the patch passed
        +1 javac 5m 31s the patch passed
        +1 checkstyle 0m 50s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 39 unchanged - 1 fixed = 39 total (was 40)
        +1 mvnsite 1m 47s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 45s the patch passed
        +1 javadoc 1m 24s the patch passed
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 2m 26s hadoop-yarn-common in the patch passed.
        -1 unit 42m 39s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 32s The patch does not generate ASF License warnings.
        101m 10s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6727
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874295/YARN-6727.WIP.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux 86f89542d43f 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0111711
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/16242/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16242/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16242/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 41s Maven dependency ordering for branch +1 mvninstall 14m 11s trunk passed +1 compile 9m 15s trunk passed +1 checkstyle 0m 51s trunk passed +1 mvnsite 1m 56s trunk passed +1 findbugs 3m 26s trunk passed +1 javadoc 1m 34s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 30s the patch passed +1 compile 5m 31s the patch passed +1 cc 5m 31s the patch passed +1 javac 5m 31s the patch passed +1 checkstyle 0m 50s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 39 unchanged - 1 fixed = 39 total (was 40) +1 mvnsite 1m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 45s the patch passed +1 javadoc 1m 24s the patch passed +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 26s hadoop-yarn-common in the patch passed. -1 unit 42m 39s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 32s The patch does not generate ASF License warnings. 101m 10s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestRMRestart Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6727 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874295/YARN-6727.WIP.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 86f89542d43f 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0111711 Default Java 1.8.0_131 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16242/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16242/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16242/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks Bibin A Chundatt for the WIP patch.
        As i understand, there are 2 issues currently for large queues

        1. Amount of data which gets transferred
        2. number of computations done in the server side as for each queue we are trying to match whether user or his group has rights. And also it would suffice to know in most case for the leaf queue only.

        So IIUC your patch is solving only the first part. But for the second one though its not too much of overhead as no locks are held but its unnecessary computation. So would it better to optimize it with additional scheduler API too, thoughts ?
        Further i was thinking it would be good to have list of queues rather than a single queue.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks Bibin A Chundatt for the WIP patch. As i understand, there are 2 issues currently for large queues Amount of data which gets transferred number of computations done in the server side as for each queue we are trying to match whether user or his group has rights. And also it would suffice to know in most case for the leaf queue only. So IIUC your patch is solving only the first part. But for the second one though its not too much of overhead as no locks are held but its unnecessary computation. So would it better to optimize it with additional scheduler API too, thoughts ? Further i was thinking it would be good to have list of queues rather than a single queue.
        Hide
        sunilg Sunil G added a comment -

        I second Naganarasimha Garla's opinion. We need not have to add more overhead such as invoking YarnAuthorizationProvider#checkPermission with a readLock (We already doing some what similar in existing public apis such as getQueueUserAclInfo), its better if we can avoid similar api's in future. Also a client api/cli getting a lock (read) to scheduler's internal structure could add more complexities later. Hence we can start thinking in having precomputed access checks for active/non-active users. New user's might need to do with some common checks from QueueACLManager itself.

        Show
        sunilg Sunil G added a comment - I second Naganarasimha Garla 's opinion. We need not have to add more overhead such as invoking YarnAuthorizationProvider#checkPermission with a readLock (We already doing some what similar in existing public apis such as getQueueUserAclInfo), its better if we can avoid similar api's in future. Also a client api/cli getting a lock (read) to scheduler's internal structure could add more complexities later. Hence we can start thinking in having precomputed access checks for active/non-active users. New user's might need to do with some common checks from QueueACLManager itself.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Thank you Sunil G and Naganarasimha Garla for looking into the same.
        I would like split into two

        1. precomputed access checks for active/non-active users
        2. Api Interface change

        lets focus of API interface change in this JIRA and will raise another for caching precomputed ACLS

        Show
        bibinchundatt Bibin A Chundatt added a comment - Thank you Sunil G and Naganarasimha Garla for looking into the same. I would like split into two precomputed access checks for active/non-active users Api Interface change lets focus of API interface change in this JIRA and will raise another for caching precomputed ACLS
        Hide
        sunilg Sunil G added a comment -

        I guess I ll put my thoughts more clearer for better clarity in terms of understanding.

        1. Invoking YarnScheduler#checkAccess is safer for CS as we lock with a readLock only in YarnAuthorizationProvider where as FS still has some locks in scheduler. So we can try limiting the checkAccess as possible.
        2. Whichever user is passed with checkAccess at one point of time (from cli/api side or app submission time etc) could be cached. I prefer this to be stored outside scheduler.
        3. So any further getQueueUserAcls could look into cache for first time. And given a cache miss, we can do YarnScheduler#checkAccess and update cache.
        4. Cache could be invalidated in cases here a config refresh happened for queues/acls or in similar conditions.

        Given if changes are minimal, we can do in one ticket. But if its more, I am in favor of splitting to 2 jiras for api and scheduler.

        Show
        sunilg Sunil G added a comment - I guess I ll put my thoughts more clearer for better clarity in terms of understanding. Invoking YarnScheduler#checkAccess is safer for CS as we lock with a readLock only in YarnAuthorizationProvider where as FS still has some locks in scheduler. So we can try limiting the checkAccess as possible. Whichever user is passed with checkAccess at one point of time (from cli/api side or app submission time etc) could be cached. I prefer this to be stored outside scheduler. So any further getQueueUserAcls could look into cache for first time. And given a cache miss, we can do YarnScheduler#checkAccess and update cache. Cache could be invalidated in cases here a config refresh happened for queues/acls or in similar conditions. Given if changes are minimal, we can do in one ticket. But if its more, I am in favor of splitting to 2 jiras for api and scheduler.
        Hide
        bibinchundatt Bibin A Chundatt added a comment - - edited

        Thank you Sunil G for explanation

        Is safer for CS as we lock with a readLock only in YarnAuthorizationProvider

        + queue level readlock

        Whichever user is passed with checkAccess at one point of time (from cli/api side or app submission time etc) could be cached.

        Submission time QUEUE_SUBMIT right we could cache but we need all .. am i missing something?

        Cache could be invalidated in cases here a config refresh happened for queues/acls or in similar conditions.

        The ACL mapping will depend on user to group mapping also which gets refreshed based in time interval.
        IIUC the refresh interval is about 5/10 min.We dont have direct update or notifier as of now.

        Show
        bibinchundatt Bibin A Chundatt added a comment - - edited Thank you Sunil G for explanation Is safer for CS as we lock with a readLock only in YarnAuthorizationProvider + queue level readlock Whichever user is passed with checkAccess at one point of time (from cli/api side or app submission time etc) could be cached. Submission time QUEUE_SUBMIT right we could cache but we need all .. am i missing something? Cache could be invalidated in cases here a config refresh happened for queues/acls or in similar conditions. The ACL mapping will depend on user to group mapping also which gets refreshed based in time interval. IIUC the refresh interval is about 5/10 min.We dont have direct update or notifier as of now.
        Hide
        sunilg Sunil G added a comment -

        + queue level readlock

        AbstractCSQueue#hasAccess
          public boolean hasAccess(QueueACL acl, UserGroupInformation user) {
            return authorizer.checkPermission(
                new AccessRequest(queueEntity, user, SchedulerUtils.toAccessType(acl),
                    null, null, Server.getRemoteAddress(), null));
        }
        

        We are currently invoking authorizer.checkPermission directly. So do we need queue readLock here?

        Submission time QUEUE_SUBMIT right we could cache but we need all

        Sorry. I could not get you. could you please help to elaborate.

        IIUC the refresh interval is about 5/10 min.We dont have direct update or notifier as of now.

        cache invalidate is needed in cases where user's acls are changed in system. Hence it makes sense.

        Show
        sunilg Sunil G added a comment - + queue level readlock AbstractCSQueue#hasAccess public boolean hasAccess(QueueACL acl, UserGroupInformation user) { return authorizer.checkPermission( new AccessRequest(queueEntity, user, SchedulerUtils.toAccessType(acl), null , null , Server.getRemoteAddress(), null )); } We are currently invoking authorizer.checkPermission directly. So do we need queue readLock here? Submission time QUEUE_SUBMIT right we could cache but we need all Sorry. I could not get you. could you please help to elaborate. IIUC the refresh interval is about 5/10 min.We dont have direct update or notifier as of now. cache invalidate is needed in cases where user's acls are changed in system. Hence it makes sense.
        Hide
        bibinchundatt Bibin A Chundatt added a comment - - edited

        Sunil G and Naganarasimha Garla

        Uploading in progress patch.

        Patch tries to minimize scheduler API calls

        1. Provides interface to getUserQueueACl based on user and queueName
        2. Caching/precalculation of rights will be done in different jira(Need interface from scheduler once queue refresh is done)
        Show
        bibinchundatt Bibin A Chundatt added a comment - - edited Sunil G and Naganarasimha Garla Uploading in progress patch. Patch tries to minimize scheduler API calls Provides interface to getUserQueueACl based on user and queueName Caching/precalculation of rights will be done in different jira(Need interface from scheduler once queue refresh is done)
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Please review patch attached

        Show
        bibinchundatt Bibin A Chundatt added a comment - Please review patch attached
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 25s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 13m 48s trunk passed
        +1 compile 9m 20s trunk passed
        +1 checkstyle 0m 57s trunk passed
        +1 mvnsite 1m 56s trunk passed
        +1 findbugs 3m 28s trunk passed
        +1 javadoc 1m 35s trunk passed
              Patch Compile Tests
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 29s the patch passed
        +1 compile 5m 50s the patch passed
        +1 cc 5m 50s the patch passed
        +1 javac 5m 50s the patch passed
        -0 checkstyle 0m 55s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 76 unchanged - 1 fixed = 80 total (was 77)
        +1 mvnsite 1m 53s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 49s the patch passed
        +1 javadoc 1m 34s the patch passed
              Other Tests
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 2m 29s hadoop-yarn-common in the patch passed.
        -1 unit 46m 31s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        105m 44s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
        Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6727
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880159/YARN-6727.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux cd195e0fbd4b 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 79df1e7
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16676/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/16676/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16676/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16676/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 13m 48s trunk passed +1 compile 9m 20s trunk passed +1 checkstyle 0m 57s trunk passed +1 mvnsite 1m 56s trunk passed +1 findbugs 3m 28s trunk passed +1 javadoc 1m 35s trunk passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 29s the patch passed +1 compile 5m 50s the patch passed +1 cc 5m 50s the patch passed +1 javac 5m 50s the patch passed -0 checkstyle 0m 55s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 76 unchanged - 1 fixed = 80 total (was 77) +1 mvnsite 1m 53s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 49s the patch passed +1 javadoc 1m 34s the patch passed       Other Tests +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 29s hadoop-yarn-common in the patch passed. -1 unit 46m 31s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 105m 44s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6727 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880159/YARN-6727.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux cd195e0fbd4b 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 79df1e7 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16676/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16676/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16676/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16676/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 45s Maven dependency ordering for branch
        +1 mvninstall 13m 59s trunk passed
        +1 compile 8m 43s trunk passed
        +1 checkstyle 0m 56s trunk passed
        +1 mvnsite 1m 55s trunk passed
        +1 findbugs 3m 25s trunk passed
        +1 javadoc 1m 34s trunk passed
              Patch Compile Tests
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 27s the patch passed
        +1 compile 5m 22s the patch passed
        +1 cc 5m 22s the patch passed
        +1 javac 5m 22s the patch passed
        -0 checkstyle 0m 59s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 75 unchanged - 1 fixed = 79 total (was 76)
        +1 mvnsite 1m 52s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 53s the patch passed
        +1 javadoc 1m 32s the patch passed
              Other Tests
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 2m 27s hadoop-yarn-common in the patch passed.
        +1 unit 42m 47s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        101m 20s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6727
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880159/YARN-6727.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux 91fb4507bfd2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 79df1e7
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16680/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16680/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16680/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 13m 59s trunk passed +1 compile 8m 43s trunk passed +1 checkstyle 0m 56s trunk passed +1 mvnsite 1m 55s trunk passed +1 findbugs 3m 25s trunk passed +1 javadoc 1m 34s trunk passed       Patch Compile Tests 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 5m 22s the patch passed +1 cc 5m 22s the patch passed +1 javac 5m 22s the patch passed -0 checkstyle 0m 59s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 75 unchanged - 1 fixed = 79 total (was 76) +1 mvnsite 1m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 53s the patch passed +1 javadoc 1m 32s the patch passed       Other Tests +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 27s hadoop-yarn-common in the patch passed. +1 unit 42m 47s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 101m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6727 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880159/YARN-6727.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 91fb4507bfd2 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 79df1e7 Default Java 1.8.0_131 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16680/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16680/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16680/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks Bibin A Chundatt,
        At first glance, approach looks good to me but few nits i observed was :

        1. YarnAuthorizationProvider.java ln 122: Get all permissions is invalid
        2. ClientRMService.java ln no 1022: there is possibility that the user is not admin but set his name as userName in the request, hence we should not throw exception
        3. ClientRMService.java ln no 1026 - 1039 : logic can be little optimized as we are calling twice queueACLsManager.getUserQueueACLInfo(queueNames, userUGI))
        4. Some checkstyle issues seems to be valid

        Will review completely and update if any more present.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks Bibin A Chundatt , At first glance, approach looks good to me but few nits i observed was : YarnAuthorizationProvider.java ln 122: Get all permissions is invalid ClientRMService.java ln no 1022: there is possibility that the user is not admin but set his name as userName in the request, hence we should not throw exception ClientRMService.java ln no 1026 - 1039 : logic can be little optimized as we are calling twice queueACLsManager.getUserQueueACLInfo(queueNames, userUGI)) Some checkstyle issues seems to be valid Will review completely and update if any more present.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Naganarasimha Garla
        Thank you for review attaching patch after handling comments.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Naganarasimha Garla Thank you for review attaching patch after handling comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 41s Maven dependency ordering for branch
        +1 mvninstall 15m 19s trunk passed
        +1 compile 9m 52s trunk passed
        +1 checkstyle 0m 58s trunk passed
        +1 mvnsite 2m 17s trunk passed
        +1 findbugs 3m 51s trunk passed
        +1 javadoc 1m 38s trunk passed
              Patch Compile Tests
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 33s the patch passed
        +1 compile 5m 42s the patch passed
        +1 cc 5m 42s the patch passed
        +1 javac 5m 42s the patch passed
        +1 checkstyle 0m 55s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77)
        +1 mvnsite 1m 54s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 1m 21s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 1m 33s the patch passed
              Other Tests
        +1 unit 0m 40s hadoop-yarn-api in the patch passed.
        +1 unit 2m 52s hadoop-yarn-common in the patch passed.
        +1 unit 46m 29s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        109m 32s



        Reason Tests
        FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Comparison of String objects using == or != in org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.getQueueUserAcls(GetQueueUserAclsInfoRequest) At ClientRMService.java:== or != in org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.getQueueUserAcls(GetQueueUserAclsInfoRequest) At ClientRMService.java:[line 1015]



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6727
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880601/YARN-6727.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux 96b89f359cfc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d91b7a8
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16731/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16731/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16731/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 41s Maven dependency ordering for branch +1 mvninstall 15m 19s trunk passed +1 compile 9m 52s trunk passed +1 checkstyle 0m 58s trunk passed +1 mvnsite 2m 17s trunk passed +1 findbugs 3m 51s trunk passed +1 javadoc 1m 38s trunk passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 33s the patch passed +1 compile 5m 42s the patch passed +1 cc 5m 42s the patch passed +1 javac 5m 42s the patch passed +1 checkstyle 0m 55s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 76 unchanged - 1 fixed = 76 total (was 77) +1 mvnsite 1m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 21s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 1m 33s the patch passed       Other Tests +1 unit 0m 40s hadoop-yarn-api in the patch passed. +1 unit 2m 52s hadoop-yarn-common in the patch passed. +1 unit 46m 29s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 109m 32s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Comparison of String objects using == or != in org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.getQueueUserAcls(GetQueueUserAclsInfoRequest) At ClientRMService.java:== or != in org.apache.hadoop.yarn.server.resourcemanager.ClientRMService.getQueueUserAcls(GetQueueUserAclsInfoRequest) At ClientRMService.java: [line 1015] Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6727 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880601/YARN-6727.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 96b89f359cfc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d91b7a8 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16731/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16731/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16731/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attaching updated patch

        Show
        bibinchundatt Bibin A Chundatt added a comment - Attaching updated patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 46s Maven dependency ordering for branch
        +1 mvninstall 17m 44s trunk passed
        +1 compile 11m 23s trunk passed
        +1 checkstyle 1m 8s trunk passed
        +1 mvnsite 2m 9s trunk passed
        +1 findbugs 4m 16s trunk passed
        +1 javadoc 1m 51s trunk passed
              Patch Compile Tests
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 43s the patch passed
        +1 compile 6m 52s the patch passed
        +1 cc 6m 52s the patch passed
        +1 javac 6m 52s the patch passed
        +1 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76)
        +1 mvnsite 2m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 18s the patch passed
        +1 javadoc 1m 30s the patch passed
              Other Tests
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 2m 27s hadoop-yarn-common in the patch passed.
        -1 unit 42m 58s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 29s The patch does not generate ASF License warnings.
        112m 15s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-6727
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881391/YARN-6727.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux dc11a4653b9f 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a32e013
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/16848/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16848/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/16848/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 46s Maven dependency ordering for branch +1 mvninstall 17m 44s trunk passed +1 compile 11m 23s trunk passed +1 checkstyle 1m 8s trunk passed +1 mvnsite 2m 9s trunk passed +1 findbugs 4m 16s trunk passed +1 javadoc 1m 51s trunk passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 43s the patch passed +1 compile 6m 52s the patch passed +1 cc 6m 52s the patch passed +1 javac 6m 52s the patch passed +1 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76) +1 mvnsite 2m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 18s the patch passed +1 javadoc 1m 30s the patch passed       Other Tests +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 27s hadoop-yarn-common in the patch passed. -1 unit 42m 58s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 112m 15s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6727 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881391/YARN-6727.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux dc11a4653b9f 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a32e013 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/16848/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16848/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16848/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment - - edited

        Naganarasimha Garla/Sunil G/Daniel Templeton Please review patch attached

        Show
        bibinchundatt Bibin A Chundatt added a comment - - edited Naganarasimha Garla / Sunil G / Daniel Templeton Please review patch attached
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch. Here are my comments:

        1. Minor nit: this if:
                if (!applicationsACLsManager.isAdmin(currentUGI) && userName != null
                    && !userName.equals(currentUGI.getShortUserName())) {

          would be more efficient if you did the null check first.

        2. I don't like ternary operators unless they actually make things more readable. This one:
                UserGroupInformation ugi = userName == null ?
                    currentUGI :
                    UserGroupInformation.createRemoteUser(userName);

          doesn't do it for me. It's much clearer to me to reuse currentUGI:

                if (userName != null) {
                  currentUGI = UserGroupInformation.createRemoteUser(userName);
                }
        3. You could apply the diamond operator in several places in QueueACLsManager.
        4. I prefer x != null to null != x.
        5. Any way we can avoid doing the string math in getShortQueueName()?
        6. Please add failure messages to the assertTrue() calls in the test code.
        Show
        templedf Daniel Templeton added a comment - Thanks for the patch. Here are my comments: Minor nit: this if : if (!applicationsACLsManager.isAdmin(currentUGI) && userName != null && !userName.equals(currentUGI.getShortUserName())) { would be more efficient if you did the null check first. I don't like ternary operators unless they actually make things more readable. This one: UserGroupInformation ugi = userName == null ? currentUGI : UserGroupInformation.createRemoteUser(userName); doesn't do it for me. It's much clearer to me to reuse currentUGI : if (userName != null ) { currentUGI = UserGroupInformation.createRemoteUser(userName); } You could apply the diamond operator in several places in QueueACLsManager . I prefer x != null to null != x . Any way we can avoid doing the string math in getShortQueueName() ? Please add failure messages to the assertTrue() calls in the test code.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Thank you Daniel Templeton for review comments. Attaching updated patch for the same

        Show
        bibinchundatt Bibin A Chundatt added a comment - Thank you Daniel Templeton for review comments. Attaching updated patch for the same
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 22s Maven dependency ordering for branch
        +1 mvninstall 15m 0s trunk passed
        +1 compile 9m 59s trunk passed
        +1 checkstyle 1m 3s trunk passed
        +1 mvnsite 2m 7s trunk passed
        +1 findbugs 3m 51s trunk passed
        -1 javadoc 0m 44s hadoop-yarn-common in trunk failed.
              Patch Compile Tests
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 38s the patch passed
        +1 compile 6m 19s the patch passed
        +1 cc 6m 19s the patch passed
        +1 javac 6m 19s the patch passed
        +1 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76)
        +1 mvnsite 2m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 4m 27s the patch passed
        -1 javadoc 0m 46s hadoop-yarn-common in the patch failed.
              Other Tests
        +1 unit 0m 38s hadoop-yarn-api in the patch passed.
        +1 unit 2m 39s hadoop-yarn-common in the patch passed.
        -1 unit 45m 41s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        109m 35s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue YARN-6727
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885298/YARN-6727.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux cf63fce47b4a 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ed162b7
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17279/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17279/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/17279/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17279/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/17279/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 15m 0s trunk passed +1 compile 9m 59s trunk passed +1 checkstyle 1m 3s trunk passed +1 mvnsite 2m 7s trunk passed +1 findbugs 3m 51s trunk passed -1 javadoc 0m 44s hadoop-yarn-common in trunk failed.       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 38s the patch passed +1 compile 6m 19s the patch passed +1 cc 6m 19s the patch passed +1 javac 6m 19s the patch passed +1 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76) +1 mvnsite 2m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 27s the patch passed -1 javadoc 0m 46s hadoop-yarn-common in the patch failed.       Other Tests +1 unit 0m 38s hadoop-yarn-api in the patch passed. +1 unit 2m 39s hadoop-yarn-common in the patch passed. -1 unit 45m 41s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 109m 35s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6727 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885298/YARN-6727.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux cf63fce47b4a 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ed162b7 Default Java 1.8.0_144 findbugs v3.1.0-RC1 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17279/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17279/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17279/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17279/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17279/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        sunilg Sunil G added a comment -

        Sorry for the delay. Thanks Bibin A Chundatt

        1. javadoc in GetQueueUserAclsInfoRequest is not very clear. Please help to update same getQueueUserAcls
        2. I think we can keep apis in GetQueueUserAclsInfoRequest as Unstable. Or were there any other discussion on same?
        3. Remove extra parenthesis in setUserName. ref GetQueueUserAclsInfoRequestPBImpl
        4. getPrivilageEntity to getPrivilegeEntity
        5. If we use an old client List<String> queueNames = request.getQueueNames(); could come as NULL. ref ClientRMService#getQueueUserAcls
        6. In QueueACLsManager#getQueueUserAclInfo, ugi is passed and checking against that. This might cause some backward compatibility issue as we are now more stricter ?
        Show
        sunilg Sunil G added a comment - Sorry for the delay. Thanks Bibin A Chundatt javadoc in GetQueueUserAclsInfoRequest is not very clear. Please help to update same getQueueUserAcls I think we can keep apis in GetQueueUserAclsInfoRequest as Unstable . Or were there any other discussion on same? Remove extra parenthesis in setUserName . ref GetQueueUserAclsInfoRequestPBImpl getPrivilageEntity to getPrivilegeEntity If we use an old client List<String> queueNames = request.getQueueNames(); could come as NULL. ref ClientRMService#getQueueUserAcls In QueueACLsManager#getQueueUserAclInfo , ugi is passed and checking against that. This might cause some backward compatibility issue as we are now more stricter ?
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Thank you Sunil G for review comments

        I think we can keep apis in GetQueueUserAclsInfoRequest as Unstable. Or were there any other discussion on same?

        Currently is stable and the way i understand about stable and unstable we can keep it same

        Stable
           * Can evolve while retaining compatibility for minor release boundaries.; 
           * can break compatibility only at major release (ie. at m.0).
        Unstable
           * No guarantee is provided as to reliability or stability across any
           * level of release granularity.
        

        If we use an old client List<String> queueNames = request.getQueueNames(); could come as NULL. ref ClientRMService#getQueueUserAcls

        IIUC repeated the default value should be EMPTY list .

            private void initFields() {
              queueNames_ = com.google.protobuf.LazyStringArrayList.EMPTY;
              userName_ = "";
            }
        

        All other comments are handled.

        Show
        bibinchundatt Bibin A Chundatt added a comment - Thank you Sunil G for review comments I think we can keep apis in GetQueueUserAclsInfoRequest as Unstable. Or were there any other discussion on same? Currently is stable and the way i understand about stable and unstable we can keep it same Stable * Can evolve while retaining compatibility for minor release boundaries.; * can break compatibility only at major release (ie. at m.0). Unstable * No guarantee is provided as to reliability or stability across any * level of release granularity. If we use an old client List<String> queueNames = request.getQueueNames(); could come as NULL. ref ClientRMService#getQueueUserAcls IIUC repeated the default value should be EMPTY list . private void initFields() { queueNames_ = com.google.protobuf.LazyStringArrayList.EMPTY; userName_ = ""; } All other comments are handled.
        Hide
        sunilg Sunil G added a comment -

        GetQueueUserAclsInfoRequest apis are updated in this new patch. And its going 3.1.0. I think its very early to call out as Stable.

        Show
        sunilg Sunil G added a comment - GetQueueUserAclsInfoRequest apis are updated in this new patch. And its going 3.1.0. I think its very early to call out as Stable.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 13m 39s trunk passed
        +1 compile 9m 30s trunk passed
        +1 checkstyle 0m 57s trunk passed
        +1 mvnsite 1m 59s trunk passed
        +1 findbugs 3m 35s trunk passed
        -1 javadoc 0m 46s hadoop-yarn-common in trunk failed.
              Patch Compile Tests
        0 mvndep 0m 10s Maven dependency ordering for patch
        +1 mvninstall 1m 35s the patch passed
        +1 compile 5m 40s the patch passed
        +1 cc 5m 40s the patch passed
        +1 javac 5m 40s the patch passed
        +1 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76)
        +1 mvnsite 1m 54s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 47s the patch passed
        -1 javadoc 0m 42s hadoop-yarn-common in the patch failed.
              Other Tests
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 2m 30s hadoop-yarn-common in the patch passed.
        -1 unit 44m 12s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        103m 30s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing
          hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
          hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue YARN-6727
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885380/YARN-6727.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux 7ca6a986c702 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5dba545
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17281/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17281/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/17281/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17281/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/17281/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 13m 39s trunk passed +1 compile 9m 30s trunk passed +1 checkstyle 0m 57s trunk passed +1 mvnsite 1m 59s trunk passed +1 findbugs 3m 35s trunk passed -1 javadoc 0m 46s hadoop-yarn-common in trunk failed.       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 35s the patch passed +1 compile 5m 40s the patch passed +1 cc 5m 40s the patch passed +1 javac 5m 40s the patch passed +1 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76) +1 mvnsite 1m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 47s the patch passed -1 javadoc 0m 42s hadoop-yarn-common in the patch failed.       Other Tests +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 30s hadoop-yarn-common in the patch passed. -1 unit 44m 12s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 103m 30s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6727 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885380/YARN-6727.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 7ca6a986c702 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5dba545 Default Java 1.8.0_144 findbugs v3.1.0-RC1 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17281/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17281/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17281/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17281/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17281/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        GetQueueUserAclsInfoRequest apis are updated in this new patch. And its going 3.1.0. I think its very early to call out as Stable.

        How about only for methods we mark as unstable ?

        Show
        bibinchundatt Bibin A Chundatt added a comment - GetQueueUserAclsInfoRequest apis are updated in this new patch. And its going 3.1.0. I think its very early to call out as Stable. How about only for methods we mark as unstable ?
        Hide
        sunilg Sunil G added a comment -

        Sure. I think its make sense to add this annotation for new apis added.

        Show
        sunilg Sunil G added a comment - Sure. I think its make sense to add this annotation for new apis added.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 9s Maven dependency ordering for branch
        +1 mvninstall 14m 37s trunk passed
        +1 compile 10m 19s trunk passed
        +1 checkstyle 1m 0s trunk passed
        +1 mvnsite 2m 1s trunk passed
        +1 findbugs 3m 36s trunk passed
        -1 javadoc 0m 47s hadoop-yarn-common in trunk failed.
              Patch Compile Tests
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 1m 44s the patch passed
        +1 compile 6m 34s the patch passed
        +1 cc 6m 34s the patch passed
        +1 javac 6m 34s the patch passed
        +1 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76)
        +1 mvnsite 1m 56s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 48s the patch passed
        -1 javadoc 0m 43s hadoop-yarn-common in the patch failed.
              Other Tests
        +1 unit 0m 33s hadoop-yarn-api in the patch passed.
        +1 unit 2m 31s hadoop-yarn-common in the patch passed.
        -1 unit 46m 39s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        109m 9s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
        Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue YARN-6727
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885380/YARN-6727.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux 8c874360dd66 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d4035d4
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17294/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17294/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/17294/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17294/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/17294/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 14m 37s trunk passed +1 compile 10m 19s trunk passed +1 checkstyle 1m 0s trunk passed +1 mvnsite 2m 1s trunk passed +1 findbugs 3m 36s trunk passed -1 javadoc 0m 47s hadoop-yarn-common in trunk failed.       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 44s the patch passed +1 compile 6m 34s the patch passed +1 cc 6m 34s the patch passed +1 javac 6m 34s the patch passed +1 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76) +1 mvnsite 1m 56s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 48s the patch passed -1 javadoc 0m 43s hadoop-yarn-common in the patch failed.       Other Tests +1 unit 0m 33s hadoop-yarn-api in the patch passed. +1 unit 2m 31s hadoop-yarn-common in the patch passed. -1 unit 46m 39s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 109m 9s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6727 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885380/YARN-6727.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 8c874360dd66 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d4035d4 Default Java 1.8.0_144 findbugs v3.1.0-RC1 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17294/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17294/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17294/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17294/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17294/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        Attaching patch after following updates

        1. queueNameList null check added in proto implementation
        2. java doc correction for conf in YarnAuthorizationProvider
        3. New api's added marked as unstable.
        Show
        bibinchundatt Bibin A Chundatt added a comment - Attaching patch after following updates queueNameList null check added in proto implementation java doc correction for conf in YarnAuthorizationProvider New api's added marked as unstable.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 42s Maven dependency ordering for branch
        +1 mvninstall 12m 54s trunk passed
        +1 compile 9m 15s trunk passed
        +1 checkstyle 0m 49s trunk passed
        +1 mvnsite 1m 47s trunk passed
        +1 findbugs 3m 15s trunk passed
        +1 javadoc 1m 25s trunk passed
              Patch Compile Tests
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 1m 24s the patch passed
        +1 compile 6m 0s the patch passed
        +1 cc 6m 0s the patch passed
        +1 javac 6m 0s the patch passed
        +1 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76)
        +1 mvnsite 1m 52s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 3m 32s the patch passed
        +1 javadoc 0m 22s hadoop-yarn-api in the patch passed.
        +1 javadoc 0m 35s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 0 new + 4458 unchanged - 1 fixed = 4458 total (was 4459)
        +1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch passed.
              Other Tests
        +1 unit 0m 32s hadoop-yarn-api in the patch passed.
        +1 unit 2m 38s hadoop-yarn-common in the patch passed.
        -1 unit 46m 51s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        105m 10s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue YARN-6727
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887062/YARN-6727.006.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
        uname Linux 21a59e0b1f71 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 50764ef
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-YARN-Build/17476/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17476/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/17476/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 42s Maven dependency ordering for branch +1 mvninstall 12m 54s trunk passed +1 compile 9m 15s trunk passed +1 checkstyle 0m 49s trunk passed +1 mvnsite 1m 47s trunk passed +1 findbugs 3m 15s trunk passed +1 javadoc 1m 25s trunk passed       Patch Compile Tests 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 24s the patch passed +1 compile 6m 0s the patch passed +1 cc 6m 0s the patch passed +1 javac 6m 0s the patch passed +1 checkstyle 0m 48s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 75 unchanged - 1 fixed = 75 total (was 76) +1 mvnsite 1m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 32s the patch passed +1 javadoc 0m 22s hadoop-yarn-api in the patch passed. +1 javadoc 0m 35s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common generated 0 new + 4458 unchanged - 1 fixed = 4458 total (was 4459) +1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch passed.       Other Tests +1 unit 0m 32s hadoop-yarn-api in the patch passed. +1 unit 2m 38s hadoop-yarn-common in the patch passed. -1 unit 46m 51s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 105m 10s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6727 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887062/YARN-6727.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 21a59e0b1f71 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 50764ef Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/17476/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17476/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17476/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            bibinchundatt Bibin A Chundatt
            Reporter:
            bibinchundatt Bibin A Chundatt
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development