Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6615

AmIpFilter drops query parameters on redirect

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0, 2.7.3, 2.6.5, 3.0.0-alpha2
    • Fix Version/s: 2.9.0, 2.7.4, 2.6.6, 3.0.0-alpha4, 2.8.2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      When an AM web request is redirected to the RM the query parameters are dropped from the web request.

      This happens for Spark as described in SPARK-20772.
      The repro steps are:

      • Start up the spark-shell in yarn mode and run a job
      • Try to access the job details through http://<fqdn>:4040/jobs/job?id=0
      • A HTTP ERROR 400 is thrown (requirement failed: missing id parameter)

      This works fine in local or standalone mode, but does not work on Yarn where the query parameter is dropped. If the UI filter org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter is removed from the config which shows that the problem is in the filter

      1. YARN-6615.1.patch
        3 kB
        Wilfred Spiegelenburg
      2. YARN-6615-branch-2.6.1.patch
        3 kB
        Wilfred Spiegelenburg
      3. YARN-6615-branch-2.6.2.patch
        3 kB
        Wilfred Spiegelenburg
      4. YARN-6615-branch-2.6.3.patch
        4 kB
        Wilfred Spiegelenburg
      5. YARN-6615-branch-2.8.1.patch
        3 kB
        Wilfred Spiegelenburg

        Issue Links

          Activity

          Hide
          wilfreds Wilfred Spiegelenburg added a comment -

          Adding the query parameters if set before we trigger the redirect including a new test

          Show
          wilfreds Wilfred Spiegelenburg added a comment - Adding the query parameters if set before we trigger the redirect including a new test
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 12m 22s trunk passed
          +1 compile 0m 14s trunk passed
          +1 checkstyle 0m 10s trunk passed
          +1 mvnsite 0m 16s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 25s trunk passed
          +1 javadoc 0m 10s trunk passed
          +1 mvninstall 0m 14s the patch passed
          +1 compile 0m 13s the patch passed
          +1 javac 0m 13s the patch passed
          +1 checkstyle 0m 8s the patch passed
          +1 mvnsite 0m 14s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 30s the patch passed
          +1 javadoc 0m 9s the patch passed
          +1 unit 0m 22s hadoop-yarn-server-web-proxy in the patch passed.
          +1 asflicense 0m 13s The patch does not generate ASF License warnings.
          17m 34s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue YARN-6615
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868515/YARN-6615.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux d6b735b982f8 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 035d468
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15947/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15947/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 12m 22s trunk passed +1 compile 0m 14s trunk passed +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 16s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 10s trunk passed +1 mvninstall 0m 14s the patch passed +1 compile 0m 13s the patch passed +1 javac 0m 13s the patch passed +1 checkstyle 0m 8s the patch passed +1 mvnsite 0m 14s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 30s the patch passed +1 javadoc 0m 9s the patch passed +1 unit 0m 22s hadoop-yarn-server-web-proxy in the patch passed. +1 asflicense 0m 13s The patch does not generate ASF License warnings. 17m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6615 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868515/YARN-6615.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d6b735b982f8 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 035d468 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15947/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy Console output https://builds.apache.org/job/PreCommit-YARN-Build/15947/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the report and patch! amrmproxy refers to a component of YARN federation and is unrelated, so I removed it. I also updated the affected versions since this appears to be a long-standing bug and not just in the most recent 3.x alpha release.

          +1 for the patch. Would you mind providing a patch for branch-2.8 as well? I think that patch should apply to branch-2.7 as well since those two branches have the same code for the two files involved.

          Show
          jlowe Jason Lowe added a comment - Thanks for the report and patch! amrmproxy refers to a component of YARN federation and is unrelated, so I removed it. I also updated the affected versions since this appears to be a long-standing bug and not just in the most recent 3.x alpha release. +1 for the patch. Would you mind providing a patch for branch-2.8 as well? I think that patch should apply to branch-2.7 as well since those two branches have the same code for the two files involved.
          Hide
          Tagar Ruslan Dautkhanov added a comment -

          Thank you Wilfred Spiegelenburg. Is this possible to backport this patch to Hadoop 2.6 as well?

          Show
          Tagar Ruslan Dautkhanov added a comment - Thank you Wilfred Spiegelenburg . Is this possible to backport this patch to Hadoop 2.6 as well?
          Hide
          wilfreds Wilfred Spiegelenburg added a comment -

          As requested a patch for branch-2.8. This patch also applied to branch-2.7

          Show
          wilfreds Wilfred Spiegelenburg added a comment - As requested a patch for branch-2.8. This patch also applied to branch-2.7
          Hide
          wilfreds Wilfred Spiegelenburg added a comment -

          Patch for branch-2.6, slightly different than the branch-2.8 patch because there is no ProxyUtils yet

          The trunk patch applies to branch-2 also which seems to have covered all open branches

          Show
          wilfreds Wilfred Spiegelenburg added a comment - Patch for branch-2.6, slightly different than the branch-2.8 patch because there is no ProxyUtils yet The trunk patch applies to branch-2 also which seems to have covered all open branches
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 48s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          -1 mvninstall 1m 48s root in branch-2.6.1 failed.
          +1 compile 0m 26s branch-2.6.1 passed with JDK v1.8.0_131
          +1 compile 0m 11s branch-2.6.1 passed with JDK v1.7.0_131
          +1 checkstyle 0m 11s branch-2.6.1 passed
          +1 mvnsite 0m 19s branch-2.6.1 passed
          +1 mvneclipse 0m 11s branch-2.6.1 passed
          +1 findbugs 0m 23s branch-2.6.1 passed
          -1 javadoc 0m 9s hadoop-yarn-server-web-proxy in branch-2.6.1 failed with JDK v1.8.0_131.
          +1 javadoc 0m 10s branch-2.6.1 passed with JDK v1.7.0_131
          +1 mvninstall 0m 12s the patch passed
          +1 compile 0m 9s the patch passed with JDK v1.8.0_131
          +1 javac 0m 9s the patch passed
          +1 compile 0m 12s the patch passed with JDK v1.7.0_131
          +1 javac 0m 12s the patch passed
          +1 checkstyle 0m 9s the patch passed
          +1 mvnsite 0m 16s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          -1 whitespace 0m 2s The patch has 769 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 22s The patch 73 line(s) with tabs.
          -1 findbugs 0m 36s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 8s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.8.0_131.
          +1 javadoc 0m 10s the patch passed with JDK v1.7.0_131
          -1 unit 0m 18s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.7.0_131.
          -1 asflicense 0m 28s The patch generated 98 ASF License warnings.
          22m 27s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
            HTTP parameter directly written to HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java:HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java:[line 146]
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.webproxy.amfilter.TestAmFilter
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.webproxy.amfilter.TestAmFilter



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2017-05-18
          JIRA Issue YARN-6615
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868673/YARN-6615-branch-2.6.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 02805dedf4b7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6.1 / 41d19f4
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v1.3.9
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15956/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15956/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 48s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvninstall 1m 48s root in branch-2.6.1 failed. +1 compile 0m 26s branch-2.6.1 passed with JDK v1.8.0_131 +1 compile 0m 11s branch-2.6.1 passed with JDK v1.7.0_131 +1 checkstyle 0m 11s branch-2.6.1 passed +1 mvnsite 0m 19s branch-2.6.1 passed +1 mvneclipse 0m 11s branch-2.6.1 passed +1 findbugs 0m 23s branch-2.6.1 passed -1 javadoc 0m 9s hadoop-yarn-server-web-proxy in branch-2.6.1 failed with JDK v1.8.0_131. +1 javadoc 0m 10s branch-2.6.1 passed with JDK v1.7.0_131 +1 mvninstall 0m 12s the patch passed +1 compile 0m 9s the patch passed with JDK v1.8.0_131 +1 javac 0m 9s the patch passed +1 compile 0m 12s the patch passed with JDK v1.7.0_131 +1 javac 0m 12s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 16s the patch passed +1 mvneclipse 0m 9s the patch passed -1 whitespace 0m 2s The patch has 769 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 22s The patch 73 line(s) with tabs. -1 findbugs 0m 36s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 8s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.8.0_131. +1 javadoc 0m 10s the patch passed with JDK v1.7.0_131 -1 unit 0m 18s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.7.0_131. -1 asflicense 0m 28s The patch generated 98 ASF License warnings. 22m 27s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy   HTTP parameter directly written to HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java:HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java: [line 146] JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.webproxy.amfilter.TestAmFilter JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.webproxy.amfilter.TestAmFilter Subsystem Report/Notes Docker Image:yetus/hadoop:date2017-05-18 JIRA Issue YARN-6615 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868673/YARN-6615-branch-2.6.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 02805dedf4b7 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6.1 / 41d19f4 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/branch-mvninstall-root.txt findbugs v1.3.9 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15956/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/15956/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy Console output https://builds.apache.org/job/PreCommit-YARN-Build/15956/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 51s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          -1 mvninstall 1m 47s root in branch-2.6.1 failed.
          +1 compile 0m 25s branch-2.6.1 passed with JDK v1.8.0_131
          +1 compile 0m 10s branch-2.6.1 passed with JDK v1.7.0_131
          +1 checkstyle 0m 10s branch-2.6.1 passed
          +1 mvnsite 0m 18s branch-2.6.1 passed
          +1 mvneclipse 0m 11s branch-2.6.1 passed
          +1 findbugs 0m 24s branch-2.6.1 passed
          -1 javadoc 0m 9s hadoop-yarn-server-web-proxy in branch-2.6.1 failed with JDK v1.8.0_131.
          +1 javadoc 0m 10s branch-2.6.1 passed with JDK v1.7.0_131
          +1 mvninstall 0m 11s the patch passed
          +1 compile 0m 8s the patch passed with JDK v1.8.0_131
          +1 javac 0m 8s the patch passed
          +1 compile 0m 11s the patch passed with JDK v1.7.0_131
          +1 javac 0m 11s the patch passed
          +1 checkstyle 0m 9s the patch passed
          +1 mvnsite 0m 15s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          -1 whitespace 0m 1s The patch has 1088 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 25s The patch 73 line(s) with tabs.
          -1 findbugs 0m 40s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 9s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.8.0_131.
          +1 javadoc 0m 11s the patch passed with JDK v1.7.0_131
          -1 unit 0m 20s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.7.0_131.
          -1 asflicense 0m 30s The patch generated 98 ASF License warnings.
          22m 44s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
            HTTP parameter directly written to HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java:HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java:[line 146]
          JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.webproxy.amfilter.TestAmFilter
          JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.webproxy.amfilter.TestAmFilter



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2017-05-18
          JIRA Issue YARN-6615
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868673/YARN-6615-branch-2.6.1.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7398cad7b7cc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6.1 / 41d19f4
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v1.3.9
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15957/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15957/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 51s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvninstall 1m 47s root in branch-2.6.1 failed. +1 compile 0m 25s branch-2.6.1 passed with JDK v1.8.0_131 +1 compile 0m 10s branch-2.6.1 passed with JDK v1.7.0_131 +1 checkstyle 0m 10s branch-2.6.1 passed +1 mvnsite 0m 18s branch-2.6.1 passed +1 mvneclipse 0m 11s branch-2.6.1 passed +1 findbugs 0m 24s branch-2.6.1 passed -1 javadoc 0m 9s hadoop-yarn-server-web-proxy in branch-2.6.1 failed with JDK v1.8.0_131. +1 javadoc 0m 10s branch-2.6.1 passed with JDK v1.7.0_131 +1 mvninstall 0m 11s the patch passed +1 compile 0m 8s the patch passed with JDK v1.8.0_131 +1 javac 0m 8s the patch passed +1 compile 0m 11s the patch passed with JDK v1.7.0_131 +1 javac 0m 11s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 15s the patch passed +1 mvneclipse 0m 9s the patch passed -1 whitespace 0m 1s The patch has 1088 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 25s The patch 73 line(s) with tabs. -1 findbugs 0m 40s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 9s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.8.0_131. +1 javadoc 0m 11s the patch passed with JDK v1.7.0_131 -1 unit 0m 20s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.7.0_131. -1 asflicense 0m 30s The patch generated 98 ASF License warnings. 22m 44s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy   HTTP parameter directly written to HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java:HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java: [line 146] JDK v1.8.0_131 Failed junit tests hadoop.yarn.server.webproxy.amfilter.TestAmFilter JDK v1.7.0_131 Failed junit tests hadoop.yarn.server.webproxy.amfilter.TestAmFilter Subsystem Report/Notes Docker Image:yetus/hadoop:date2017-05-18 JIRA Issue YARN-6615 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868673/YARN-6615-branch-2.6.1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7398cad7b7cc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6.1 / 41d19f4 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/branch-mvninstall-root.txt findbugs v1.3.9 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15957/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/15957/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy Console output https://builds.apache.org/job/PreCommit-YARN-Build/15957/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          Tagar Ruslan Dautkhanov added a comment -

          Thanks a lot Wilfred Spiegelenburg for such prompt response.

          Show
          Tagar Ruslan Dautkhanov added a comment - Thanks a lot Wilfred Spiegelenburg for such prompt response.
          Hide
          wilfreds Wilfred Spiegelenburg added a comment -

          Attached the wrong version of the patch this one has the fixed junit test and passes the redirect URL correctly through the encoding.

          The find bugs warning would need more to fix and would require most of what we do in ProxyUtils in later releases. let me know if that needs fixing for branch-2.6 or not.

          Show
          wilfreds Wilfred Spiegelenburg added a comment - Attached the wrong version of the patch this one has the fixed junit test and passes the redirect URL correctly through the encoding. The find bugs warning would need more to fix and would require most of what we do in ProxyUtils in later releases. let me know if that needs fixing for branch-2.6 or not.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 52s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          -1 mvninstall 1m 49s root in branch-2.6.2 failed.
          +1 compile 0m 27s branch-2.6.2 passed with JDK v1.8.0_131
          +1 compile 0m 11s branch-2.6.2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 10s branch-2.6.2 passed
          +1 mvnsite 0m 17s branch-2.6.2 passed
          +1 mvneclipse 0m 12s branch-2.6.2 passed
          +1 findbugs 0m 23s branch-2.6.2 passed
          -1 javadoc 0m 9s hadoop-yarn-server-web-proxy in branch-2.6.2 failed with JDK v1.8.0_131.
          +1 javadoc 0m 11s branch-2.6.2 passed with JDK v1.7.0_131
          +1 mvninstall 0m 12s the patch passed
          +1 compile 0m 8s the patch passed with JDK v1.8.0_131
          +1 javac 0m 8s the patch passed
          +1 compile 0m 11s the patch passed with JDK v1.7.0_131
          +1 javac 0m 11s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 16s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          -1 whitespace 0m 1s The patch has 1429 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 30s The patch 73 line(s) with tabs.
          -1 findbugs 0m 34s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 javadoc 0m 8s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.8.0_131.
          +1 javadoc 0m 10s the patch passed with JDK v1.7.0_131
          +1 unit 0m 18s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_131.
          -1 asflicense 0m 27s The patch generated 98 ASF License warnings.
          22m 42s



          Reason Tests
          FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
            HTTP parameter directly written to HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java:HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java:[line 147]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2017-05-18
          JIRA Issue YARN-6615
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868739/YARN-6615-branch-2.6.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a68d1d803666 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6.2 / 32b9050
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v1.3.9
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/whitespace-tabs.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15964/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/15964/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 13m 52s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvninstall 1m 49s root in branch-2.6.2 failed. +1 compile 0m 27s branch-2.6.2 passed with JDK v1.8.0_131 +1 compile 0m 11s branch-2.6.2 passed with JDK v1.7.0_131 +1 checkstyle 0m 10s branch-2.6.2 passed +1 mvnsite 0m 17s branch-2.6.2 passed +1 mvneclipse 0m 12s branch-2.6.2 passed +1 findbugs 0m 23s branch-2.6.2 passed -1 javadoc 0m 9s hadoop-yarn-server-web-proxy in branch-2.6.2 failed with JDK v1.8.0_131. +1 javadoc 0m 11s branch-2.6.2 passed with JDK v1.7.0_131 +1 mvninstall 0m 12s the patch passed +1 compile 0m 8s the patch passed with JDK v1.8.0_131 +1 javac 0m 8s the patch passed +1 compile 0m 11s the patch passed with JDK v1.7.0_131 +1 javac 0m 11s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 16s the patch passed +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 1s The patch has 1429 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 30s The patch 73 line(s) with tabs. -1 findbugs 0m 34s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 javadoc 0m 8s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.8.0_131. +1 javadoc 0m 10s the patch passed with JDK v1.7.0_131 +1 unit 0m 18s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_131. -1 asflicense 0m 27s The patch generated 98 ASF License warnings. 22m 42s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy   HTTP parameter directly written to HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java:HTTP header output in org.apache.hadoop.yarn.server.webproxy.amfilter.AmIpFilter.doFilter(ServletRequest, ServletResponse, FilterChain) At AmIpFilter.java: [line 147] Subsystem Report/Notes Docker Image:yetus/hadoop:date2017-05-18 JIRA Issue YARN-6615 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12868739/YARN-6615-branch-2.6.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a68d1d803666 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6.2 / 32b9050 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/branch-mvninstall-root.txt findbugs v1.3.9 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/whitespace-tabs.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15964/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/15964/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy Console output https://builds.apache.org/job/PreCommit-YARN-Build/15964/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for backporting the patches! +1 for the branch-2.8/branch-2.7 patch, lgtm. I'm not sure about the branch-2.6 patch since the findbugs warning sounds ominous, as in "you always have a bug if this is being flagged" type of issue.

          If there are no objections I'll commit the patches down through 2.7 tomorrow, but I'm looking for someone with more knowledge on the findbugs warning to see what needs to be done for 2.6 before that patch is committed.

          Show
          jlowe Jason Lowe added a comment - Thanks for backporting the patches! +1 for the branch-2.8/branch-2.7 patch, lgtm. I'm not sure about the branch-2.6 patch since the findbugs warning sounds ominous, as in "you always have a bug if this is being flagged" type of issue. If there are no objections I'll commit the patches down through 2.7 tomorrow, but I'm looking for someone with more knowledge on the findbugs warning to see what needs to be done for 2.6 before that patch is committed.
          Hide
          wilfreds Wilfred Spiegelenburg added a comment -

          OK, found a simple way to fix the findbugs warning. Parse and then re-add the parameters: this is done under the covers in the buildTrackingUrl and its use of the UriBuilder in later versions.

          ran findbugs before and after

          Show
          wilfreds Wilfred Spiegelenburg added a comment - OK, found a simple way to fix the findbugs warning. Parse and then re-add the parameters: this is done under the covers in the buildTrackingUrl and its use of the UriBuilder in later versions. ran findbugs before and after
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          0 docker 0m 8s Dockerfile '/home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/dev-support/docker/Dockerfile' not found, falling back to built-in.
          -1 docker 7m 26s Docker failed to build yetus/hadoop:date2017-05-24.



          Subsystem Report/Notes
          JIRA Issue YARN-6615
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869589/YARN-6615-branch-2.6.3.patch
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16004/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. 0 docker 0m 8s Dockerfile '/home/jenkins/jenkins-slave/workspace/PreCommit-YARN-Build/dev-support/docker/Dockerfile' not found, falling back to built-in. -1 docker 7m 26s Docker failed to build yetus/hadoop:date2017-05-24. Subsystem Report/Notes JIRA Issue YARN-6615 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869589/YARN-6615-branch-2.6.3.patch Console output https://builds.apache.org/job/PreCommit-YARN-Build/16004/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          -1 mvninstall 2m 2s root in branch-2.6.3 failed.
          +1 compile 0m 32s branch-2.6.3 passed with JDK v1.8.0_131
          +1 compile 0m 12s branch-2.6.3 passed with JDK v1.7.0_131
          +1 checkstyle 0m 13s branch-2.6.3 passed
          +1 mvnsite 0m 21s branch-2.6.3 passed
          +1 mvneclipse 0m 14s branch-2.6.3 passed
          +1 findbugs 0m 29s branch-2.6.3 passed
          -1 javadoc 0m 12s hadoop-yarn-server-web-proxy in branch-2.6.3 failed with JDK v1.8.0_131.
          +1 javadoc 0m 12s branch-2.6.3 passed with JDK v1.7.0_131
          +1 mvninstall 0m 14s the patch passed
          +1 compile 0m 11s the patch passed with JDK v1.8.0_131
          +1 javac 0m 11s the patch passed
          +1 compile 0m 13s the patch passed with JDK v1.7.0_131
          +1 javac 0m 13s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 17s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          -1 whitespace 0m 1s The patch has 1803 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          -1 whitespace 0m 48s The patch 73 line(s) with tabs.
          +1 findbugs 0m 40s the patch passed
          -1 javadoc 0m 12s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.8.0_131.
          +1 javadoc 0m 12s the patch passed with JDK v1.7.0_131
          +1 unit 0m 23s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_131.
          -1 asflicense 0m 39s The patch generated 98 ASF License warnings.
          11m 3s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2017-05-24
          JIRA Issue YARN-6615
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869589/YARN-6615-branch-2.6.3.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 33fb80628fcb 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6.3 / cc865b4
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/branch-mvninstall-root.txt
          findbugs v1.3.9
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/whitespace-tabs.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16007/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/16007/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. -1 mvninstall 2m 2s root in branch-2.6.3 failed. +1 compile 0m 32s branch-2.6.3 passed with JDK v1.8.0_131 +1 compile 0m 12s branch-2.6.3 passed with JDK v1.7.0_131 +1 checkstyle 0m 13s branch-2.6.3 passed +1 mvnsite 0m 21s branch-2.6.3 passed +1 mvneclipse 0m 14s branch-2.6.3 passed +1 findbugs 0m 29s branch-2.6.3 passed -1 javadoc 0m 12s hadoop-yarn-server-web-proxy in branch-2.6.3 failed with JDK v1.8.0_131. +1 javadoc 0m 12s branch-2.6.3 passed with JDK v1.7.0_131 +1 mvninstall 0m 14s the patch passed +1 compile 0m 11s the patch passed with JDK v1.8.0_131 +1 javac 0m 11s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_131 +1 javac 0m 13s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 17s the patch passed +1 mvneclipse 0m 10s the patch passed -1 whitespace 0m 1s The patch has 1803 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 whitespace 0m 48s The patch 73 line(s) with tabs. +1 findbugs 0m 40s the patch passed -1 javadoc 0m 12s hadoop-yarn-server-web-proxy in the patch failed with JDK v1.8.0_131. +1 javadoc 0m 12s the patch passed with JDK v1.7.0_131 +1 unit 0m 23s hadoop-yarn-server-web-proxy in the patch passed with JDK v1.7.0_131. -1 asflicense 0m 39s The patch generated 98 ASF License warnings. 11m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:date2017-05-24 JIRA Issue YARN-6615 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12869589/YARN-6615-branch-2.6.3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 33fb80628fcb 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6.3 / cc865b4 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/branch-mvninstall-root.txt findbugs v1.3.9 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/whitespace-tabs.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-web-proxy-jdk1.8.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16007/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/16007/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy Console output https://builds.apache.org/job/PreCommit-YARN-Build/16007/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the 2.6 patch! +1 for that patch as well. Committing this.

          Show
          jlowe Jason Lowe added a comment - Thanks for updating the 2.6 patch! +1 for that patch as well. Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Wilfred Spiegelenburg! I committed this to trunk, branch-2, branch-2.8, branch-2.8.1, branch-2.7, and branch-2.6.

          Show
          jlowe Jason Lowe added a comment - Thanks, Wilfred Spiegelenburg ! I committed this to trunk, branch-2, branch-2.8, branch-2.8.1, branch-2.7, and branch-2.6.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11772 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11772/)
          YARN-6615. AmIpFilter drops query parameters on redirect. Contributed by (jlowe: rev 8bf1949c0efed700781eb47cf18f9f88443ed506)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/amfilter/AmIpFilter.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/amfilter/TestAmFilter.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11772 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11772/ ) YARN-6615 . AmIpFilter drops query parameters on redirect. Contributed by (jlowe: rev 8bf1949c0efed700781eb47cf18f9f88443ed506) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/amfilter/AmIpFilter.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/amfilter/TestAmFilter.java
          Hide
          wilfreds Wilfred Spiegelenburg added a comment -

          Thank you Jason Lowe for the reviews and the commit

          Show
          wilfreds Wilfred Spiegelenburg added a comment - Thank you Jason Lowe for the reviews and the commit
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

            People

            • Assignee:
              wilfreds Wilfred Spiegelenburg
              Reporter:
              wilfreds Wilfred Spiegelenburg
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development