Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: YARN-3926
    • Fix Version/s: 3.1.0
    • Component/s: fairscheduler
    • Labels:
      None
    1. YARN-6612.YARN-3926.014.patch
      82 kB
      Daniel Templeton
    2. YARN-6612.YARN-3926.013.patch
      82 kB
      Daniel Templeton
    3. YARN-6612.YARN-3926.012.patch
      82 kB
      Daniel Templeton
    4. YARN-6612.YARN-3926.011.patch
      62 kB
      Daniel Templeton
    5. YARN-6612.YARN-3926.010.patch
      61 kB
      Daniel Templeton
    6. YARN-6612.YARN-3926.009.patch
      20 kB
      Daniel Templeton
    7. YARN-6612.YARN-3926.008.patch
      57 kB
      Daniel Templeton
    8. YARN-6612.YARN-3926.007.patch
      57 kB
      Daniel Templeton
    9. YARN-6612.YARN-3926.006.patch
      57 kB
      Daniel Templeton
    10. YARN-6612.YARN-3926.005.patch
      56 kB
      Daniel Templeton
    11. YARN-6612.YARN-3926.004.patch
      56 kB
      Daniel Templeton
    12. YARN-6612.YARN-3926.002.patch
      70 kB
      Daniel Templeton
    13. YARN-6612.YARN-3926.001.patch
      71 kB
      Daniel Templeton
    14. YARN-6612.016.patch
      82 kB
      Daniel Templeton
    15. YARN-6612.015.patch
      82 kB
      Daniel Templeton

      Activity

      Hide
      templedf Daniel Templeton added a comment -

      Here's an initial patch. Comments welcome.

      Show
      templedf Daniel Templeton added a comment - Here's an initial patch. Comments welcome.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 0s Docker mode activated.
      -1 patch 0m 5s YARN-6612 does not apply to YARN-3926. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



      Subsystem Report/Notes
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877684/YARN-6612.YARN-3926.001.patch
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/16474/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s YARN-6612 does not apply to YARN-3926 . Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877684/YARN-6612.YARN-3926.001.patch Console output https://builds.apache.org/job/PreCommit-YARN-Build/16474/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Here's a rebased patch.

      Show
      templedf Daniel Templeton added a comment - Here's a rebased patch.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 18s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 45s Maven dependency ordering for branch
      +1 mvninstall 13m 52s YARN-3926 passed
      +1 compile 8m 49s YARN-3926 passed
      +1 checkstyle 0m 56s YARN-3926 passed
      +1 mvnsite 2m 6s YARN-3926 passed
      -1 findbugs 2m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in YARN-3926 has 1 extant Findbugs warnings.
      +1 javadoc 1m 26s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 25s the patch passed
      +1 compile 5m 21s the patch passed
      +1 javac 5m 21s the patch passed
      -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 255 unchanged - 4 fixed = 263 total (was 259)
      +1 mvnsite 1m 54s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
      +1 javadoc 1m 33s the patch passed
            Other Tests
      +1 unit 0m 36s hadoop-yarn-api in the patch passed.
      +1 unit 2m 26s hadoop-yarn-common in the patch passed.
      -1 unit 43m 3s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 34s The patch does not generate ASF License warnings.
      102m 41s



      Reason Tests
      FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        org.apache.hadoop.yarn.server.resourcemanager.resource.ResourceWeights$ResourceWeight defines compareTo(ResourceWeights$ResourceWeight) and uses Object.equals() At ResourceWeights.java:Object.equals() At ResourceWeights.java:[line 136]
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue
        hadoop.yarn.server.resourcemanager.TestRMRestart
        hadoop.yarn.server.resourcemanager.TestAppManager
        hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878060/YARN-6612.YARN-3926.002.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 0fd4dec540e3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 419bb55
      Default Java 1.8.0_131
      findbugs v3.1.0-RC1
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16494/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-warnings.html
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16494/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16494/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
      unit https://builds.apache.org/job/PreCommit-YARN-Build/16494/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16494/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/16494/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 13m 52s YARN-3926 passed +1 compile 8m 49s YARN-3926 passed +1 checkstyle 0m 56s YARN-3926 passed +1 mvnsite 2m 6s YARN-3926 passed -1 findbugs 2m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api in YARN-3926 has 1 extant Findbugs warnings. +1 javadoc 1m 26s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 25s the patch passed +1 compile 5m 21s the patch passed +1 javac 5m 21s the patch passed -0 checkstyle 0m 54s hadoop-yarn-project/hadoop-yarn: The patch generated 8 new + 255 unchanged - 4 fixed = 263 total (was 259) +1 mvnsite 1m 54s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 1m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 1m 33s the patch passed       Other Tests +1 unit 0m 36s hadoop-yarn-api in the patch passed. +1 unit 2m 26s hadoop-yarn-common in the patch passed. -1 unit 43m 3s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 102m 41s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   org.apache.hadoop.yarn.server.resourcemanager.resource.ResourceWeights$ResourceWeight defines compareTo(ResourceWeights$ResourceWeight) and uses Object.equals() At ResourceWeights.java:Object.equals() At ResourceWeights.java: [line 136] Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestLeafQueue   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestAppManager   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacityScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878060/YARN-6612.YARN-3926.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0fd4dec540e3 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 419bb55 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16494/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16494/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16494/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/16494/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16494/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16494/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      yufeigu Yufei Gu added a comment -

      Some major thoughts:

      1. I prefer to put functionality of ResourceWeights sort(e.g., getResourcesSortedByWeight) in class DominantResourceFairnessComparator, that case we could exam the performance of compare() more easily. That is due to when I was thinking about which data structure is better for ResourceWeights#resources, ArrayList or TreeSet. They seems no difference in compare().
      2. Another performance improvement would be calculating fair share only if necessary, which is similar to what YARN-6307 does. I guess we can do similar refactor in this jira.
      3. I'm not sure we handle minShare usage well, e.g. what if multiple resource usages are under their minShare, but we probably think more about it and somehow solve it in followup JIRAs.

      Minor ones:

      1. Why remove the FileNotFoundException fe in LOG.info() in Class ResourceUtils?
      2. {float weight = 0.0f;}

        in ResourceWeights initialization is not necessary.

      3. We can't use ResourceType here, for (int i = 0; i < ResourceType.values().length; i++) in ResourceWeights#toString. Moreover, the enum ResourceType and related code should be removed.
      4. Several unused imports
      5. I like the refactor of ResourceNotFoundException. Do we need this method ResourceNotFoundException(String resource, Throwable cause) since it is never used?
      6. Method getResourceInformation() throw an unchecked exception, which isn't necessary to go into the method signature. This applies to getResourceValue() and several other methods in this class. Some of them you didn't touch. Maybe you follow the convention, but why do we do that at the first place? Besides that, ResourcePBImpl#getResourceInformation doesn't throw ResourceNotFoundException in method signature, but ResourcePBImpl#setResourceValue does. I think we need to solve this inconsistency.
      7. I like new message in class ResourceNotFoundException, can we also provide possible reasons of RM inconsistent state?
      Show
      yufeigu Yufei Gu added a comment - Some major thoughts: I prefer to put functionality of ResourceWeights sort(e.g., getResourcesSortedByWeight ) in class DominantResourceFairnessComparator , that case we could exam the performance of compare() more easily. That is due to when I was thinking about which data structure is better for ResourceWeights#resources , ArrayList or TreeSet. They seems no difference in compare() . Another performance improvement would be calculating fair share only if necessary, which is similar to what YARN-6307 does. I guess we can do similar refactor in this jira. I'm not sure we handle minShare usage well, e.g. what if multiple resource usages are under their minShare, but we probably think more about it and somehow solve it in followup JIRAs. Minor ones: Why remove the FileNotFoundException fe in LOG.info() in Class ResourceUtils ? {float weight = 0.0f;} in ResourceWeights initialization is not necessary. We can't use ResourceType here, for (int i = 0; i < ResourceType.values().length; i++) in ResourceWeights#toString . Moreover, the enum ResourceType and related code should be removed. Several unused imports I like the refactor of ResourceNotFoundException . Do we need this method ResourceNotFoundException(String resource, Throwable cause) since it is never used? Method getResourceInformation() throw an unchecked exception, which isn't necessary to go into the method signature. This applies to getResourceValue() and several other methods in this class. Some of them you didn't touch. Maybe you follow the convention, but why do we do that at the first place? Besides that, ResourcePBImpl#getResourceInformation doesn't throw ResourceNotFoundException in method signature, but ResourcePBImpl#setResourceValue does. I think we need to solve this inconsistency. I like new message in class ResourceNotFoundException , can we also provide possible reasons of RM inconsistent state?
      Hide
      templedf Daniel Templeton added a comment -

      Here's a new patch that's updated for YARN-6788. I pulled out the exception changes into YARN-6995 and the minor Resource API change into YARN-6994.

      Show
      templedf Daniel Templeton added a comment - Here's a new patch that's updated for YARN-6788 . I pulled out the exception changes into YARN-6995 and the minor Resource API change into YARN-6994 .
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 17s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 2m 56s Maven dependency ordering for branch
      +1 mvninstall 15m 58s YARN-3926 passed
      +1 compile 10m 22s YARN-3926 passed
      +1 checkstyle 1m 0s YARN-3926 passed
      +1 mvnsite 1m 18s YARN-3926 passed
      +1 findbugs 2m 24s YARN-3926 passed
      +1 javadoc 0m 54s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      -1 mvninstall 0m 24s hadoop-yarn-server-resourcemanager in the patch failed.
      -1 compile 1m 54s hadoop-yarn in the patch failed.
      -1 javac 1m 54s hadoop-yarn in the patch failed.
      -0 checkstyle 0m 51s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 222 unchanged - 11 fixed = 229 total (was 233)
      -1 mvnsite 0m 26s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 whitespace 0m 0s The patch has no whitespace issues.
      -1 findbugs 0m 17s hadoop-yarn-server-resourcemanager in the patch failed.
      -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch failed.
            Other Tests
      +1 unit 0m 28s hadoop-yarn-api in the patch passed.
      -1 unit 0m 24s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 21s The patch does not generate ASF License warnings.
      50m 34s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881537/YARN-6612.YARN-3926.004.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 7421abcddb51 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 1b586d7
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      compile https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
      javac https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16859/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/16859/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 2m 56s Maven dependency ordering for branch +1 mvninstall 15m 58s YARN-3926 passed +1 compile 10m 22s YARN-3926 passed +1 checkstyle 1m 0s YARN-3926 passed +1 mvnsite 1m 18s YARN-3926 passed +1 findbugs 2m 24s YARN-3926 passed +1 javadoc 0m 54s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch -1 mvninstall 0m 24s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 1m 54s hadoop-yarn in the patch failed. -1 javac 1m 54s hadoop-yarn in the patch failed. -0 checkstyle 0m 51s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 222 unchanged - 11 fixed = 229 total (was 233) -1 mvnsite 0m 26s hadoop-yarn-server-resourcemanager in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 17s hadoop-yarn-server-resourcemanager in the patch failed. -1 javadoc 0m 21s hadoop-yarn-server-resourcemanager in the patch failed.       Other Tests +1 unit 0m 28s hadoop-yarn-api in the patch passed. -1 unit 0m 24s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 50m 34s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881537/YARN-6612.YARN-3926.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7421abcddb51 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 1b586d7 Default Java 1.8.0_144 findbugs v3.1.0-RC1 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16859/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16859/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16859/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Corrected the compiler errors.

      Show
      templedf Daniel Templeton added a comment - Corrected the compiler errors.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 18s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 43s Maven dependency ordering for branch
      +1 mvninstall 16m 47s YARN-3926 passed
      +1 compile 10m 46s YARN-3926 passed
      +1 checkstyle 1m 4s YARN-3926 passed
      +1 mvnsite 1m 33s YARN-3926 passed
      +1 findbugs 2m 47s YARN-3926 passed
      +1 javadoc 1m 4s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 12s Maven dependency ordering for patch
      +1 mvninstall 1m 14s the patch passed
      +1 compile 6m 22s the patch passed
      +1 javac 6m 22s the patch passed
      -0 checkstyle 1m 3s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 222 unchanged - 11 fixed = 229 total (was 233)
      +1 mvnsite 1m 30s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 3m 5s the patch passed
      -1 javadoc 0m 33s hadoop-yarn-server-resourcemanager in the patch failed.
            Other Tests
      +1 unit 0m 42s hadoop-yarn-api in the patch passed.
      -1 unit 48m 39s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 40s The patch does not generate ASF License warnings.
      107m 29s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.policies.TestDominantResourceFairnessPolicy
        hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler
        hadoop.yarn.server.resourcemanager.TestRMRestart
        hadoop.yarn.server.resourcemanager.TestRMAdminService
        hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
      Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881565/YARN-6612.YARN-3926.005.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 394bf5e3777d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 1b586d7
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16866/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16866/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/16866/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16866/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/16866/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 43s Maven dependency ordering for branch +1 mvninstall 16m 47s YARN-3926 passed +1 compile 10m 46s YARN-3926 passed +1 checkstyle 1m 4s YARN-3926 passed +1 mvnsite 1m 33s YARN-3926 passed +1 findbugs 2m 47s YARN-3926 passed +1 javadoc 1m 4s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 14s the patch passed +1 compile 6m 22s the patch passed +1 javac 6m 22s the patch passed -0 checkstyle 1m 3s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 222 unchanged - 11 fixed = 229 total (was 233) +1 mvnsite 1m 30s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 5s the patch passed -1 javadoc 0m 33s hadoop-yarn-server-resourcemanager in the patch failed.       Other Tests +1 unit 0m 42s hadoop-yarn-api in the patch passed. -1 unit 48m 39s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 107m 29s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.policies.TestDominantResourceFairnessPolicy   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12881565/YARN-6612.YARN-3926.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 394bf5e3777d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 1b586d7 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/16866/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/16866/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/16866/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/16866/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/16866/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      yufeigu Yufei Gu added a comment -

      Thanks Daniel Templeton for the new patch. It makes more sense to me. Some comments:

      • Would it be easier to understand if changing calculateShares() to calculateShareUsages()? This applies to calculateMinShares() as well.
      • What if weight is 0? The current patch throw a RuntimeException in method calculateShares(). We also need unit tests for this.
      • It doesn't need weight while calculating min share.
            shares[i][1] = resourceInfo[i].getValue() /
                    (minShareInfo[i].getValue() * weights.getWeight(i));
        

        For min share calculation, I guess we want to do it this way:

        (usage/cluster)/(minShare/cluster)
        

        which can be simplified to

        usage/minShare
        

        In addition, we need to handle zero-minShare, which needs unit tests.

      • The parameter cluster in method compareShares() confuses me. According to the last analysis, both min share and fair share in DRF should consider cluster. The major difference between them are one uses weights, the other use minShares.
      • Right now, the code sort by fair share usage before comparison of min share. Would it make more sense if we sort it by dominant min share which is minShare/cluster?
                // Calculate the min shares, then sort by fair share, and compare them
                // by min share
                calculateMinShares(usage1, minShare1, shares1, s1.getWeights());
                calculateMinShares(usage2, minShare2, shares2, s2.getWeights());
                sortShares(shares1, shares2);
                res = compareShares(shares1, shares2, false);
        
      • Could you add comments that first is the fair share and second is the min share for float[][] share1?
      • Parameter resource should be index in Java Doc of ResourceWeights#getWeight(int)
      • In ResourceWeights#getWeight(int): sb.deleteCharAt(sb.length()); should be sb.deleteCharAt(sb.length() - 1);.
      • ResourceInformation#toString is verbose (including unit, type, value, etc), we don't want it in
        ResourceWeights#ToString. Just output name is enough.
      • typo: desceding in the method sortShares
      • some test failures are related.
      Show
      yufeigu Yufei Gu added a comment - Thanks Daniel Templeton for the new patch. It makes more sense to me. Some comments: Would it be easier to understand if changing calculateShares() to calculateShareUsages() ? This applies to calculateMinShares() as well. What if weight is 0? The current patch throw a RuntimeException in method calculateShares() . We also need unit tests for this. It doesn't need weight while calculating min share. shares[i][1] = resourceInfo[i].getValue() / (minShareInfo[i].getValue() * weights.getWeight(i)); For min share calculation, I guess we want to do it this way: (usage/cluster)/(minShare/cluster) which can be simplified to usage/minShare In addition, we need to handle zero-minShare, which needs unit tests. The parameter cluster in method compareShares() confuses me. According to the last analysis, both min share and fair share in DRF should consider cluster. The major difference between them are one uses weights, the other use minShares. Right now, the code sort by fair share usage before comparison of min share. Would it make more sense if we sort it by dominant min share which is minShare/cluster? // Calculate the min shares, then sort by fair share, and compare them // by min share calculateMinShares(usage1, minShare1, shares1, s1.getWeights()); calculateMinShares(usage2, minShare2, shares2, s2.getWeights()); sortShares(shares1, shares2); res = compareShares(shares1, shares2, false ); Could you add comments that first is the fair share and second is the min share for float[][] share1 ? Parameter resource should be index in Java Doc of ResourceWeights#getWeight(int) In ResourceWeights#getWeight(int) : sb.deleteCharAt(sb.length()); should be sb.deleteCharAt(sb.length() - 1); . ResourceInformation#toString is verbose (including unit, type, value, etc), we don't want it in ResourceWeights#ToString. Just output name is enough. typo: desceding in the method sortShares some test failures are related.
      Hide
      templedf Daniel Templeton added a comment -

      Thanks, Yufei Gu.

      Would it be easier to understand if changing calculateShares() to calculateShareUsages()?

      Not really? Maybe I'm missing your point.

      What if weight is 0?

      Interesting point! Not a new issue, though. I'll have a look to see why it's never bitten us so far and whether we should fix it here.

      It doesn't need weight while calculating min share.

      Also not a new issue. That's the way it was calculated before. Yeah, it looks wrong to me, too. Karthik Kambatla, any insights?

      Would it make more sense if we sort it by dominant min share which is minShare/cluster?

      Also not a new issue. I'm just trying to preserve the existing semantics.

      I'll address the other issues and the unit tests in a new patch shortly.

      Show
      templedf Daniel Templeton added a comment - Thanks, Yufei Gu . Would it be easier to understand if changing calculateShares() to calculateShareUsages() ? Not really? Maybe I'm missing your point. What if weight is 0? Interesting point! Not a new issue, though. I'll have a look to see why it's never bitten us so far and whether we should fix it here. It doesn't need weight while calculating min share. Also not a new issue. That's the way it was calculated before. Yeah, it looks wrong to me, too. Karthik Kambatla , any insights? Would it make more sense if we sort it by dominant min share which is minShare/cluster? Also not a new issue. I'm just trying to preserve the existing semantics. I'll address the other issues and the unit tests in a new patch shortly.
      Hide
      templedf Daniel Templeton added a comment -

      Turns out the unit test failures were from the bad index in the toString() method.

      Show
      templedf Daniel Templeton added a comment - Turns out the unit test failures were from the bad index in the toString() method.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 29s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 54s Maven dependency ordering for branch
      +1 mvninstall 18m 43s YARN-3926 passed
      +1 compile 14m 55s YARN-3926 passed
      +1 checkstyle 1m 15s YARN-3926 passed
      +1 mvnsite 1m 50s YARN-3926 passed
      +1 findbugs 2m 31s YARN-3926 passed
      +1 javadoc 0m 54s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 0s the patch passed
      +1 compile 6m 16s the patch passed
      +1 javac 6m 16s the patch passed
      -0 checkstyle 1m 2s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 212 unchanged - 11 fixed = 218 total (was 223)
      +1 mvnsite 1m 20s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 36s the patch passed
      -1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 347 unchanged - 0 fixed = 349 total (was 347)
            Other Tests
      +1 unit 0m 36s hadoop-yarn-api in the patch passed.
      -1 unit 51m 2s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 35s The patch does not generate ASF License warnings.
      115m 13s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler
        hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
      Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands
        org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883616/YARN-6612.YARN-3926.006.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 22792133b039 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 38d04b8
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17126/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17126/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17126/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17126/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17126/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 54s Maven dependency ordering for branch +1 mvninstall 18m 43s YARN-3926 passed +1 compile 14m 55s YARN-3926 passed +1 checkstyle 1m 15s YARN-3926 passed +1 mvnsite 1m 50s YARN-3926 passed +1 findbugs 2m 31s YARN-3926 passed +1 javadoc 0m 54s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 0s the patch passed +1 compile 6m 16s the patch passed +1 javac 6m 16s the patch passed -0 checkstyle 1m 2s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 212 unchanged - 11 fixed = 218 total (was 223) +1 mvnsite 1m 20s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 36s the patch passed -1 javadoc 0m 27s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 347 unchanged - 0 fixed = 349 total (was 347)       Other Tests +1 unit 0m 36s hadoop-yarn-api in the patch passed. -1 unit 51m 2s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 115m 13s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestRMStoreCommands   org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883616/YARN-6612.YARN-3926.006.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 22792133b039 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 38d04b8 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17126/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17126/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17126/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17126/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17126/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Fixed the last unit test failure.

      Show
      templedf Daniel Templeton added a comment - Fixed the last unit test failure.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 15s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 47s Maven dependency ordering for branch
      +1 mvninstall 12m 58s YARN-3926 passed
      +1 compile 9m 17s YARN-3926 passed
      +1 checkstyle 0m 51s YARN-3926 passed
      +1 mvnsite 1m 7s YARN-3926 passed
      +1 findbugs 2m 6s YARN-3926 passed
      +1 javadoc 0m 50s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 9s Maven dependency ordering for patch
      +1 mvninstall 0m 53s the patch passed
      +1 compile 5m 37s the patch passed
      +1 javac 5m 37s the patch passed
      -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 211 unchanged - 11 fixed = 217 total (was 222)
      +1 mvnsite 1m 7s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 25s the patch passed
      -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 347 unchanged - 0 fixed = 349 total (was 347)
            Other Tests
      +1 unit 0m 27s hadoop-yarn-api in the patch passed.
      -1 unit 44m 19s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 23s The patch does not generate ASF License warnings.
      92m 54s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
      Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883766/YARN-6612.YARN-3926.007.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 040700de8d6d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 38d04b8
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17129/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17129/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17129/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17129/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 47s Maven dependency ordering for branch +1 mvninstall 12m 58s YARN-3926 passed +1 compile 9m 17s YARN-3926 passed +1 checkstyle 0m 51s YARN-3926 passed +1 mvnsite 1m 7s YARN-3926 passed +1 findbugs 2m 6s YARN-3926 passed +1 javadoc 0m 50s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 53s the patch passed +1 compile 5m 37s the patch passed +1 javac 5m 37s the patch passed -0 checkstyle 0m 49s hadoop-yarn-project/hadoop-yarn: The patch generated 6 new + 211 unchanged - 11 fixed = 217 total (was 222) +1 mvnsite 1m 7s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 25s the patch passed -1 javadoc 0m 21s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 2 new + 347 unchanged - 0 fixed = 349 total (was 347)       Other Tests +1 unit 0m 27s hadoop-yarn-api in the patch passed. -1 unit 44m 19s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 92m 54s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883766/YARN-6612.YARN-3926.007.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 040700de8d6d 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 38d04b8 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17129/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/17129/artifact/patchprocess/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17129/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17129/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17129/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Fixed the javadoc and checkstyle issues. I hope.

      Show
      templedf Daniel Templeton added a comment - Fixed the javadoc and checkstyle issues. I hope.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 22s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 48s Maven dependency ordering for branch
      +1 mvninstall 15m 28s YARN-3926 passed
      +1 compile 10m 6s YARN-3926 passed
      +1 checkstyle 1m 6s YARN-3926 passed
      +1 mvnsite 1m 22s YARN-3926 passed
      +1 findbugs 2m 26s YARN-3926 passed
      +1 javadoc 0m 56s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 12s Maven dependency ordering for patch
      +1 mvninstall 1m 8s the patch passed
      +1 compile 6m 14s the patch passed
      +1 javac 6m 14s the patch passed
      +1 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 210 unchanged - 13 fixed = 210 total (was 223)
      +1 mvnsite 1m 18s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 51s the patch passed
      +1 javadoc 0m 54s the patch passed
            Other Tests
      +1 unit 0m 37s hadoop-yarn-api in the patch passed.
      -1 unit 44m 44s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 28s The patch does not generate ASF License warnings.
      100m 8s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883813/YARN-6612.YARN-3926.008.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 34142a94c51c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 38d04b8
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17139/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17139/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17139/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 48s Maven dependency ordering for branch +1 mvninstall 15m 28s YARN-3926 passed +1 compile 10m 6s YARN-3926 passed +1 checkstyle 1m 6s YARN-3926 passed +1 mvnsite 1m 22s YARN-3926 passed +1 findbugs 2m 26s YARN-3926 passed +1 javadoc 0m 56s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 12s Maven dependency ordering for patch +1 mvninstall 1m 8s the patch passed +1 compile 6m 14s the patch passed +1 javac 6m 14s the patch passed +1 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 210 unchanged - 13 fixed = 210 total (was 223) +1 mvnsite 1m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 51s the patch passed +1 javadoc 0m 54s the patch passed       Other Tests +1 unit 0m 37s hadoop-yarn-api in the patch passed. -1 unit 44m 44s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 100m 8s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12883813/YARN-6612.YARN-3926.008.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 34142a94c51c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 38d04b8 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/17139/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17139/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17139/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Looks like Jenkins is finally happy.

      Show
      templedf Daniel Templeton added a comment - Looks like Jenkins is finally happy.
      Hide
      yufeigu Yufei Gu added a comment - - edited

      Thanks for the patch, Daniel Templeton, it looks much better. Some thoughts about your reply.

      • Zero-weight queues are supported by FS. We may only be lucky due to nobody uses it in DRF scenario. People will tend to use DRF more in case of multiple resource types. In that sense, it is necessary to handle zero-weight case.
      • Let's talk offline about weight in min share calculation and sort by dominant min share which is minShare/cluste.
      • About naming, I think we have used the word 'share' for different concepts. 1. it has been used in concepts like "Fair Share", "Min Share", "Max Share", which are not necessary but usually absolute resource of a schedulable. 2. In DRF, 'share' refers to how big a fraction of a resource is comparing to the cluster resource. In calculateShares and calculateMinShares, we don't only calculate how big a fraction of a used resource is comparing to the cluster resource, but also calculate how much portion it has in Fair Share and Min Share. That's why I think names of calculateShares and calculateMinShares are not ideal. In addition, Java doc of those two functions should mention they calculate how much fair share/min share the schedulable use.
      Show
      yufeigu Yufei Gu added a comment - - edited Thanks for the patch, Daniel Templeton , it looks much better. Some thoughts about your reply. Zero-weight queues are supported by FS. We may only be lucky due to nobody uses it in DRF scenario. People will tend to use DRF more in case of multiple resource types. In that sense, it is necessary to handle zero-weight case. Let's talk offline about weight in min share calculation and sort by dominant min share which is minShare/cluste. About naming, I think we have used the word 'share' for different concepts. 1. it has been used in concepts like "Fair Share", "Min Share", "Max Share", which are not necessary but usually absolute resource of a schedulable. 2. In DRF, 'share' refers to how big a fraction of a resource is comparing to the cluster resource. In calculateShares and calculateMinShares , we don't only calculate how big a fraction of a used resource is comparing to the cluster resource, but also calculate how much portion it has in Fair Share and Min Share. That's why I think names of calculateShares and calculateMinShares are not ideal. In addition, Java doc of those two functions should mention they calculate how much fair share/min share the schedulable use.
      Hide
      templedf Daniel Templeton added a comment -

      Here's a first pass at address your comments. Let's see what Jenkins says.

      Show
      templedf Daniel Templeton added a comment - Here's a first pass at address your comments. Let's see what Jenkins says.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 0s Docker mode activated.
      -1 patch 0m 6s YARN-6612 does not apply to YARN-3926. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



      Subsystem Report/Notes
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885713/YARN-6612.YARN-3926.009.patch
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17311/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s YARN-6612 does not apply to YARN-3926 . Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885713/YARN-6612.YARN-3926.009.patch Console output https://builds.apache.org/job/PreCommit-YARN-Build/17311/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Oops. Patch was incomplete. Here's a complete patch.

      Show
      templedf Daniel Templeton added a comment - Oops. Patch was incomplete. Here's a complete patch.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 19s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 48s Maven dependency ordering for branch
      +1 mvninstall 15m 27s YARN-3926 passed
      +1 compile 9m 54s YARN-3926 passed
      +1 checkstyle 1m 0s YARN-3926 passed
      +1 mvnsite 1m 17s YARN-3926 passed
      +1 findbugs 2m 21s YARN-3926 passed
      +1 javadoc 0m 54s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 1s the patch passed
      +1 compile 5m 59s the patch passed
      +1 javac 5m 59s the patch passed
      -0 checkstyle 0m 58s hadoop-yarn-project/hadoop-yarn: The patch generated 9 new + 210 unchanged - 13 fixed = 219 total (was 223)
      +1 mvnsite 1m 17s the patch passed
      -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
      -1 findbugs 1m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
      +1 javadoc 0m 55s the patch passed
            Other Tests
      +1 unit 0m 35s hadoop-yarn-api in the patch passed.
      -1 unit 44m 20s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 27s The patch does not generate ASF License warnings.
      98m 43s



      Reason Tests
      FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Integral division result cast to double or float in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.policies.DominantResourceFairnessPolicy$DominantResourceFairnessComparator.calculateClusterAndFairRatios(Resource, Resource, float[][], ResourceWeights) At DominantResourceFairnessPolicy.java:double or float in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.policies.DominantResourceFairnessPolicy$DominantResourceFairnessComparator.calculateClusterAndFairRatios(Resource, Resource, float[][], ResourceWeights) At DominantResourceFairnessPolicy.java:[line 247]
        Integral division result cast to double or float in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.policies.DominantResourceFairnessPolicy$DominantResourceFairnessComparator.calculateMinShareRatios(Resource, Resource, float[][]) At DominantResourceFairnessPolicy.java:double or float in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.policies.DominantResourceFairnessPolicy$DominantResourceFairnessComparator.calculateMinShareRatios(Resource, Resource, float[][]) At DominantResourceFairnessPolicy.java:[line 285]
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.policies.TestDominantResourceFairnessPolicy
        hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
        hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885737/YARN-6612.YARN-3926.010.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 1a8cdf67f165 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / eaab136
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17314/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      whitespace https://builds.apache.org/job/PreCommit-YARN-Build/17314/artifact/patchprocess/whitespace-eol.txt
      findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17314/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17314/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17314/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 48s Maven dependency ordering for branch +1 mvninstall 15m 27s YARN-3926 passed +1 compile 9m 54s YARN-3926 passed +1 checkstyle 1m 0s YARN-3926 passed +1 mvnsite 1m 17s YARN-3926 passed +1 findbugs 2m 21s YARN-3926 passed +1 javadoc 0m 54s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 1s the patch passed +1 compile 5m 59s the patch passed +1 javac 5m 59s the patch passed -0 checkstyle 0m 58s hadoop-yarn-project/hadoop-yarn: The patch generated 9 new + 210 unchanged - 13 fixed = 219 total (was 223) +1 mvnsite 1m 17s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply -1 findbugs 1m 29s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 55s the patch passed       Other Tests +1 unit 0m 35s hadoop-yarn-api in the patch passed. -1 unit 44m 20s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 98m 43s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   Integral division result cast to double or float in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.policies.DominantResourceFairnessPolicy$DominantResourceFairnessComparator.calculateClusterAndFairRatios(Resource, Resource, float[][], ResourceWeights) At DominantResourceFairnessPolicy.java:double or float in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.policies.DominantResourceFairnessPolicy$DominantResourceFairnessComparator.calculateClusterAndFairRatios(Resource, Resource, float[][], ResourceWeights) At DominantResourceFairnessPolicy.java: [line 247]   Integral division result cast to double or float in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.policies.DominantResourceFairnessPolicy$DominantResourceFairnessComparator.calculateMinShareRatios(Resource, Resource, float[][]) At DominantResourceFairnessPolicy.java:double or float in org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.policies.DominantResourceFairnessPolicy$DominantResourceFairnessComparator.calculateMinShareRatios(Resource, Resource, float[][]) At DominantResourceFairnessPolicy.java: [line 285] Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.policies.TestDominantResourceFairnessPolicy   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12885737/YARN-6612.YARN-3926.010.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1a8cdf67f165 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / eaab136 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17314/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/17314/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/17314/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/17314/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17314/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17314/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Patch to address unit test failures, checkstyle issues, findbugs issues, and whitespace issue.

      Show
      templedf Daniel Templeton added a comment - Patch to address unit test failures, checkstyle issues, findbugs issues, and whitespace issue.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 19m 10s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 53s Maven dependency ordering for branch
      +1 mvninstall 13m 12s YARN-3926 passed
      +1 compile 9m 3s YARN-3926 passed
      +1 checkstyle 1m 3s YARN-3926 passed
      +1 mvnsite 1m 11s YARN-3926 passed
      +1 findbugs 2m 13s YARN-3926 passed
      +1 javadoc 0m 55s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 11s Maven dependency ordering for patch
      +1 mvninstall 0m 54s the patch passed
      +1 compile 5m 38s the patch passed
      +1 javac 5m 38s the patch passed
      +1 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 209 unchanged - 13 fixed = 209 total (was 222)
      +1 mvnsite 1m 18s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 27s the patch passed
      +1 javadoc 0m 54s the patch passed
            Other Tests
      +1 unit 0m 36s hadoop-yarn-api in the patch passed.
      -1 unit 46m 3s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 29s The patch does not generate ASF License warnings.
      115m 42s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
        hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation
      Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886102/YARN-6612.YARN-3926.011.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 6a8c824710c6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 9698083
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17364/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17364/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17364/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 19m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 53s Maven dependency ordering for branch +1 mvninstall 13m 12s YARN-3926 passed +1 compile 9m 3s YARN-3926 passed +1 checkstyle 1m 3s YARN-3926 passed +1 mvnsite 1m 11s YARN-3926 passed +1 findbugs 2m 13s YARN-3926 passed +1 javadoc 0m 55s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 54s the patch passed +1 compile 5m 38s the patch passed +1 javac 5m 38s the patch passed +1 checkstyle 0m 56s hadoop-yarn-project/hadoop-yarn: The patch generated 0 new + 209 unchanged - 13 fixed = 209 total (was 222) +1 mvnsite 1m 18s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 0m 54s the patch passed       Other Tests +1 unit 0m 36s hadoop-yarn-api in the patch passed. -1 unit 46m 3s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 115m 42s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886102/YARN-6612.YARN-3926.011.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6a8c824710c6 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 9698083 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-YARN-Build/17364/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17364/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17364/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Unit test failures are YARN-6747 and YARN-7044.

      Show
      templedf Daniel Templeton added a comment - Unit test failures are YARN-6747 and YARN-7044 .
      Hide
      yufeigu Yufei Gu added a comment -

      Looks good to me generally. Some nits:

      1. Nobody use public ResourceWeights(float memoryWeight, float cpuWeight), we could either remove it or remove the whole class as we discussed before. I am OK if we put this into followup JIRAs.
      2. The following Java doc should be "1 for fair shares, 2 is for min shares".
             * @param index the outer index of the shares arrays to compare. 0 is for
             * fair shares, and 1 is for min shares
        
      Show
      yufeigu Yufei Gu added a comment - Looks good to me generally. Some nits: Nobody use public ResourceWeights(float memoryWeight, float cpuWeight) , we could either remove it or remove the whole class as we discussed before. I am OK if we put this into followup JIRAs. The following Java doc should be "1 for fair shares, 2 is for min shares". * @param index the outer index of the shares arrays to compare. 0 is for * fair shares, and 1 is for min shares
      Hide
      templedf Daniel Templeton added a comment -

      Fixed the javadoc (Good catch!) and removed ResourceWeights. Let's see how many unit tests I broke.

      Show
      templedf Daniel Templeton added a comment - Fixed the javadoc (Good catch!) and removed ResourceWeights . Let's see how many unit tests I broke.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 21s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 31s Maven dependency ordering for branch
      +1 mvninstall 14m 12s YARN-3926 passed
      +1 compile 10m 24s YARN-3926 passed
      +1 checkstyle 1m 4s YARN-3926 passed
      +1 mvnsite 1m 22s YARN-3926 passed
      +1 findbugs 2m 37s YARN-3926 passed
      +1 javadoc 0m 54s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 11s Maven dependency ordering for patch
      +1 mvninstall 1m 8s the patch passed
      +1 compile 6m 14s the patch passed
      +1 javac 6m 14s the patch passed
      -0 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 298 unchanged - 19 fixed = 302 total (was 317)
      +1 mvnsite 1m 19s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 47s the patch passed
      +1 javadoc 0m 50s the patch passed
            Other Tests
      +1 unit 0m 41s hadoop-yarn-api in the patch passed.
      -1 unit 46m 12s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 31s The patch does not generate ASF License warnings.
      100m 38s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
        hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886212/YARN-6612.YARN-3926.012.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 13f61f4b2c28 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 9698083
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17383/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17383/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17383/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17383/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 31s Maven dependency ordering for branch +1 mvninstall 14m 12s YARN-3926 passed +1 compile 10m 24s YARN-3926 passed +1 checkstyle 1m 4s YARN-3926 passed +1 mvnsite 1m 22s YARN-3926 passed +1 findbugs 2m 37s YARN-3926 passed +1 javadoc 0m 54s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 1m 8s the patch passed +1 compile 6m 14s the patch passed +1 javac 6m 14s the patch passed -0 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 4 new + 298 unchanged - 19 fixed = 302 total (was 317) +1 mvnsite 1m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 47s the patch passed +1 javadoc 0m 50s the patch passed       Other Tests +1 unit 0m 41s hadoop-yarn-api in the patch passed. -1 unit 46m 12s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 100m 38s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886212/YARN-6612.YARN-3926.012.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 13f61f4b2c28 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 9698083 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17383/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17383/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17383/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17383/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Resolved unit test failure and relevant checkstyle issues.

      Show
      templedf Daniel Templeton added a comment - Resolved unit test failure and relevant checkstyle issues.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 20s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 11s Maven dependency ordering for branch
      +1 mvninstall 15m 27s YARN-3926 passed
      +1 compile 9m 57s YARN-3926 passed
      +1 checkstyle 1m 4s YARN-3926 passed
      +1 mvnsite 1m 23s YARN-3926 passed
      +1 findbugs 2m 33s YARN-3926 passed
      +1 javadoc 0m 57s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 10s the patch passed
      +1 compile 6m 36s the patch passed
      +1 javac 6m 36s the patch passed
      -0 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317)
      +1 mvnsite 1m 17s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 58s the patch passed
      +1 javadoc 0m 56s the patch passed
            Other Tests
      +1 unit 0m 38s hadoop-yarn-api in the patch passed.
      -1 unit 44m 13s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 27s The patch does not generate ASF License warnings.
      99m 28s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing
        hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
      Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886223/YARN-6612.YARN-3926.013.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 9911d04ea6d6 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 9698083
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17385/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17385/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17385/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17385/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 15m 27s YARN-3926 passed +1 compile 9m 57s YARN-3926 passed +1 checkstyle 1m 4s YARN-3926 passed +1 mvnsite 1m 23s YARN-3926 passed +1 findbugs 2m 33s YARN-3926 passed +1 javadoc 0m 57s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 10s the patch passed +1 compile 6m 36s the patch passed +1 javac 6m 36s the patch passed -0 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317) +1 mvnsite 1m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 58s the patch passed +1 javadoc 0m 56s the patch passed       Other Tests +1 unit 0m 38s hadoop-yarn-api in the patch passed. -1 unit 44m 13s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 99m 28s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerResizing   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886223/YARN-6612.YARN-3926.013.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9911d04ea6d6 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 9698083 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17385/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17385/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17385/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17385/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      One more patch to rename getWeights() to getWeight().

      Show
      templedf Daniel Templeton added a comment - One more patch to rename getWeights() to getWeight() .
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 19s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 9s Maven dependency ordering for branch
      +1 mvninstall 13m 38s YARN-3926 passed
      +1 compile 9m 30s YARN-3926 passed
      +1 checkstyle 1m 3s YARN-3926 passed
      +1 mvnsite 1m 25s YARN-3926 passed
      +1 findbugs 2m 35s YARN-3926 passed
      +1 javadoc 0m 59s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 13s Maven dependency ordering for patch
      +1 mvninstall 1m 15s the patch passed
      +1 compile 6m 23s the patch passed
      +1 javac 6m 23s the patch passed
      -0 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317)
      +1 mvnsite 1m 24s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 52s the patch passed
      +1 javadoc 0m 58s the patch passed
            Other Tests
      +1 unit 0m 35s hadoop-yarn-api in the patch passed.
      -1 unit 45m 0s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 27s The patch does not generate ASF License warnings.
      97m 47s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
        hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
        hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore
        hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886261/YARN-6612.YARN-3926.014.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 1675cc2c1218 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 9698083
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17388/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17388/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17388/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17388/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 13m 38s YARN-3926 passed +1 compile 9m 30s YARN-3926 passed +1 checkstyle 1m 3s YARN-3926 passed +1 mvnsite 1m 25s YARN-3926 passed +1 findbugs 2m 35s YARN-3926 passed +1 javadoc 0m 59s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 1m 15s the patch passed +1 compile 6m 23s the patch passed +1 javac 6m 23s the patch passed -0 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317) +1 mvnsite 1m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 52s the patch passed +1 javadoc 0m 58s the patch passed       Other Tests +1 unit 0m 35s hadoop-yarn-api in the patch passed. -1 unit 45m 0s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 97m 47s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation   hadoop.yarn.server.resourcemanager.recovery.TestZKRMStateStore   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886261/YARN-6612.YARN-3926.014.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1675cc2c1218 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 9698083 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17388/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17388/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17388/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17388/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 16m 53s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 54s Maven dependency ordering for branch
      +1 mvninstall 18m 9s YARN-3926 passed
      +1 compile 9m 8s YARN-3926 passed
      +1 checkstyle 1m 2s YARN-3926 passed
      +1 mvnsite 1m 16s YARN-3926 passed
      +1 findbugs 2m 16s YARN-3926 passed
      +1 javadoc 0m 54s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 1s the patch passed
      +1 compile 5m 40s the patch passed
      +1 javac 5m 40s the patch passed
      -0 checkstyle 0m 59s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317)
      +1 mvnsite 1m 14s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 29s the patch passed
      +1 javadoc 0m 52s the patch passed
            Other Tests
      +1 unit 0m 34s hadoop-yarn-api in the patch passed.
      -1 unit 43m 35s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 28s The patch does not generate ASF License warnings.
      115m 43s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886266/YARN-6612.YARN-3926.014.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 146ff266f7b9 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 9698083
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17389/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17389/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17389/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17389/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 16m 53s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 54s Maven dependency ordering for branch +1 mvninstall 18m 9s YARN-3926 passed +1 compile 9m 8s YARN-3926 passed +1 checkstyle 1m 2s YARN-3926 passed +1 mvnsite 1m 16s YARN-3926 passed +1 findbugs 2m 16s YARN-3926 passed +1 javadoc 0m 54s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 1s the patch passed +1 compile 5m 40s the patch passed +1 javac 5m 40s the patch passed -0 checkstyle 0m 59s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317) +1 mvnsite 1m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 29s the patch passed +1 javadoc 0m 52s the patch passed       Other Tests +1 unit 0m 34s hadoop-yarn-api in the patch passed. -1 unit 43m 35s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 115m 43s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886266/YARN-6612.YARN-3926.014.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 146ff266f7b9 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 9698083 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17389/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17389/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17389/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17389/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 19s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
            YARN-3926 Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for branch
      +1 mvninstall 13m 53s YARN-3926 passed
      +1 compile 8m 59s YARN-3926 passed
      +1 checkstyle 1m 1s YARN-3926 passed
      +1 mvnsite 1m 16s YARN-3926 passed
      +1 findbugs 2m 17s YARN-3926 passed
      +1 javadoc 0m 53s YARN-3926 passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 1s the patch passed
      +1 compile 5m 38s the patch passed
      +1 javac 5m 38s the patch passed
      -0 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317)
      +1 mvnsite 1m 15s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 32s the patch passed
      +1 javadoc 0m 52s the patch passed
            Other Tests
      +1 unit 0m 35s hadoop-yarn-api in the patch passed.
      -1 unit 43m 41s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 28s The patch does not generate ASF License warnings.
      94m 7s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation
        hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886273/YARN-6612.YARN-3926.014.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 321638bbb3c9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision YARN-3926 / 9698083
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17390/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17390/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17390/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.       YARN-3926 Compile Tests 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 13m 53s YARN-3926 passed +1 compile 8m 59s YARN-3926 passed +1 checkstyle 1m 1s YARN-3926 passed +1 mvnsite 1m 16s YARN-3926 passed +1 findbugs 2m 17s YARN-3926 passed +1 javadoc 0m 53s YARN-3926 passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 1s the patch passed +1 compile 5m 38s the patch passed +1 javac 5m 38s the patch passed -0 checkstyle 1m 0s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317) +1 mvnsite 1m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 32s the patch passed +1 javadoc 0m 52s the patch passed       Other Tests +1 unit 0m 35s hadoop-yarn-api in the patch passed. -1 unit 43m 41s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 94m 7s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation   hadoop.yarn.server.resourcemanager.scheduler.fair.TestFSAppStarvation Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886273/YARN-6612.YARN-3926.014.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 321638bbb3c9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-3926 / 9698083 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17390/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17390/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17390/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17390/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      templedf Daniel Templeton added a comment -

      Rebased after the merge.

      Show
      templedf Daniel Templeton added a comment - Rebased after the merge.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 24s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
            trunk Compile Tests
      0 mvndep 0m 40s Maven dependency ordering for branch
      +1 mvninstall 13m 23s trunk passed
      +1 compile 9m 4s trunk passed
      +1 checkstyle 1m 0s trunk passed
      +1 mvnsite 1m 18s trunk passed
      +1 findbugs 2m 12s trunk passed
      +1 javadoc 0m 57s trunk passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 0m 57s the patch passed
      +1 compile 5m 47s the patch passed
      +1 javac 5m 47s the patch passed
      -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 297 unchanged - 22 fixed = 298 total (was 319)
      +1 mvnsite 1m 3s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 13s the patch passed
      +1 javadoc 0m 40s the patch passed
            Other Tests
      +1 unit 0m 27s hadoop-yarn-api in the patch passed.
      -1 unit 43m 49s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 22s The patch does not generate ASF License warnings.
      93m 29s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler
        hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:71bbb86
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886689/YARN-6612.015.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 56710f57b1a0 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 80ee89b
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17419/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17419/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17419/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17419/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.       trunk Compile Tests 0 mvndep 0m 40s Maven dependency ordering for branch +1 mvninstall 13m 23s trunk passed +1 compile 9m 4s trunk passed +1 checkstyle 1m 0s trunk passed +1 mvnsite 1m 18s trunk passed +1 findbugs 2m 12s trunk passed +1 javadoc 0m 57s trunk passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 57s the patch passed +1 compile 5m 47s the patch passed +1 javac 5m 47s the patch passed -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 297 unchanged - 22 fixed = 298 total (was 319) +1 mvnsite 1m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 0m 40s the patch passed       Other Tests +1 unit 0m 27s hadoop-yarn-api in the patch passed. -1 unit 43m 49s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 93m 29s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886689/YARN-6612.015.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 56710f57b1a0 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 80ee89b Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17419/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17419/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17419/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17419/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      yufeigu Yufei Gu added a comment -

      Thanks for removing the class ResourceWeight. Looks good to me generally. Some nits:

      • We probably want to remove FSAppAttempt#getResourceWeights, FSAppAttempt#weight since not only they are not used, but also they could be confused with FSAppAttempt#getWeight();
      • Is it a good practice to create a constant for weight 1.0f?
      Show
      yufeigu Yufei Gu added a comment - Thanks for removing the class ResourceWeight. Looks good to me generally. Some nits: We probably want to remove FSAppAttempt#getResourceWeights, FSAppAttempt#weight since not only they are not used, but also they could be confused with FSAppAttempt#getWeight(); Is it a good practice to create a constant for weight 1.0f?
      Hide
      templedf Daniel Templeton added a comment -

      Removed the used method and variable. I don't think we need a constant for 1.0f. NEUTRAL was useful because it was a shortcut for creating an object, and the object it was creating wasn't self-evidently equivalent to unweighted and hence needed a descriptive name. With weight as a float, 1.0f is self-evidently unweighted. I did add comments to getWeight() to help make it clear.

      Show
      templedf Daniel Templeton added a comment - Removed the used method and variable. I don't think we need a constant for 1.0f. NEUTRAL was useful because it was a shortcut for creating an object, and the object it was creating wasn't self-evidently equivalent to unweighted and hence needed a descriptive name. With weight as a float, 1.0f is self-evidently unweighted. I did add comments to getWeight() to help make it clear.
      Hide
      yufeigu Yufei Gu added a comment -

      The getWeight() Java doc looks good. +1. Pending for Jenkins.

      Show
      yufeigu Yufei Gu added a comment - The getWeight() Java doc looks good. +1. Pending for Jenkins.
      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 17s Docker mode activated.
            Prechecks
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
            trunk Compile Tests
      0 mvndep 0m 50s Maven dependency ordering for branch
      +1 mvninstall 15m 56s trunk passed
      +1 compile 10m 5s trunk passed
      +1 checkstyle 1m 1s trunk passed
      +1 mvnsite 1m 20s trunk passed
      +1 findbugs 2m 25s trunk passed
      +1 javadoc 1m 0s trunk passed
            Patch Compile Tests
      0 mvndep 0m 10s Maven dependency ordering for patch
      +1 mvninstall 1m 5s the patch passed
      +1 compile 5m 55s the patch passed
      +1 javac 5m 55s the patch passed
      -0 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317)
      +1 mvnsite 1m 21s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 45s the patch passed
      +1 javadoc 0m 26s hadoop-yarn-api in the patch passed.
      +1 javadoc 0m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 297 unchanged - 1 fixed = 297 total (was 298)
            Other Tests
      +1 unit 0m 36s hadoop-yarn-api in the patch passed.
      -1 unit 45m 47s hadoop-yarn-server-resourcemanager in the patch failed.
      +1 asflicense 0m 29s The patch does not generate ASF License warnings.
      102m 5s



      Reason Tests
      Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer
        hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:71bbb86
      JIRA Issue YARN-6612
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887111/YARN-6612.016.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 1550b014239e 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / b9465bb
      Default Java 1.8.0_144
      findbugs v3.1.0-RC1
      checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17455/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
      unit https://builds.apache.org/job/PreCommit-YARN-Build/17455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17455/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/17455/console
      Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.       trunk Compile Tests 0 mvndep 0m 50s Maven dependency ordering for branch +1 mvninstall 15m 56s trunk passed +1 compile 10m 5s trunk passed +1 checkstyle 1m 1s trunk passed +1 mvnsite 1m 20s trunk passed +1 findbugs 2m 25s trunk passed +1 javadoc 1m 0s trunk passed       Patch Compile Tests 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 1m 5s the patch passed +1 compile 5m 55s the patch passed +1 javac 5m 55s the patch passed -0 checkstyle 1m 4s hadoop-yarn-project/hadoop-yarn: The patch generated 1 new + 295 unchanged - 22 fixed = 296 total (was 317) +1 mvnsite 1m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 45s the patch passed +1 javadoc 0m 26s hadoop-yarn-api in the patch passed. +1 javadoc 0m 29s hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager generated 0 new + 297 unchanged - 1 fixed = 297 total (was 298)       Other Tests +1 unit 0m 36s hadoop-yarn-api in the patch passed. -1 unit 45m 47s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 102m 5s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAllocationExpirer   hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue YARN-6612 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887111/YARN-6612.016.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1550b014239e 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b9465bb Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/17455/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/17455/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/17455/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/17455/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
      Hide
      yufeigu Yufei Gu added a comment -

      Committed to trunk. Thanks for working on this, Daniel Templeton.

      Show
      yufeigu Yufei Gu added a comment - Committed to trunk. Thanks for working on this, Daniel Templeton .
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12874 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12874/)
      YARN-6612. Update fair scheduler policies to be aware of resource types. (yufei: rev 09b476e6dabe8039a41dde7930c8a9c0d14bb750)

      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FakeSchedulable.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/DominantResourceFairnessPolicy.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/Schedulable.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSLeafQueue.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java
      • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/resource/TestResourceWeights.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueue.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/TestDominantResourceFairnessPolicy.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairSchedulerPlanFollower.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestComputeFairShares.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationConfiguration.java
      • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceWeights.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/FairSharePolicy.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestSchedulingPolicy.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/ComputeFairShares.java
      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12874 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12874/ ) YARN-6612 . Update fair scheduler policies to be aware of resource types. (yufei: rev 09b476e6dabe8039a41dde7930c8a9c0d14bb750) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FakeSchedulable.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FairScheduler.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/DominantResourceFairnessPolicy.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/Schedulable.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSLeafQueue.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestFairScheduler.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/resource/TestResourceWeights.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSQueue.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/TestDominantResourceFairnessPolicy.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestFairSchedulerPlanFollower.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/FSAppAttempt.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestComputeFairShares.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationConfiguration.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/resource/ResourceWeights.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/FairSharePolicy.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/TestSchedulingPolicy.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/ComputeFairShares.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/util/resource/ResourceUtils.java
      Hide
      yufeigu Yufei Gu added a comment -

      Daniel Templeton, do you need this on branch-3.0?

      Show
      yufeigu Yufei Gu added a comment - Daniel Templeton , do you need this on branch-3.0?
      Hide
      templedf Daniel Templeton added a comment -

      Thanks, Yufei Gu. Let's keep it on 3.1 for now.

      Show
      templedf Daniel Templeton added a comment - Thanks, Yufei Gu . Let's keep it on 3.1 for now.

        People

        • Assignee:
          templedf Daniel Templeton
          Reporter:
          templedf Daniel Templeton
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development