[YARN-6515] Fix warnings from Spotbugs in hadoop-yarn-server-nodemanager

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-beta1, 2.10.1
• Component/s: nodemanager
• Target Version/s: 3.0.0-beta1
• Hadoop Flags: Reviewed
• Assignee: Naganarasimha G R
• Reporter: Naganarasimha G R
• Created: 23/Apr/17 17:51
• Updated: 21/Jul/20 13:15
• Resolved: 09/Aug/17 12:57

Description

5 find bugs issue was reported NM project as part of the YARN-4166 build
Issue 1:
org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainerMetrics.usageMetrics is a mutable collection which should be package protected
Bug type MS_MUTABLE_COLLECTION_PKGPROTECT (click for details)
In class org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainerMetrics
Field org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainerMetrics.usageMetrics
At ContainerMetrics.java:[line 134]

Issue 2:
org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer.createStatus() makes inefficient use of keySet iterator instead of entrySet iterator
Bug type WMI_WRONG_MAP_ITERATOR (click for details)
In class org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer
In method org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer.createStatus()
Field org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer.pendingResources
At ContainerLocalizer.java:[line 334]

Issue 3:
org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeVeryOldStoppedContainersFromCache() makes inefficient use of keySet iterator instead of entrySet iterator
Bug type WMI_WRONG_MAP_ITERATOR (click for details)
In class org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl
In method org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeVeryOldStoppedContainersFromCache()
Field org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.recentlyStoppedContainers
At NodeStatusUpdaterImpl.java:[line 721]

Issue 4:
Hard coded reference to an absolute pathname in org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
Bug type DMI_HARDCODED_ABSOLUTE_FILENAME (click for details)
In class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime
In method org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
File name /sys/fs/cgroup
At DockerLinuxContainerRuntime.java:[line 455]

Useless object stored in variable removedNullContainers of method org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeOrTrackCompletedContainersFromContext(List)
Bug type UC_USELESS_OBJECT (click for details)
In class org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl
In method org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeOrTrackCompletedContainersFromContext(List)
Value removedNullContainers
Type java.util.HashSet
At NodeStatusUpdaterImpl.java:[line 644]

Issue Links

• duplicates: YARN-6922 Findbugs warning in YARN NodeManager
• is related to: YARN-7025 Make CGROUPS_ROOT_DIRECTORY configurable in DockerLinuxContainerRuntime
• is related to: YARN-6757 Refactor the usage of yarn.nodemanager.linux-container-executor.cgroups.mount-path
• relates to: HADOOP-14336 Cleanup findbugs warnings found by Spotbugs
• relates to: YARN-6968 Hardcoded absolute pathname in DockerLinuxContainerRuntime
• relates to: YARN-10358 Fix findbugs warnings in hadoop-yarn-project on branch-2.10