Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-662 [Umbrella] Enforce required parameters for all the protocols
  3. YARN-644

Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: nodemanager
    • Labels:
      None
    • Target Version/s:

      Description

      I see that validation/ null check is not performed on passed in parameters.

      Ex. tokenId.getContainerID().getApplicationAttemptId() inside ContainerManagerImpl.authorizeRequest()

      I guess we should add these checks.

      1. YARN-644.001.patch
        4 kB
        Varun Saxena
      2. YARN-644.002.patch
        5 kB
        Varun Saxena
      3. YARN-644.03.patch
        10 kB
        Varun Saxena
      4. YARN-644.04.patch
        10 kB
        Varun Saxena
      5. YARN-644.05.patch
        10 kB
        Varun Saxena

        Activity

        Hide
        josephkniest Joseph Kniest added a comment -

        What should be done in the event that any parameters for authorizeStartRequest() and authorizeGetAndStopContainerRequest() are null? Should an exception be thrown?

        Show
        josephkniest Joseph Kniest added a comment - What should be done in the event that any parameters for authorizeStartRequest() and authorizeGetAndStopContainerRequest() are null? Should an exception be thrown?
        Hide
        ojoshi Omkar Vinit Joshi added a comment -

        Joseph Kniest in these scenarios we should simply reject client requests. If the client has fabricated the container token or NMToken (YARN-613) then these scenarios (NPE) are quite possible. Ideally we should reject them as invalid tokens.

        Show
        ojoshi Omkar Vinit Joshi added a comment - Joseph Kniest in these scenarios we should simply reject client requests. If the client has fabricated the container token or NMToken ( YARN-613 ) then these scenarios (NPE) are quite possible. Ideally we should reject them as invalid tokens.
        Hide
        josephkniest Joseph Kniest added a comment -

        I'm new to mapreduce2/yarn dev and am unfamiliar yet with the source, would this simply be exiting the function with a return upon null object detection?

        Show
        josephkniest Joseph Kniest added a comment - I'm new to mapreduce2/yarn dev and am unfamiliar yet with the source, would this simply be exiting the function with a return upon null object detection?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12691664/YARN-644.001.patch
        against trunk revision 5b0d060.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager:

        org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainersMonitor
        org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch
        org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6308//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6308//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691664/YARN-644.001.patch against trunk revision 5b0d060. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.TestContainersMonitor org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6308//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6308//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12691691/YARN-644.002.patch
        against trunk revision 5b0d060.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6311//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6311//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691691/YARN-644.002.patch against trunk revision 5b0d060. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6311//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6311//console This message is automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Kindly review

        Show
        varun_saxena Varun Saxena added a comment - Kindly review
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12691691/YARN-644.002.patch
        against trunk revision af9d4fe.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

        Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7286//testReport/
        Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7286//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12691691/YARN-644.002.patch against trunk revision af9d4fe. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/7286//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7286//console This message is automatically generated.
        Hide
        gtCarrera9 Li Lu added a comment -

        Hi Varun Saxena, sorry I accidentally assigned this JIRA to myself. I've already assigned back. I looked at you patch and in general it LGTM. I noticed there are some formatting issues around:

        +      protected NMTokenIdentifier selectNMTokenIdentifier(
        +    	      UserGroupInformation remoteUgi) {
        

        since there's a mixing tab. To prove the current fix works and to prevent future mistakes, may be we'd like to add some test cases to verify on the null checks?

        Show
        gtCarrera9 Li Lu added a comment - Hi Varun Saxena , sorry I accidentally assigned this JIRA to myself. I've already assigned back. I looked at you patch and in general it LGTM. I noticed there are some formatting issues around: + protected NMTokenIdentifier selectNMTokenIdentifier( + UserGroupInformation remoteUgi) { since there's a mixing tab. To prove the current fix works and to prevent future mistakes, may be we'd like to add some test cases to verify on the null checks?
        Hide
        varun_saxena Varun Saxena added a comment -

        Fixed the tab issue and added tests.

        Show
        varun_saxena Varun Saxena added a comment - Fixed the tab issue and added tests.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
        +1 javac 7m 33s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 37s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 yarn tests 5m 59s Tests passed in hadoop-yarn-server-nodemanager.
            42m 6s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731255/YARN-644.03.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / ab5058d
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7775/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7775/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/7775/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 37s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 4s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 yarn tests 5m 59s Tests passed in hadoop-yarn-server-nodemanager.     42m 6s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731255/YARN-644.03.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ab5058d hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-YARN-Build/7775/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/7775/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/7775/console This message was automatically generated.
        Hide
        gtCarrera9 Li Lu added a comment -

        Hi Varun Saxena, thanks for the patch! Asserting on the content of the exception message may unnecessarily couple the exception handling message with the test, which makes future changes harder. Maybe we'd like to provide some central place for those exception message constants? Thanks!

        Show
        gtCarrera9 Li Lu added a comment - Hi Varun Saxena , thanks for the patch! Asserting on the content of the exception message may unnecessarily couple the exception handling message with the test, which makes future changes harder. Maybe we'd like to provide some central place for those exception message constants? Thanks!
        Hide
        varun_saxena Varun Saxena added a comment -

        OK...That's a good suggestion. Will make the change

        Show
        varun_saxena Varun Saxena added a comment - OK...That's a good suggestion. Will make the change
        Hide
        gtCarrera9 Li Lu added a comment -

        Hi Varun Saxena, thanks for working on this! The patch is mostly good, just one quick thing:

        +  public static final String INVALID_NMTOKEN_MSG = "Invalid NMToken";
        +  public static final String INVALID_CONTAINERTOKEN_MSG =
        +      "Invalid ContainerToken";
        

        Why do we need these two strings to be public? I think default would be good for the unit tests, or am I missing anything here? Thanks!

        Show
        gtCarrera9 Li Lu added a comment - Hi Varun Saxena , thanks for working on this! The patch is mostly good, just one quick thing: + public static final String INVALID_NMTOKEN_MSG = "Invalid NMToken" ; + public static final String INVALID_CONTAINERTOKEN_MSG = + "Invalid ContainerToken" ; Why do we need these two strings to be public? I think default would be good for the unit tests, or am I missing anything here? Thanks!
        Hide
        varun_saxena Varun Saxena added a comment -

        Sorry couldn't get you. These 2 strings indicate two different kind of invalid tokens. Any issues ?

        Show
        varun_saxena Varun Saxena added a comment - Sorry couldn't get you. These 2 strings indicate two different kind of invalid tokens. Any issues ?
        Hide
        gtCarrera9 Li Lu added a comment -

        Oh I mean the access modifiers. Can we use default level since all references to them are in the same package? (Or I'm missing something? )

        Show
        gtCarrera9 Li Lu added a comment - Oh I mean the access modifiers. Can we use default level since all references to them are in the same package? (Or I'm missing something? )
        Hide
        varun_saxena Varun Saxena added a comment -

        Ok...Thats correct. We should not be using these constants outside package.

        Show
        varun_saxena Varun Saxena added a comment - Ok...Thats correct. We should not be using these constants outside package.
        Hide
        gtCarrera9 Li Lu added a comment -

        Thanks Varun Saxena! The latest patch LGTM. I'd appreciate verifications from committers.

        Show
        gtCarrera9 Li Lu added a comment - Thanks Varun Saxena ! The latest patch LGTM. I'd appreciate verifications from committers.
        Hide
        revans2 Robert Joseph Evans added a comment -

        Thanks Varun Saxena, I agree with Li Lu +1. I'll check this in.

        Show
        revans2 Robert Joseph Evans added a comment - Thanks Varun Saxena , I agree with Li Lu +1. I'll check this in.
        Hide
        revans2 Robert Joseph Evans added a comment -

        Thanks again Varun Saxena, I merged this into trunk and branch-2 keep up the good work.

        Show
        revans2 Robert Joseph Evans added a comment - Thanks again Varun Saxena , I merged this into trunk and branch-2 keep up the good work.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7776 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7776/)
        YARN-644: Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7776 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7776/ ) YARN-644 : Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/)
        YARN-644: Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/ ) YARN-644 : Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/)
        YARN-644: Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/ ) YARN-644 : Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/)
        YARN-644: Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/ ) YARN-644 : Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/)
        YARN-644: Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/ ) YARN-644 : Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java hadoop-yarn-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/)
        YARN-644: Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/ ) YARN-644 : Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/)
        YARN-644: Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
        • hadoop-yarn-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/ ) YARN-644 : Basic null check is not performed on passed in arguments before using them in ContainerManagerImpl.startContainer (evans: rev bcf2890502fbd11dd394048fe30d67c92aeec4fa) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/TestContainerManager.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/BaseContainerManagerTest.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java hadoop-yarn-project/CHANGES.txt

          People

          • Assignee:
            varun_saxena Varun Saxena
            Reporter:
            ojoshi Omkar Vinit Joshi
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development