Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6370

Properly handle rack requests for non-active subclusters in LocalityMulticastAMRMProxyPolicy

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      When splitting resource request in LocalityMulticastAMRMProxyPolicy. For rack requests for non-active subclusters, we will assign them to home subcluster instead. However we should not add them to bookkeeper as node request since their ask number should not contribute to the count that determine how to distribute ANY requests.

        Activity

        Hide
        botong Botong Huang added a comment -

        Thanks Carlo Curino for the review!

        Show
        botong Botong Huang added a comment - Thanks Carlo Curino for the review!
        Hide
        curino Carlo Curino added a comment -

        Thanks Botong Huang for your contribution.

        Show
        curino Carlo Curino added a comment - Thanks Botong Huang for your contribution.
        Hide
        curino Carlo Curino added a comment -

        Patch looked good, committed to federation branch YARN-2915.

        Show
        curino Carlo Curino added a comment - Patch looked good, committed to federation branch YARN-2915 .
        Hide
        curino Carlo Curino added a comment -

        +1 The patch looks good to me. I will commit soon.

        Show
        curino Carlo Curino added a comment - +1 The patch looks good to me. I will commit soon.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 22s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 13m 32s YARN-2915 passed
        +1 compile 0m 24s YARN-2915 passed
        +1 checkstyle 0m 15s YARN-2915 passed
        +1 mvnsite 0m 25s YARN-2915 passed
        +1 mvneclipse 0m 14s YARN-2915 passed
        +1 findbugs 0m 48s YARN-2915 passed
        +1 javadoc 0m 18s YARN-2915 passed
        +1 mvninstall 0m 21s the patch passed
        +1 compile 0m 19s the patch passed
        +1 javac 0m 19s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 22s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 54s the patch passed
        +1 javadoc 0m 16s the patch passed
        +1 unit 1m 11s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        21m 36s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6370
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859776/YARN-6370-YARN-2915.v1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4c28118af2eb 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 3778d87
        Default Java 1.8.0_121
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15347/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15347/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 13m 32s YARN-2915 passed +1 compile 0m 24s YARN-2915 passed +1 checkstyle 0m 15s YARN-2915 passed +1 mvnsite 0m 25s YARN-2915 passed +1 mvneclipse 0m 14s YARN-2915 passed +1 findbugs 0m 48s YARN-2915 passed +1 javadoc 0m 18s YARN-2915 passed +1 mvninstall 0m 21s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 54s the patch passed +1 javadoc 0m 16s the patch passed +1 unit 1m 11s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 21m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6370 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12859776/YARN-6370-YARN-2915.v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4c28118af2eb 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 3778d87 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15347/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/15347/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            botong Botong Huang
            Reporter:
            botong Botong Huang
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development