[YARN-6334] TestRMFailover#testAutomaticFailover always passes even when it should fail

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha4
• Hadoop Flags: Reviewed
• Assignee: Yufei Gu
• Reporter: Yufei Gu
• Created: 14/Mar/17 18:30
• Updated: 24/Mar/17 21:03
• Resolved: 24/Mar/17 18:51

Description

Due to a bug in while loop.

    int maxWaitingAttempts = 2000;
    while (maxWaitingAttempts-- > 0 ) {
      if (rm.getRMContext().getHAServiceState() == HAServiceState.STANDBY) {
        break;
      }
      Thread.sleep(1);
    }
    Assert.assertFalse("RM didn't transition to Standby ",
        maxWaitingAttempts == 0);

maxWaitingAttempts is -1 if RM didn't transition to Standby.