Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6278

Enforce to use correct node and npm version in new YARN-UI build

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Link to the error is here

      qunit-notifications#0.1.1 bower_components/qunit-notifications
      [INFO] 
      [INFO] --- exec-maven-plugin:1.3.1:exec (ember build) @ hadoop-yarn-ui ---
      
      /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/target/src/main/webapp/node_modules/merge-trees/index.js:33
      class MergeTrees {
      ^^^^^
      Unexpected reserved word
      SyntaxError: Unexpected reserved word
          at Module._compile (module.js:439:25)
          at Object.Module._extensions..js (module.js:474:10)
          at Module.load (module.js:356:32)
          at Function.Module._load (module.js:312:12)
          at Module.require (module.js:364:17)
          at require (module.js:380:17)
          at Object.<anonymous> (/testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/target/src/main/webapp/node_modules/broccoli-merge-trees/index.js:2:18)
          at Module._compile (module.js:456:26)
          at Object.Module._extensions..js (module.js:474:10)
          at Module.load (module.js:356:32)
      

        Activity

        Hide
        sunilg Sunil G added a comment -

        It looks like the Node.js version is very old in the machine where this build has happened.

        | | |npm WARN npm npm does not support Node.js v0.10.25
        npm WARN npm You should probably upgrade to a newer version of node as we
        npm WARN npm can't make any promises that npm will work with this version.
        

        Investigating with same version. cc/Sreenath Somarajapuram Wangda Tan

        Show
        sunilg Sunil G added a comment - It looks like the Node.js version is very old in the machine where this build has happened. | | |npm WARN npm npm does not support Node.js v0.10.25 npm WARN npm You should probably upgrade to a newer version of node as we npm WARN npm can't make any promises that npm will work with this version. Investigating with same version. cc/ Sreenath Somarajapuram Wangda Tan
        Hide
        sunilg Sunil G added a comment -

        I used Node.js v0.10.25 in an ubuntu VM and I am getting same error.
        So this is due to an old version of node in that machine. I am not very sure why this is tripped now, it might be due to some recent dependency change in ember's core module.

        A possible fix is to enforce minimum version for node in all machines where UI has to be compiled. Thoughts? Sreenath Somarajapuram and Wangda Tan

        Show
        sunilg Sunil G added a comment - I used Node.js v0.10.25 in an ubuntu VM and I am getting same error. So this is due to an old version of node in that machine. I am not very sure why this is tripped now, it might be due to some recent dependency change in ember's core module. A possible fix is to enforce minimum version for node in all machines where UI has to be compiled. Thoughts? Sreenath Somarajapuram and Wangda Tan
        Hide
        sunilg Sunil G added a comment - - edited

        Attaching patch after forcing correct node and npm version in compile machine.

        Show
        sunilg Sunil G added a comment - - edited Attaching patch after forcing correct node and npm version in compile machine.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 12m 32s trunk passed
        -1 compile 5m 17s hadoop-yarn-ui in trunk failed.
        +1 mvnsite 0m 18s trunk passed
        +1 mvneclipse 0m 9s trunk passed
        +1 javadoc 0m 9s trunk passed
        +1 mvninstall 0m 7s the patch passed
        +1 compile 3m 11s the patch passed
        +1 javac 3m 11s the patch passed
        +1 mvnsite 0m 23s the patch passed
        +1 mvneclipse 0m 6s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 javadoc 0m 6s the patch passed
        +1 unit 3m 6s hadoop-yarn-ui in the patch passed.
        +1 asflicense 0m 36s The patch does not generate ASF License warnings.
        27m 3s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue YARN-6278
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855924/YARN-6278.0001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux ab965f57d1f4 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 490abfb
        Default Java 1.8.0_121
        compile https://builds.apache.org/job/PreCommit-YARN-Build/15155/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15155/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15155/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 12m 32s trunk passed -1 compile 5m 17s hadoop-yarn-ui in trunk failed. +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 9s trunk passed +1 javadoc 0m 9s trunk passed +1 mvninstall 0m 7s the patch passed +1 compile 3m 11s the patch passed +1 javac 3m 11s the patch passed +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 6s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 javadoc 0m 6s the patch passed +1 unit 3m 6s hadoop-yarn-ui in the patch passed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 27m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6278 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12855924/YARN-6278.0001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux ab965f57d1f4 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 490abfb Default Java 1.8.0_121 compile https://builds.apache.org/job/PreCommit-YARN-Build/15155/artifact/patchprocess/branch-compile-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ui.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15155/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui Console output https://builds.apache.org/job/PreCommit-YARN-Build/15155/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        The changes looks good to me.

        Show
        Sreenath Sreenath Somarajapuram added a comment - The changes looks good to me.
        Hide
        leftnoteasy Wangda Tan added a comment -

        +1 committing.

        Show
        leftnoteasy Wangda Tan added a comment - +1 committing.
        Hide
        leftnoteasy Wangda Tan added a comment -

        Committed to trunk, thanks Sunil G and thanks review from Sreenath Somarajapuram!

        Show
        leftnoteasy Wangda Tan added a comment - Committed to trunk, thanks Sunil G and thanks review from Sreenath Somarajapuram !
        Hide
        sunilg Sunil G added a comment -

        Thanks Wangda Tan for review and commit. Thanks Sreenath Somarajapuram for additional review.

        Show
        sunilg Sunil G added a comment - Thanks Wangda Tan for review and commit. Thanks Sreenath Somarajapuram for additional review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11348 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11348/)
        YARN-6278. Enforce to use correct node and npm version in new YARN-UI (wangda: rev c61bc2d843ace614078be24b2dcbf3fb43d6f358)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/bower.json
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/package.json
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11348 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11348/ ) YARN-6278 . Enforce to use correct node and npm version in new YARN-UI (wangda: rev c61bc2d843ace614078be24b2dcbf3fb43d6f358) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/bower.json (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/package.json (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/pom.xml

          People

          • Assignee:
            sunilg Sunil G
            Reporter:
            sunilg Sunil G
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development