[YARN-6170] TimelineReaderServer should wait to join with HttpServer2

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha2, YARN-5355
• Fix Version/s: 2.9.0, YARN-5355-branch-2, 3.0.0-alpha4
• Component/s: timelinereader
• Hadoop Flags: Reviewed
• Assignee: Sangjin Lee
• Reporter: Sangjin Lee
• Created: 10/Feb/17 06:40
• Updated: 21/Oct/17 06:06
• Resolved: 11/Feb/17 14:38

Description

While I was backporting YARN-5355-branch-2 to a 2.6.0-based code branch, I noticed that the timeline reader daemon would promptly shut down upon start. It turns out that in the 2.6.0 code line at least there are only daemon threads left once the main method returns. That causes the JVM to shut down.

The right pattern to start an embedded jetty web server is to call Server.start() followed by Server.join(). That way, the server stays up reliably no matter what other threads get created.

It works on YARN-5355 only because there happens to be one other non-daemon thread. We should add the join() call to be always correct.

Issue Links

• is related to: HADOOP-11749 HttpServer2 thread pool is set to daemon