Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-6071

Fix incompatible API change on AM-RM protocol due to YARN-3866 (trunk only)

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change, Reviewed

      Description

      In YARN-3866, we have addendum patch to fix incompatible API change on branch-2 and branch-2.8. For trunk, we need a similar fix.

        Issue Links

          Activity

          Hide
          templedf Daniel Templeton added a comment -

          Wangda Tan, what's the story on this one? Are you planning to post a patch soon?

          Show
          templedf Daniel Templeton added a comment - Wangda Tan , what's the story on this one? Are you planning to post a patch soon?
          Hide
          leftnoteasy Wangda Tan added a comment -

          Daniel Templeton, yeah I was keep forgetting upload patch for this one.

          This will be a simple change to pb file, will upload a patch today, no later than tomorrow.

          Show
          leftnoteasy Wangda Tan added a comment - Daniel Templeton , yeah I was keep forgetting upload patch for this one. This will be a simple change to pb file, will upload a patch today, no later than tomorrow.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Attached ver.1 patch for review.

          Show
          leftnoteasy Wangda Tan added a comment - Attached ver.1 patch for review.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 47s Maven dependency ordering for branch
          +1 mvninstall 12m 34s trunk passed
          +1 compile 5m 14s trunk passed
          +1 checkstyle 0m 44s trunk passed
          +1 mvnsite 1m 26s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 2m 31s trunk passed
          +1 javadoc 0m 50s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 55s the patch passed
          +1 compile 4m 37s the patch passed
          +1 cc 4m 37s the patch passed
          +1 javac 4m 37s the patch passed
          +1 checkstyle 0m 43s the patch passed
          +1 mvnsite 1m 20s the patch passed
          +1 mvneclipse 0m 38s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 15s the patch passed
          +1 javadoc 0m 57s the patch passed
          +1 unit 0m 31s hadoop-yarn-api in the patch passed.
          +1 unit 40m 4s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 29s The patch does not generate ASF License warnings.
          86m 46s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-6071
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847132/YARN-6071.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc
          uname Linux d7b45e5a9601 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / a6b06f7
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14644/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14644/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 47s Maven dependency ordering for branch +1 mvninstall 12m 34s trunk passed +1 compile 5m 14s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 26s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 2m 31s trunk passed +1 javadoc 0m 50s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 55s the patch passed +1 compile 4m 37s the patch passed +1 cc 4m 37s the patch passed +1 javac 4m 37s the patch passed +1 checkstyle 0m 43s the patch passed +1 mvnsite 1m 20s the patch passed +1 mvneclipse 0m 38s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 15s the patch passed +1 javadoc 0m 57s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 40m 4s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 29s The patch does not generate ASF License warnings. 86m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-6071 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12847132/YARN-6071.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux d7b45e5a9601 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a6b06f7 Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14644/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14644/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Thank for the patch, Wangda Tan! Looks good to me, and appears to line up with branch-2. +1 I'll commit shortly.

          Show
          templedf Daniel Templeton added a comment - Thank for the patch, Wangda Tan ! Looks good to me, and appears to line up with branch-2. +1 I'll commit shortly.
          Hide
          templedf Daniel Templeton added a comment -

          Thanks for the quick patch, Wangda Tan! Committed to trunk.

          Show
          templedf Daniel Templeton added a comment - Thanks for the quick patch, Wangda Tan ! Committed to trunk.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11129 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11129/)
          YARN-6071. Fix incompatible API change on AM-RM protocol due to (templedf: rev 695f110f937b35e92d635b9e93740d3b5af179a6)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockAM.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateRequest.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11129 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11129/ ) YARN-6071 . Fix incompatible API change on AM-RM protocol due to (templedf: rev 695f110f937b35e92d635b9e93740d3b5af179a6) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/proto/yarn_service_protos.proto (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/MockAM.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/api/protocolrecords/AllocateRequest.java
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks for review and commit! Daniel Templeton

          Show
          leftnoteasy Wangda Tan added a comment - Thanks for review and commit! Daniel Templeton

            People

            • Assignee:
              leftnoteasy Wangda Tan
              Reporter:
              djp Junping Du
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development