[YARN-5999] AMRMClientAsync will stop if any exceptions thrown on allocate call

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.9.0, 3.0.0-alpha2
• Assignee: Jian He
• Reporter: Jian He
• Created: 14/Dec/16 00:16
• Updated: 04/Jan/17 19:46
• Resolved: 14/Dec/16 23:08

Description

Currently, for any exceptions thrown on the allocate call of AMRMClientAsync, it will stop both heartbeat thread and the callback handler thread, leaving AMRMClient in an unusable state. Caller has to instantiate a new AMRMClient.
IMO, the threads should keep on running, it should be up to the caller whether to stop the AMRMClient or not.

          try {
            response = client.allocate(progress);
          } catch (ApplicationAttemptNotFoundException e) {
            handler.onShutdownRequest();
            LOG.info("Shutdown requested. Stopping callback.");
            return;
          } catch (Throwable ex) {
            LOG.error("Exception on heartbeat", ex);
            savedException = ex;
            // interrupt handler thread in case it waiting on the queue
            handlerThread.interrupt();
            return;
          }

Issue Links

• is depended upon by: YARN-5996 Native services AM kills app on AMRMClientAsync onError call