Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5754

Null check missing for earliest in FifoPolicy

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: fairscheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Activity

      Hide
      hadoopqa Hadoop QA added a comment -
      -1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 16s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 mvninstall 6m 50s trunk passed
      +1 compile 0m 32s trunk passed
      +1 checkstyle 0m 20s trunk passed
      +1 mvnsite 0m 37s trunk passed
      +1 mvneclipse 0m 17s trunk passed
      +1 findbugs 0m 58s trunk passed
      +1 javadoc 0m 20s trunk passed
      +1 mvninstall 0m 30s the patch passed
      +1 compile 0m 29s the patch passed
      +1 javac 0m 29s the patch passed
      +1 checkstyle 0m 16s the patch passed
      +1 mvnsite 0m 35s the patch passed
      +1 mvneclipse 0m 14s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 1m 0s the patch passed
      +1 javadoc 0m 18s the patch passed
      +1 unit 38m 35s hadoop-yarn-server-resourcemanager in the patch passed.
      +1 asflicense 0m 16s The patch does not generate ASF License warnings.
      53m 1s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:9560f25
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834246/YARN-5754.001.patch
      JIRA Issue YARN-5754
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux 53ea0d14fad5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / 6fb6b65
      Default Java 1.8.0_101
      findbugs v3.0.0
      Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13450/testReport/
      modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
      Console output https://builds.apache.org/job/PreCommit-YARN-Build/13450/console
      Powered by Apache Yetus 0.3.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 50s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 58s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 0s the patch passed +1 javadoc 0m 18s the patch passed +1 unit 38m 35s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 53m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834246/YARN-5754.001.patch JIRA Issue YARN-5754 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 53ea0d14fad5 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6fb6b65 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13450/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13450/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
      Hide
      yufeigu Yufei Gu added a comment -

      Additional unit test are not necessary.

      Show
      yufeigu Yufei Gu added a comment - Additional unit test are not necessary.
      Hide
      templedf Daniel Templeton added a comment -

      LGTM. That's inline with the FairSharePolicy. +1 (non-binding)

      Show
      templedf Daniel Templeton added a comment - LGTM. That's inline with the FairSharePolicy . +1 (non-binding)
      Hide
      yufeigu Yufei Gu added a comment -
      Show
      yufeigu Yufei Gu added a comment - Thanks Daniel Templeton .
      Hide
      kasha Karthik Kambatla added a comment -

      +1. Thanks Yufei for fixing this and Daniel for the review.

      Just committed this to trunk and branch-2.

      Show
      kasha Karthik Kambatla added a comment - +1. Thanks Yufei for fixing this and Daniel for the review. Just committed this to trunk and branch-2.
      Hide
      yufeigu Yufei Gu added a comment -

      Thanks Karthik Kambatla for the review and committing.

      Show
      yufeigu Yufei Gu added a comment - Thanks Karthik Kambatla for the review and committing.
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10671 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10671/)
      YARN-5754. Null check missing for earliest in FifoPolicy. (Yufei Gu via (kasha: rev a71fc81655cd5382d354674dd06570ba49753688)

      • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/FifoPolicy.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10671 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10671/ ) YARN-5754 . Null check missing for earliest in FifoPolicy. (Yufei Gu via (kasha: rev a71fc81655cd5382d354674dd06570ba49753688) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/policies/FifoPolicy.java

        People

        • Assignee:
          yufeigu Yufei Gu
          Reporter:
          yufeigu Yufei Gu
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development