Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5718

TimelineClient (and other places in YARN) shouldn't over-write HDFS client retry settings which could cause unexpected behavior

    Details

    • Target Version/s:
    • Hadoop Flags:
      Incompatible change

      Description

      In one HA cluster, after NN failed over, we noticed that job is getting failed as TimelineClient failed to retry connection to proper NN. This is because we are overwrite hdfs client settings that hard code retry policy to be enabled that conflict NN failed-over case - hdfs client should fail fast so can retry on another NN.
      We shouldn't assume any retry policy for hdfs client at all places in YARN. This should keep consistent with HDFS settings that has different retry polices in different deployment case. Thus, we should clean up these hard code settings in YARN, include: FileSystemTimelineWriter, FileSystemRMStateStore and FileSystemNodeLabelsStore.

      1. YARN-5718.patch
        4 kB
        Junping Du
      2. YARN-5718-v2.1.patch
        9 kB
        Junping Du
      3. YARN-5718-v2.patch
        9 kB
        Junping Du

        Issue Links

          Activity

          Hide
          djp Junping Du added a comment -

          The fix is very straightforward - just remove unnecessary settings for hdfs client retry, so not include UT should be fine.

          Show
          djp Junping Du added a comment - The fix is very straightforward - just remove unnecessary settings for hdfs client retry, so not include UT should be fine.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 39s Maven dependency ordering for branch
          +1 mvninstall 6m 39s trunk passed
          +1 compile 2m 17s trunk passed
          +1 checkstyle 0m 37s trunk passed
          +1 mvnsite 1m 10s trunk passed
          +1 mvneclipse 0m 30s trunk passed
          +1 findbugs 1m 51s trunk passed
          +1 javadoc 0m 47s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 55s the patch passed
          +1 compile 2m 15s the patch passed
          +1 javac 2m 15s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 1m 2s the patch passed
          +1 mvneclipse 0m 25s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 0m 42s the patch passed
          +1 unit 2m 16s hadoop-yarn-common in the patch passed.
          -1 unit 38m 29s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          64m 49s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832492/YARN-5718.patch
          JIRA Issue YARN-5718
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0ece86db98f6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cef61d5
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13335/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13335/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13335/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13335/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 39s Maven dependency ordering for branch +1 mvninstall 6m 39s trunk passed +1 compile 2m 17s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 30s trunk passed +1 findbugs 1m 51s trunk passed +1 javadoc 0m 47s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 55s the patch passed +1 compile 2m 15s the patch passed +1 javac 2m 15s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 1m 2s the patch passed +1 mvneclipse 0m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 0m 42s the patch passed +1 unit 2m 16s hadoop-yarn-common in the patch passed. -1 unit 38m 29s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 64m 49s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fair.TestContinuousScheduling Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832492/YARN-5718.patch JIRA Issue YARN-5718 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0ece86db98f6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cef61d5 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/13335/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13335/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13335/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13335/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vrushalic Vrushali C added a comment -

          Thanks Junping, I looked at the patch and I think I agree that external YARN clients should not set/override HDFS retry settings.

          Now, with this patch, the yarn config variables TIMELINE_SERVICE_ENTITYGROUP_FS_STORE_RETRY_POLICY_SPEC, FS_NODE_LABELS_STORE_RETRY_POLICY_SPEC and their defaults are no longer used anywhere in the code. Should they be removed?
          Also, YarnConfiguration.FS_RM_STATE_STORE_RETRY_POLICY_SPEC is used in a test case in TestFSRMStateStore.java, so should that be changed too?

          Show
          vrushalic Vrushali C added a comment - Thanks Junping, I looked at the patch and I think I agree that external YARN clients should not set/override HDFS retry settings. Now, with this patch, the yarn config variables TIMELINE_SERVICE_ENTITYGROUP_FS_STORE_RETRY_POLICY_SPEC, FS_NODE_LABELS_STORE_RETRY_POLICY_SPEC and their defaults are no longer used anywhere in the code. Should they be removed? Also, YarnConfiguration.FS_RM_STATE_STORE_RETRY_POLICY_SPEC is used in a test case in TestFSRMStateStore.java, so should that be changed too?
          Hide
          djp Junping Du added a comment -

          Thanks Vrushali C for review and comments! You are right that these configurations are unnecessary any more and we should remove them. v2 patch should address your comments.

          Show
          djp Junping Du added a comment - Thanks Vrushali C for review and comments! You are right that these configurations are unnecessary any more and we should remove them. v2 patch should address your comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 10s Maven dependency ordering for branch
          +1 mvninstall 7m 9s trunk passed
          +1 compile 2m 23s trunk passed
          +1 checkstyle 0m 42s trunk passed
          +1 mvnsite 1m 39s trunk passed
          +1 mvneclipse 0m 43s trunk passed
          +1 findbugs 2m 55s trunk passed
          +1 javadoc 1m 8s trunk passed
          0 mvndep 0m 10s Maven dependency ordering for patch
          -1 mvninstall 0m 29s hadoop-yarn-server-resourcemanager in the patch failed.
          -1 compile 1m 46s hadoop-yarn in the patch failed.
          -1 javac 1m 46s hadoop-yarn in the patch failed.
          +1 checkstyle 0m 38s the patch passed
          -1 mvnsite 0m 31s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          -1 findbugs 0m 23s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 javadoc 0m 59s the patch passed
          +1 unit 0m 25s hadoop-yarn-api in the patch passed.
          +1 unit 2m 17s hadoop-yarn-common in the patch passed.
          -1 unit 0m 29s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          31m 0s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832870/YARN-5718-v2.patch
          JIRA Issue YARN-5718
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux e4236da56dea 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6476934
          Default Java 1.8.0_101
          findbugs v3.0.0
          mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          compile https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          javac https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt
          mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13358/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13358/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 7m 9s trunk passed +1 compile 2m 23s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 39s trunk passed +1 mvneclipse 0m 43s trunk passed +1 findbugs 2m 55s trunk passed +1 javadoc 1m 8s trunk passed 0 mvndep 0m 10s Maven dependency ordering for patch -1 mvninstall 0m 29s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 1m 46s hadoop-yarn in the patch failed. -1 javac 1m 46s hadoop-yarn in the patch failed. +1 checkstyle 0m 38s the patch passed -1 mvnsite 0m 31s hadoop-yarn-server-resourcemanager in the patch failed. +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. -1 findbugs 0m 23s hadoop-yarn-server-resourcemanager in the patch failed. +1 javadoc 0m 59s the patch passed +1 unit 0m 25s hadoop-yarn-api in the patch passed. +1 unit 2m 17s hadoop-yarn-common in the patch passed. -1 unit 0m 29s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 31m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832870/YARN-5718-v2.patch JIRA Issue YARN-5718 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux e4236da56dea 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6476934 Default Java 1.8.0_101 findbugs v3.0.0 mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13358/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13358/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13358/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vrushalic Vrushali C added a comment -

          Thanks Junping, the updated patch looks good.

          Not sure what the compilation error is:

          [ERROR] COMPILATION ERROR : 
          [INFO] -------------------------------------------------------------
          [ERROR]   where E is a type-variable:
              E extends Object declared in method <E>toSet(E...)
          /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java:[326,36] error: cannot find symbol
          [INFO] 1 erro
          

          Perhaps unrelated.

          Show
          vrushalic Vrushali C added a comment - Thanks Junping, the updated patch looks good. Not sure what the compilation error is: [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] where E is a type-variable: E extends Object declared in method <E>toSet(E...) /testptch/hadoop/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java:[326,36] error: cannot find symbol [INFO] 1 erro Perhaps unrelated.
          Hide
          djp Junping Du added a comment -

          Thanks Vrushali for quick comments. I think compile error is a bit misleading but indeed an issue need to fix in TestFSRMStateStore (due to a stupid mistake in generating v2 patch). v2.1 should fix the issue.

          Show
          djp Junping Du added a comment - Thanks Vrushali for quick comments. I think compile error is a bit misleading but indeed an issue need to fix in TestFSRMStateStore (due to a stupid mistake in generating v2 patch). v2.1 should fix the issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 6m 35s trunk passed
          +1 compile 2m 21s trunk passed
          +1 checkstyle 0m 41s trunk passed
          +1 mvnsite 1m 34s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 2m 58s trunk passed
          +1 javadoc 1m 4s trunk passed
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 1m 18s the patch passed
          +1 compile 2m 14s the patch passed
          +1 javac 2m 14s the patch passed
          +1 checkstyle 0m 40s the patch passed
          +1 mvnsite 1m 29s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 3m 27s the patch passed
          +1 javadoc 1m 2s the patch passed
          +1 unit 0m 31s hadoop-yarn-api in the patch passed.
          +1 unit 2m 28s hadoop-yarn-common in the patch passed.
          +1 unit 35m 18s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          66m 46s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832957/YARN-5718-v2.1.patch
          JIRA Issue YARN-5718
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
          uname Linux 1e0d14075cd7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6476934
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13364/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/13364/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 35s trunk passed +1 compile 2m 21s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 34s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 2m 58s trunk passed +1 javadoc 1m 4s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 1m 18s the patch passed +1 compile 2m 14s the patch passed +1 javac 2m 14s the patch passed +1 checkstyle 0m 40s the patch passed +1 mvnsite 1m 29s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 27s the patch passed +1 javadoc 1m 2s the patch passed +1 unit 0m 31s hadoop-yarn-api in the patch passed. +1 unit 2m 28s hadoop-yarn-common in the patch passed. +1 unit 35m 18s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 66m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832957/YARN-5718-v2.1.patch JIRA Issue YARN-5718 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 1e0d14075cd7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6476934 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13364/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/13364/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vrushalic Vrushali C added a comment -

          Thanks Junping, latest patch v2.1 looks good to me.

          Show
          vrushalic Vrushali C added a comment - Thanks Junping, latest patch v2.1 looks good to me.
          Hide
          xgong Xuan Gong added a comment - - edited

          +1 LGTM.

          Junping Du
          But I am worried about the back-incompatibility issue. Could you file a separate ticket to have a discussion for branch-2 and branch-2.8 ,please ?

          In the mean time, I will commit the patch into trunk.

          Show
          xgong Xuan Gong added a comment - - edited +1 LGTM. Junping Du But I am worried about the back-incompatibility issue. Could you file a separate ticket to have a discussion for branch-2 and branch-2.8 ,please ? In the mean time, I will commit the patch into trunk.
          Hide
          djp Junping Du added a comment -

          Thanks Xuan Gong for review and comments. File a separate one for branch-2/branch-2.8 sounds good to me. Will do it soon.

          Show
          djp Junping Du added a comment - Thanks Xuan Gong for review and comments. File a separate one for branch-2/branch-2.8 sounds good to me. Will do it soon.
          Hide
          djp Junping Du added a comment -

          Just filed YARN-5748. We have have more discussion there.

          Show
          djp Junping Du added a comment - Just filed YARN-5748 . We have have more discussion there.
          Hide
          xgong Xuan Gong added a comment -

          Committed into trunk. Let us continue our discuss on YARN-5748

          Show
          xgong Xuan Gong added a comment - Committed into trunk. Let us continue our discuss on YARN-5748
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10631 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10631/)
          YARN-5718. TimelineClient (and other places in YARN) shouldn't (xgong: rev b733a6f86262522e535cebc972baecbe6a6eab50)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/FileSystemTimelineWriter.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/FileSystemRMStateStore.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10631 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10631/ ) YARN-5718 . TimelineClient (and other places in YARN) shouldn't (xgong: rev b733a6f86262522e535cebc972baecbe6a6eab50) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/resources/yarn-default.xml (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/FileSystemNodeLabelsStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/FileSystemTimelineWriter.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/TestFSRMStateStore.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/recovery/FileSystemRMStateStore.java

            People

            • Assignee:
              djp Junping Du
              Reporter:
              djp Junping Du
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development