Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      ReservationACLsTestBase fails when verifying that a reservation can be successfully updated by a user who did not submit the reservation who also has an admin ACL.

      1. YARN-5656.v1.patch
        3 kB
        Sean Po
      2. YARN-5656.v2.patch
        8 kB
        Sean Po

        Activity

        Hide
        seanpo03 Sean Po added a comment -

        Thanks for the review and commit Arun Suresh!

        Show
        seanpo03 Sean Po added a comment - Thanks for the review and commit Arun Suresh !
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10468 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10468/)
        YARN-5656. Fix ReservationACLsTestBase. (Sean Po via asuresh) (arun suresh: rev 9f03b403ec69658fc57bc0f6b832da0e3c746497)

        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/NoOverCommitPolicy.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestNoOverCommitPolicy.java
        • (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/exceptions/MismatchedUserException.java
        • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/ReservationACLsTestBase.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10468 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10468/ ) YARN-5656 . Fix ReservationACLsTestBase. (Sean Po via asuresh) (arun suresh: rev 9f03b403ec69658fc57bc0f6b832da0e3c746497) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/NoOverCommitPolicy.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/TestNoOverCommitPolicy.java (delete) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/reservation/exceptions/MismatchedUserException.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/ReservationACLsTestBase.java
        Hide
        asuresh Arun Suresh added a comment -

        Committed this to trunk and branch-2. Thanks Sean Po

        Show
        asuresh Arun Suresh added a comment - Committed this to trunk and branch-2. Thanks Sean Po
        Hide
        asuresh Arun Suresh added a comment -

        +1 Committing this shortly..

        Show
        asuresh Arun Suresh added a comment - +1 Committing this shortly..
        Hide
        seanpo03 Sean Po added a comment -

        The Javadoc failures are not caused by the latest patch.

        Changes were made to only four files: NoOverCommitPolicy.java, [MismatchedUserException.java], ReservationACLsTestBase.java and TestNoOverCommitPolicy.java.

        None of these were referenced in the Javadoc failure results.

        Show
        seanpo03 Sean Po added a comment - The Javadoc failures are not caused by the latest patch. Changes were made to only four files: NoOverCommitPolicy.java, [MismatchedUserException.java] , ReservationACLsTestBase.java and TestNoOverCommitPolicy.java. None of these were referenced in the Javadoc failure results.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 59s trunk passed
        +1 compile 0m 51s trunk passed
        +1 checkstyle 0m 22s trunk passed
        +1 mvnsite 0m 41s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 1s trunk passed
        -1 javadoc 0m 23s hadoop-yarn-server-resourcemanager in trunk failed.
        +1 mvninstall 0m 33s the patch passed
        +1 compile 0m 32s the patch passed
        +1 javac 0m 32s the patch passed
        +1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 21 unchanged - 1 fixed = 21 total (was 22)
        +1 mvnsite 0m 39s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 10s the patch passed
        -1 javadoc 0m 20s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 unit 34m 49s hadoop-yarn-server-resourcemanager in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        51m 24s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829296/YARN-5656.v2.patch
        JIRA Issue YARN-5656
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux acac439b48f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 98bdb51
        Default Java 1.8.0_101
        findbugs v3.0.0
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13156/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13156/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13156/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13156/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 59s trunk passed +1 compile 0m 51s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 41s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 1s trunk passed -1 javadoc 0m 23s hadoop-yarn-server-resourcemanager in trunk failed. +1 mvninstall 0m 33s the patch passed +1 compile 0m 32s the patch passed +1 javac 0m 32s the patch passed +1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 21 unchanged - 1 fixed = 21 total (was 22) +1 mvnsite 0m 39s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 10s the patch passed -1 javadoc 0m 20s hadoop-yarn-server-resourcemanager in the patch failed. +1 unit 34m 49s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 51m 24s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829296/YARN-5656.v2.patch JIRA Issue YARN-5656 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux acac439b48f1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 98bdb51 Default Java 1.8.0_101 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13156/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/13156/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13156/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13156/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        seanpo03 Sean Po added a comment -

        Thanks Arun Suresh for the review. YARN-5656.v2.patch addresses your comments, and removes the unused MismatchedUserException.java file.

        Show
        seanpo03 Sean Po added a comment - Thanks Arun Suresh for the review. YARN-5656 .v2.patch addresses your comments, and removes the unused MismatchedUserException.java file.
        Hide
        asuresh Arun Suresh added a comment -

        Think you can remove the check from the testcase as well..
        +1 pending that and a good Jenkins run (The checkstyles look fixable too)

        Show
        asuresh Arun Suresh added a comment - Think you can remove the check from the testcase as well.. +1 pending that and a good Jenkins run (The checkstyles look fixable too)
        Hide
        seanpo03 Sean Po added a comment -

        I think it is safe to remove the check entirely given the two scenarios:

        1. If ACLS are enabled, then a check that ensures that the reservation is being updated by an admin / by the user who submitted the reservation is redundant.

        2. Otherwise, if ACLs are not enabled, we are saying that anyone can update any reservation, so the check would be invalid.

        Show
        seanpo03 Sean Po added a comment - I think it is safe to remove the check entirely given the two scenarios: 1. If ACLS are enabled, then a check that ensures that the reservation is being updated by an admin / by the user who submitted the reservation is redundant. 2. Otherwise, if ACLs are not enabled, we are saying that anyone can update any reservation, so the check would be invalid.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 31s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 19s trunk passed
        +1 compile 0m 36s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 43s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 6s trunk passed
        +1 javadoc 0m 23s trunk passed
        +1 mvninstall 0m 38s the patch passed
        +1 compile 0m 35s the patch passed
        +1 javac 0m 35s the patch passed
        -1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 9 unchanged - 0 fixed = 11 total (was 9)
        +1 mvnsite 0m 43s the patch passed
        +1 mvneclipse 0m 16s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 23s the patch passed
        +1 javadoc 0m 22s the patch passed
        -1 unit 33m 57s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        51m 33s



        Reason Tests
        Failed junit tests hadoop.yarn.server.resourcemanager.reservation.TestNoOverCommitPolicy



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828856/YARN-5656.v1.patch
        JIRA Issue YARN-5656
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 457e53e28194 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / b09a03c
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13123/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/13123/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13123/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13123/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/13123/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 31s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 19s trunk passed +1 compile 0m 36s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 43s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 6s trunk passed +1 javadoc 0m 23s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 0m 35s the patch passed +1 javac 0m 35s the patch passed -1 checkstyle 0m 22s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 2 new + 9 unchanged - 0 fixed = 11 total (was 9) +1 mvnsite 0m 43s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 23s the patch passed +1 javadoc 0m 22s the patch passed -1 unit 33m 57s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 51m 33s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.reservation.TestNoOverCommitPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12828856/YARN-5656.v1.patch JIRA Issue YARN-5656 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 457e53e28194 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b09a03c Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/13123/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/13123/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/13123/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/13123/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/13123/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        asuresh Arun Suresh added a comment -

        Thanks for the patch Sean Po..
        Instead of removing the check entirely, maybe you can check if the new user is admin or old user ?

        Show
        asuresh Arun Suresh added a comment - Thanks for the patch Sean Po .. Instead of removing the check entirely, maybe you can check if the new user is admin or old user ?
        Hide
        seanpo03 Sean Po added a comment -

        YARN-5656.v1.patch removes the check to verify that the same user is editing the reservation in the NoOverCommitPolicy. The patch also specifies the DominantResourceFairness policy in the ReservationACLsTestBase.

        Show
        seanpo03 Sean Po added a comment - YARN-5656 .v1.patch removes the check to verify that the same user is editing the reservation in the NoOverCommitPolicy. The patch also specifies the DominantResourceFairness policy in the ReservationACLsTestBase.

          People

          • Assignee:
            seanpo03 Sean Po
            Reporter:
            seanpo03 Sean Po
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development