Hadoop QA added a comment - 13/Aug/16 00:31 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 2s YARN-2915 passed +1 compile 0m 20s YARN-2915 passed +1 checkstyle 0m 14s YARN-2915 passed +1 mvnsite 0m 23s YARN-2915 passed +1 mvneclipse 0m 13s YARN-2915 passed +1 findbugs 0m 41s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed +1 mvninstall 0m 18s the patch passed +1 compile 0m 17s the patch passed +1 cc 0m 17s the patch passed +1 javac 0m 17s the patch passed -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 2 new + 0 unchanged - 2 fixed = 2 total (was 2) +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 46s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 0m 29s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 12m 59s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823576/YARN-5519-YARN-2915.v1.patch JIRA Issue YARN-5519 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 987058af13e6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / b689f55 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12765/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12765/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12765/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Subru Krishnan added a comment - 13/Aug/16 00:51 Thanks Ellen Hui for the patch. It mostly looks good, couple of minor comments: Add Javadocs for the getter/setter for new subClusterId field in AddApplicationHomeSubClusterResponse . Mention clearly that the subClusterId in response might be different from input in casing the mapping already exists. The changes in MemoryFederationStateStore::updateApplicationHomeSubCluster are redundant.

Ellen Hui added a comment - 13/Aug/16 01:23 Address feedback from Subru Krishnan add Javadoc to new get/set in AddApplicationHomeSubClusterResponse update Javadoc for AddApplicationHomeSubCluster in FederationApplicationHomeSubClusterStore to reflect the updated behavior removed unnecessary changes to testUpdateApplicationHomeSubCluster

Hadoop QA added a comment - 13/Aug/16 01:41 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 43s YARN-2915 passed +1 compile 0m 21s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 23s YARN-2915 passed +1 mvneclipse 0m 13s YARN-2915 passed +1 findbugs 0m 41s YARN-2915 passed +1 javadoc 0m 17s YARN-2915 passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 18s the patch passed +1 cc 0m 18s the patch passed +1 javac 0m 18s the patch passed -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 2 new + 0 unchanged - 2 fixed = 2 total (was 2) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 45s the patch passed +1 javadoc 0m 14s the patch passed -1 unit 0m 29s hadoop-yarn-server-common in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 12m 49s Reason Tests Failed junit tests hadoop.yarn.server.federation.store.impl.TestMemoryFederationStateStore Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823578/YARN-5519-YARN-2915.v2.patch JIRA Issue YARN-5519 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux e544435db770 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / b689f55 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12766/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12766/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12766/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12766/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12766/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Subru Krishnan added a comment - 15/Aug/16 19:17 Ellen Hui , I have fix for test case failure in my patch for YARN-3672 . Can you include the fix here, thanks.

Ellen Hui added a comment - 15/Aug/16 19:49 Pick the fix for FederationStateStoreBaseTest from YARN-3672

Hadoop QA added a comment - 15/Aug/16 20:12 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 17s YARN-2915 passed +1 compile 0m 20s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 25s YARN-2915 passed +1 mvneclipse 0m 12s YARN-2915 passed +1 findbugs 0m 43s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed +1 mvninstall 0m 24s the patch passed +1 compile 0m 22s the patch passed +1 cc 0m 22s the patch passed +1 javac 0m 22s the patch passed -1 checkstyle 0m 11s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 2 new + 0 unchanged - 2 fixed = 2 total (was 2) +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 52s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 0m 31s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 13m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823744/YARN-5519-YARN-2915.v3.patch JIRA Issue YARN-5519 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux cd2deaeaae16 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / b689f55 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12773/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12773/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12773/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Subru Krishnan added a comment - 15/Aug/16 20:29 Ellen Hui , I just have one last request - can you fix the Javadoc of AddApplicationHomeSubClusterResponse to say: If a mapping for the application already existed, the {@code SubClusterId} in this response will return the existing mapping which might be different from that in the {@code AddApplicationHomeSubClusterRequest}. Also include the same comment in FederationApplicationHomeSubClusterStore .

Ellen Hui added a comment - 15/Aug/16 21:07 The test failed on a timing issue, since the MemoryFederationStateStore updates the lastHeartbeat field of a SubClusterInfo during registration, causing the stored value and the expected one to differ slightly. I will remove the line in MemoryFederationStateStore that modifies the timestamp, so that the timestamp passed in through the SubClusterRegisterRequest is stored unchanged.

Ellen Hui added a comment - 15/Aug/16 21:12 Add Subru Krishnan 's javadoc suggestions Fix typos in FederationStateStoreBaseTest Remove the line in MemoryFederationStore that modifies a SubClusterInfo 's lastStartTime timestamp during registration

Hadoop QA added a comment - 15/Aug/16 21:31 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 0s YARN-2915 passed +1 compile 0m 20s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 23s YARN-2915 passed +1 mvneclipse 0m 12s YARN-2915 passed +1 findbugs 0m 46s YARN-2915 passed +1 javadoc 0m 15s YARN-2915 passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 20s the patch passed +1 cc 0m 20s the patch passed +1 javac 0m 20s the patch passed -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 2 new + 0 unchanged - 2 fixed = 2 total (was 2) +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 52s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 0m 31s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 13m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823760/YARN-5519-YARN-2915.v4.patch JIRA Issue YARN-5519 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle cc uname Linux 86689485be9f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / b689f55 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12775/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12775/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12775/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Subru Krishnan added a comment - 15/Aug/16 21:48 +1 on the latest patch. Thanks Ellen Hui for the contribution. I committed this to branch YARN-2915 .