Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5483

Optimize RMAppAttempt#pullJustFinishedContainers

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 2.6.5, 2.7.4, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      about 1000 app running on cluster, jprofiler found pullJustFinishedContainers cost too much cpu.

      1. jprofiler-cpu.png
        40 kB
        sandflee
      2. YARN-5483.01.patch
        2 kB
        sandflee
      3. YARN-5483.02.patch
        5 kB
        sandflee
      4. YARN-5483.03.patch
        5 kB
        sandflee
      5. YARN-5483.04.patch
        6 kB
        sandflee
      6. YARN-5483-branch-2.6.patch
        3 kB
        sandflee
      7. YARN-5483-branch-2.6.patch.02
        3 kB
        sandflee
      8. YARN-5483-branch-2.7.patch
        5 kB
        sandflee
      9. YARN-5483-branch-2.7.patch.02
        5 kB
        sandflee

        Issue Links

          Activity

          Hide
          sandflee sandflee added a comment -

          YARN-5262 is patched. found justFinishedContainers is never cleared, and there are many unnecessarily update to justFinishedContainers.

                  // Clear and get current values
                  List<ContainerStatus> finishedContainers = justFinishedContainers.put
                      (nodeId, new ArrayList<ContainerStatus>());
          
          Show
          sandflee sandflee added a comment - YARN-5262 is patched. found justFinishedContainers is never cleared, and there are many unnecessarily update to justFinishedContainers. // Clear and get current values List<ContainerStatus> finishedContainers = justFinishedContainers.put (nodeId, new ArrayList<ContainerStatus>());
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 53s trunk passed
          +1 compile 0m 32s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 37s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 0m 56s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 30s the patch passed
          +1 compile 0m 30s the patch passed
          +1 javac 0m 30s the patch passed
          +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 112 unchanged - 1 fixed = 112 total (was 113)
          +1 mvnsite 0m 35s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 1s the patch passed
          +1 javadoc 0m 18s the patch passed
          +1 unit 37m 9s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          51m 40s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822557/YARN-5483.01.patch
          JIRA Issue YARN-5483
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux e8c932efe49d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4d3af47
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12668/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12668/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 53s trunk passed +1 compile 0m 32s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 56s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 30s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 18s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 112 unchanged - 1 fixed = 112 total (was 113) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 1s the patch passed +1 javadoc 0m 18s the patch passed +1 unit 37m 9s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 51m 40s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822557/YARN-5483.01.patch JIRA Issue YARN-5483 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e8c932efe49d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4d3af47 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12668/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12668/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the report and patch, sandflee!

          +1, patch looks good to me. I will commit this tomorrow if there are no objections.

          Show
          jlowe Jason Lowe added a comment - Thanks for the report and patch, sandflee ! +1, patch looks good to me. I will commit this tomorrow if there are no objections.
          Hide
          templedf Daniel Templeton added a comment -

          Looks good to me. Looks like the call to pullJustFinishedContainers() wasn't clearing the list of just finished containers per the method contract. Nice catch.

          With these lines:

                  finishedContainersSentToAM.putIfAbsent(nodeId,
                      new ArrayList<ContainerStatus>());
          

          can you please use the diamond operator in the list constructor and merge them back into one line?

          Show
          templedf Daniel Templeton added a comment - Looks good to me. Looks like the call to pullJustFinishedContainers() wasn't clearing the list of just finished containers per the method contract. Nice catch. With these lines: finishedContainersSentToAM.putIfAbsent(nodeId, new ArrayList<ContainerStatus>()); can you please use the diamond operator in the list constructor and merge them back into one line?
          Hide
          sandflee sandflee added a comment -

          thanks Daniel Templeton, update the patch to add diamond operator to finishedContainersSentToAM and justFinishedContainers related code.

          Show
          sandflee sandflee added a comment - thanks Daniel Templeton , update the patch to add diamond operator to finishedContainersSentToAM and justFinishedContainers related code.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 9m 19s trunk passed
          +1 compile 0m 33s trunk passed
          +1 checkstyle 0m 21s trunk passed
          +1 mvnsite 0m 41s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 1m 4s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          +1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 112 unchanged - 1 fixed = 112 total (was 113)
          +1 mvnsite 0m 37s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 2s the patch passed
          +1 javadoc 0m 20s the patch passed
          -1 unit 38m 10s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 16s The patch does not generate ASF License warnings.
          55m 37s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822692/YARN-5483.02.patch
          JIRA Issue YARN-5483
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f167dec99c26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0705489
          Default Java 1.8.0_101
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12682/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12682/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12682/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12682/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 19s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 21s trunk passed +1 mvnsite 0m 41s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 4s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed +1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 112 unchanged - 1 fixed = 112 total (was 113) +1 mvnsite 0m 37s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 2s the patch passed +1 javadoc 0m 20s the patch passed -1 unit 38m 10s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 55m 37s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestSubmitApplicationWithRMHA Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822692/YARN-5483.02.patch JIRA Issue YARN-5483 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f167dec99c26 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0705489 Default Java 1.8.0_101 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/12682/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12682/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12682/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12682/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          sandflee sandflee added a comment -

          test failure seems not related to the patch, the test may fail with or without the patch. modified the test timeout from 5s to 50s, the test could always succ

          Show
          sandflee sandflee added a comment - test failure seems not related to the patch, the test may fail with or without the patch. modified the test timeout from 5s to 50s, the test could always succ
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Thanks sandflee for the patch. Good catch!! The overall patch make sense to me.
          One small doubt, how YARN-5262 breaks this JIRA?

          Show
          rohithsharma Rohith Sharma K S added a comment - Thanks sandflee for the patch. Good catch!! The overall patch make sense to me. One small doubt, how YARN-5262 breaks this JIRA?
          Hide
          sandflee sandflee added a comment -

          thanks Rohith Sharma K S, I don't think YARN-5262 breaks this jira.

          Show
          sandflee sandflee added a comment - thanks Rohith Sharma K S , I don't think YARN-5262 breaks this jira.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Thanks sandflee for the confirmation, I will just remove the broken by link.

          Show
          rohithsharma Rohith Sharma K S added a comment - Thanks sandflee for the confirmation, I will just remove the broken by link.
          Hide
          jianhe Jian He added a comment -

          thanks for the catch ! A minor typo in the existing code, 'keepContainersAcressAttempts', mind fixing the same ?

          Show
          jianhe Jian He added a comment - thanks for the catch ! A minor typo in the existing code, 'keepContainersAcressAttempts', mind fixing the same ?
          Hide
          sandflee sandflee added a comment -

          update the patch, rename keepContainersAcressAttempts to keepContainersAcrossAppAttempts

          Show
          sandflee sandflee added a comment - update the patch, rename keepContainersAcressAttempts to keepContainersAcrossAppAttempts
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 2s trunk passed
          +1 compile 0m 33s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 39s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 0m 58s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 30s the patch passed
          +1 javac 0m 30s the patch passed
          +1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 112 unchanged - 1 fixed = 112 total (was 113)
          +1 mvnsite 0m 36s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 5s the patch passed
          +1 javadoc 0m 19s the patch passed
          +1 unit 37m 52s hadoop-yarn-server-resourcemanager in the patch passed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          52m 46s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822754/YARN-5483.03.patch
          JIRA Issue YARN-5483
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3c6cd7d5fc01 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 82c9e06
          Default Java 1.8.0_101
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12688/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12688/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 2s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 39s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 0m 58s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 30s the patch passed +1 javac 0m 30s the patch passed +1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 0 new + 112 unchanged - 1 fixed = 112 total (was 113) +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 5s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 37m 52s hadoop-yarn-server-resourcemanager in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 52m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822754/YARN-5483.03.patch JIRA Issue YARN-5483 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3c6cd7d5fc01 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 82c9e06 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12688/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12688/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          I don't think YARN-5262 breaks this jira.

          Yeah, it looks like YARN-1372 is the source, and that went into 2.6. As such it'd be nice to have this go into 2.7.4 and 2.6.5 since it seems like an important performance fix.

          Thanks for updating the patch! Latest one looks good to me as well. Could you provide patches for 2.7/2.6 as well? Note that 2.6 does not support JDK7, so we can't use the diamond operator there.

          Show
          jlowe Jason Lowe added a comment - I don't think YARN-5262 breaks this jira. Yeah, it looks like YARN-1372 is the source, and that went into 2.6. As such it'd be nice to have this go into 2.7.4 and 2.6.5 since it seems like an important performance fix. Thanks for updating the patch! Latest one looks good to me as well. Could you provide patches for 2.7/2.6 as well? Note that 2.6 does not support JDK7, so we can't use the diamond operator there.
          Hide
          templedf Daniel Templeton added a comment -

          LGTM. +1 (non-binding)

          Show
          templedf Daniel Templeton added a comment - LGTM. +1 (non-binding)
          Hide
          sandflee sandflee added a comment - - edited

          1, update a new patch to fix some other diamond operator issues
          2, in branch-2.7.patch

                  finishedContainersSentToAM.putIfAbsent(nodeId,
                      new ArrayList<>());
          

          this leads to compile errors about "java.util.ArrayList<java.lang.Object>can't cast to java.util.List<org.apache.hadoop.yarn.api.records.ContainerStatus>)", I don;t known why, so removed the related fix.

          Show
          sandflee sandflee added a comment - - edited 1, update a new patch to fix some other diamond operator issues 2, in branch-2.7.patch finishedContainersSentToAM.putIfAbsent(nodeId, new ArrayList<>()); this leads to compile errors about "java.util.ArrayList<java.lang.Object>can't cast to java.util.List<org.apache.hadoop.yarn.api.records.ContainerStatus>)", I don;t known why, so removed the related fix.
          Hide
          sandflee sandflee added a comment -

          without YARN-5262 , there will be too many FINISHED_CONTAINERS_PULLED_BY_AM event, seems we should merge YARN-5262 to 2.6/2.7 too.

          Show
          sandflee sandflee added a comment - without YARN-5262 , there will be too many FINISHED_CONTAINERS_PULLED_BY_AM event, seems we should merge YARN-5262 to 2.6/2.7 too.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 12m 1s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 15s branch-2.6 passed
          +1 compile 0m 23s branch-2.6 passed with JDK v1.8.0_101
          +1 compile 0m 28s branch-2.6 passed with JDK v1.7.0_101
          +1 checkstyle 0m 20s branch-2.6 passed
          +1 mvnsite 0m 34s branch-2.6 passed
          +1 mvneclipse 0m 18s branch-2.6 passed
          -1 findbugs 0m 58s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.6 has 2 extant Findbugs warnings.
          -1 javadoc 0m 18s hadoop-yarn-server-resourcemanager in branch-2.6 failed with JDK v1.8.0_101.
          +1 javadoc 0m 22s branch-2.6 passed with JDK v1.7.0_101
          +1 mvninstall 0m 28s the patch passed
          +1 compile 0m 21s the patch passed with JDK v1.8.0_101
          +1 javac 0m 21s the patch passed
          +1 compile 0m 25s the patch passed with JDK v1.7.0_101
          +1 javac 0m 25s the patch passed
          +1 checkstyle 0m 14s the patch passed
          +1 mvnsite 0m 32s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          -1 whitespace 0m 0s The patch has 2019 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 51s The patch 70 line(s) with tabs.
          +1 findbugs 1m 6s the patch passed
          -1 javadoc 0m 15s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101.
          +1 javadoc 0m 20s the patch passed with JDK v1.7.0_101
          -1 unit 46m 0s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101.
          -1 unit 61m 13s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101.
          -1 asflicense 0m 32s The patch generated 106 ASF License warnings.
          137m 41s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
          JDK v1.7.0_101 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:44eef0e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822833/YARN-5483-branch-2.6.patch
          JIRA Issue YARN-5483
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 78dbce95f4b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.6 / 4feb17e
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v1.3.9
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/whitespace-tabs.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12696/testReport/
          asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12696/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 12m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 15s branch-2.6 passed +1 compile 0m 23s branch-2.6 passed with JDK v1.8.0_101 +1 compile 0m 28s branch-2.6 passed with JDK v1.7.0_101 +1 checkstyle 0m 20s branch-2.6 passed +1 mvnsite 0m 34s branch-2.6 passed +1 mvneclipse 0m 18s branch-2.6 passed -1 findbugs 0m 58s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.6 has 2 extant Findbugs warnings. -1 javadoc 0m 18s hadoop-yarn-server-resourcemanager in branch-2.6 failed with JDK v1.8.0_101. +1 javadoc 0m 22s branch-2.6 passed with JDK v1.7.0_101 +1 mvninstall 0m 28s the patch passed +1 compile 0m 21s the patch passed with JDK v1.8.0_101 +1 javac 0m 21s the patch passed +1 compile 0m 25s the patch passed with JDK v1.7.0_101 +1 javac 0m 25s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 32s the patch passed +1 mvneclipse 0m 13s the patch passed -1 whitespace 0m 0s The patch has 2019 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 51s The patch 70 line(s) with tabs. +1 findbugs 1m 6s the patch passed -1 javadoc 0m 15s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. +1 javadoc 0m 20s the patch passed with JDK v1.7.0_101 -1 unit 46m 0s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. -1 unit 61m 13s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101. -1 asflicense 0m 32s The patch generated 106 ASF License warnings. 137m 41s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.recovery.TestFSRMStateStore   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_101 Timed out junit tests org.apache.hadoop.yarn.server.resourcemanager.TestResourceTrackerService Subsystem Report/Notes Docker Image:yetus/hadoop:44eef0e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822833/YARN-5483-branch-2.6.patch JIRA Issue YARN-5483 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 78dbce95f4b3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.6 / 4feb17e Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v1.3.9 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/whitespace-tabs.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12696/testReport/ asflicense https://builds.apache.org/job/PreCommit-YARN-Build/12696/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12696/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          seems we should merge YARN-5262 to 2.6/2.7 too.

          Good catch! I committed YARN-5262 to 2.8, 2.7, and 2.6. Could you rebase the 2.7 and 2.6 patches? Trunk patch lgtm.

          Show
          jlowe Jason Lowe added a comment - seems we should merge YARN-5262 to 2.6/2.7 too. Good catch! I committed YARN-5262 to 2.8, 2.7, and 2.6. Could you rebase the 2.7 and 2.6 patches? Trunk patch lgtm.
          Hide
          sandflee sandflee added a comment -

          update the patch.

          Show
          sandflee sandflee added a comment - update the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 17m 48s Docker mode activated.
          0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 21s branch-2.7 passed
          +1 compile 0m 28s branch-2.7 passed with JDK v1.8.0_101
          +1 compile 0m 29s branch-2.7 passed with JDK v1.7.0_101
          +1 checkstyle 0m 24s branch-2.7 passed
          +1 mvnsite 0m 38s branch-2.7 passed
          +1 mvneclipse 0m 18s branch-2.7 passed
          -1 findbugs 1m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings.
          +1 javadoc 0m 22s branch-2.7 passed with JDK v1.8.0_101
          +1 javadoc 0m 25s branch-2.7 passed with JDK v1.7.0_101
          +1 mvninstall 0m 28s the patch passed
          +1 compile 0m 31s the patch passed with JDK v1.8.0_101
          +1 javac 0m 31s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.7.0_101
          +1 javac 0m 28s the patch passed
          -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 396 unchanged - 1 fixed = 397 total (was 397)
          +1 mvnsite 0m 34s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 2393 line(s) that end in whitespace. Use git apply --whitespace=fix.
          -1 whitespace 0m 58s The patch 72 line(s) with tabs.
          +1 findbugs 1m 12s the patch passed
          +1 javadoc 0m 15s the patch passed with JDK v1.8.0_101
          +1 javadoc 0m 21s the patch passed with JDK v1.7.0_101
          -1 unit 52m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101.
          -1 unit 53m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101.
          +1 asflicense 0m 17s The patch does not generate ASF License warnings.
          143m 5s



          Reason Tests
          JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:c420dfe
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822909/YARN-5483-branch-2.7.patch.02
          JIRA Issue YARN-5483
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c4593b9980e9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 5580626
          Default Java 1.7.0_101
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/whitespace-eol.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/whitespace-tabs.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt
          JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12706/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/12706/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 17m 48s Docker mode activated. 0 patch 0m 2s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 21s branch-2.7 passed +1 compile 0m 28s branch-2.7 passed with JDK v1.8.0_101 +1 compile 0m 29s branch-2.7 passed with JDK v1.7.0_101 +1 checkstyle 0m 24s branch-2.7 passed +1 mvnsite 0m 38s branch-2.7 passed +1 mvneclipse 0m 18s branch-2.7 passed -1 findbugs 1m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager in branch-2.7 has 1 extant Findbugs warnings. +1 javadoc 0m 22s branch-2.7 passed with JDK v1.8.0_101 +1 javadoc 0m 25s branch-2.7 passed with JDK v1.7.0_101 +1 mvninstall 0m 28s the patch passed +1 compile 0m 31s the patch passed with JDK v1.8.0_101 +1 javac 0m 31s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_101 +1 javac 0m 28s the patch passed -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 396 unchanged - 1 fixed = 397 total (was 397) +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 2393 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 58s The patch 72 line(s) with tabs. +1 findbugs 1m 12s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 21s the patch passed with JDK v1.7.0_101 -1 unit 52m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_101. -1 unit 53m 19s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_101. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 143m 5s Reason Tests JDK v1.8.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_101 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:c420dfe JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12822909/YARN-5483-branch-2.7.patch.02 JIRA Issue YARN-5483 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c4593b9980e9 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 5580626 Default Java 1.7.0_101 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/whitespace-tabs.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_101.txt https://builds.apache.org/job/PreCommit-YARN-Build/12706/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_101.txt JDK v1.7.0_101 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12706/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/12706/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          +1 for the 2.7 and 2.6 patch as well. Committing this.

          Show
          jlowe Jason Lowe added a comment - +1 for the 2.7 and 2.6 patch as well. Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks to sandflee for the contribution and to Daniel Templeton, Rohith Sharma K S, and Jian He for additional review! I committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6.

          Show
          jlowe Jason Lowe added a comment - Thanks to sandflee for the contribution and to Daniel Templeton , Rohith Sharma K S , and Jian He for additional review! I committed this to trunk, branch-2, branch-2.8, branch-2.7, and branch-2.6.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #10253 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10253/)
          YARN-5483. Optimize RMAppAttempt#pullJustFinishedContainers. Contributed (jlowe: rev e0b570dffb47ede298e0378a63350b699128d96e)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10253 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10253/ ) YARN-5483 . Optimize RMAppAttempt#pullJustFinishedContainers. Contributed (jlowe: rev e0b570dffb47ede298e0378a63350b699128d96e) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptImpl.java
          Hide
          sandflee sandflee added a comment -

          thanks Jason Lowe Daniel Templeton Jian He and Rohith Sharma K S for the review and commit!

          Show
          sandflee sandflee added a comment - thanks Jason Lowe Daniel Templeton Jian He and Rohith Sharma K S for the review and commit!

            People

            • Assignee:
              sandflee sandflee
              Reporter:
              sandflee sandflee
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development