[YARN-5472] WIN_MAX_PATH logic is off by one

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.6.0
• Component/s: nodemanager
• Labels: oct16-easy

Environment

Windows

• Assignee: Brook Zhou
• Reporter: Brook Zhou
• Created: 04/Aug/16 00:23
• Updated: 27/Oct/16 18:36

Description

The following check is incorrect in DefaultContainerExecutor:

if (Shell.WINDOWS && sb.getWrapperScriptPath().toString().length() > WIN_MAX_PATH)

should be >=, as the max path is defined as "D:\some 256-character path string<NUL>" on Windows platforms.