Details

    • Hadoop Flags:
      Reviewed

      Description

      We need to check for mandatory fields, well formed-ness (for address fields) etc of input params to FederationStateStore. This is common across all Store implementations and can be used as a fail-fast mechanism on the client side.

      1. YARN-5467-YARN-2915.v0.patch
        77 kB
        Giovanni Matteo Fumarola
      2. YARN-5467-YARN-2915.v1.patch
        77 kB
        Giovanni Matteo Fumarola
      3. YARN-5467-YARN-2915.v2.patch
        77 kB
        Giovanni Matteo Fumarola
      4. YARN-5467-YARN-2915.v3.patch
        86 kB
        Giovanni Matteo Fumarola
      5. YARN-5467-YARN-2915.v4.patch
        88 kB
        Giovanni Matteo Fumarola
      6. YARN-5467-YARN-2915.v5.patch
        88 kB
        Giovanni Matteo Fumarola
      7. YARN-5467-YARN-2915.v6.patch
        88 kB
        Giovanni Matteo Fumarola
      8. YARN-5467-YARN-2915.v7.patch
        88 kB
        Giovanni Matteo Fumarola

        Activity

        Hide
        subru Subru Krishnan added a comment -

        +1 on the latest (v7) patch. I just committed this to branch YARN-2915.

        Thanks Giovanni Matteo Fumarola for your contribution.

        Show
        subru Subru Krishnan added a comment - +1 on the latest (v7) patch. I just committed this to branch YARN-2915 . Thanks Giovanni Matteo Fumarola for your contribution.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 0s YARN-2915 passed
        +1 compile 0m 20s YARN-2915 passed
        +1 checkstyle 0m 14s YARN-2915 passed
        +1 mvnsite 0m 23s YARN-2915 passed
        +1 mvneclipse 0m 13s YARN-2915 passed
        +1 findbugs 0m 44s YARN-2915 passed
        +1 javadoc 0m 16s YARN-2915 passed
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 18s the patch passed
        +1 javac 0m 18s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 22s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 46s the patch passed
        +1 javadoc 0m 14s the patch passed
        +1 unit 0m 31s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        13m 14s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824190/YARN-5467-YARN-2915.v7.patch
        JIRA Issue YARN-5467
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 50258a775e2f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / fc5d839
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12807/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12807/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 0s YARN-2915 passed +1 compile 0m 20s YARN-2915 passed +1 checkstyle 0m 14s YARN-2915 passed +1 mvnsite 0m 23s YARN-2915 passed +1 mvneclipse 0m 13s YARN-2915 passed +1 findbugs 0m 44s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 18s the patch passed +1 javac 0m 18s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 46s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 0m 31s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 13m 14s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824190/YARN-5467-YARN-2915.v7.patch JIRA Issue YARN-5467 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 50258a775e2f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / fc5d839 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12807/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12807/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        subru Subru Krishnan added a comment -

        Giovanni Matteo Fumarola, the latest patch LGTM. I just have one request, can you use slf4j instead of log4j for the Logger especially since these are new classes. Thanks.

        Show
        subru Subru Krishnan added a comment - Giovanni Matteo Fumarola , the latest patch LGTM. I just have one request, can you use slf4j instead of log4j for the Logger especially since these are new classes. Thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 24s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 35s YARN-2915 passed
        +1 compile 1m 38s YARN-2915 passed
        +1 checkstyle 0m 13s YARN-2915 passed
        +1 mvnsite 0m 24s YARN-2915 passed
        +1 mvneclipse 0m 15s YARN-2915 passed
        +1 findbugs 0m 43s YARN-2915 passed
        +1 javadoc 0m 16s YARN-2915 passed
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 19s the patch passed
        +1 javac 0m 19s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 22s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 48s the patch passed
        +1 javadoc 0m 15s the patch passed
        +1 unit 0m 31s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        15m 20s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824027/YARN-5467-YARN-2915.v6.patch
        JIRA Issue YARN-5467
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5940a1280595 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 0048ce1
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12799/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12799/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 24s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 35s YARN-2915 passed +1 compile 1m 38s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 24s YARN-2915 passed +1 mvneclipse 0m 15s YARN-2915 passed +1 findbugs 0m 43s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed +1 mvninstall 0m 18s the patch passed +1 compile 0m 19s the patch passed +1 javac 0m 19s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 48s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 0m 31s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 15m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12824027/YARN-5467-YARN-2915.v6.patch JIRA Issue YARN-5467 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5940a1280595 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 0048ce1 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12799/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12799/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        subru Subru Krishnan added a comment -

        Usually happens if you @link in the Javadocs for classes that are not directly imported, so you should replace them with @code. Use @link only if the class is already imported for compile dependency.

        Show
        subru Subru Krishnan added a comment - Usually happens if you @link in the Javadocs for classes that are not directly imported, so you should replace them with @code . Use @link only if the class is already imported for compile dependency.
        Hide
        giovanni.fumarola Giovanni Matteo Fumarola added a comment -

        This is kind of weird.
        If I insert the imports, the checkstyle fails.
        If I don't insert the imports, the javadoc fails.

        Show
        giovanni.fumarola Giovanni Matteo Fumarola added a comment - This is kind of weird. If I insert the imports, the checkstyle fails. If I don't insert the imports, the javadoc fails.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 44s YARN-2915 passed
        +1 compile 0m 21s YARN-2915 passed
        +1 checkstyle 0m 13s YARN-2915 passed
        +1 mvnsite 0m 23s YARN-2915 passed
        +1 mvneclipse 0m 13s YARN-2915 passed
        +1 findbugs 0m 42s YARN-2915 passed
        +1 javadoc 0m 16s YARN-2915 passed
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 17s the patch passed
        +1 javac 0m 17s the patch passed
        -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2)
        +1 mvnsite 0m 21s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 48s the patch passed
        +1 javadoc 0m 14s the patch passed
        +1 unit 0m 29s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        12m 52s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823994/YARN-5467-YARN-2915.v5.patch
        JIRA Issue YARN-5467
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux edbb963deb34 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 0048ce1
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12795/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12795/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12795/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 44s YARN-2915 passed +1 compile 0m 21s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 23s YARN-2915 passed +1 mvneclipse 0m 13s YARN-2915 passed +1 findbugs 0m 42s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 3 new + 2 unchanged - 0 fixed = 5 total (was 2) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 48s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 0m 29s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 12m 52s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823994/YARN-5467-YARN-2915.v5.patch JIRA Issue YARN-5467 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux edbb963deb34 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 0048ce1 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12795/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12795/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12795/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        giovanni.fumarola Giovanni Matteo Fumarola added a comment -

        Thanks Subru Krishnan for reviewing.

        1) Done.
        2) Done.
        3) Done.
        4) It is already an ApplicationId. We should parser if it is a String.
        5) Done.
        6) Done.
        7) Done. Current structure: Valid Input, Null Input.A, Invalid Input.A, Null Input.B, Invalid Input.B
        8) Done.

        Show
        giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Subru Krishnan for reviewing. 1) Done. 2) Done. 3) Done. 4) It is already an ApplicationId. We should parser if it is a String. 5) Done. 6) Done. 7) Done. Current structure: Valid Input, Null Input.A, Invalid Input.A, Null Input.B, Invalid Input.B 8) Done.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 43s YARN-2915 passed
        +1 compile 0m 20s YARN-2915 passed
        +1 checkstyle 0m 13s YARN-2915 passed
        +1 mvnsite 0m 24s YARN-2915 passed
        +1 mvneclipse 0m 12s YARN-2915 passed
        +1 findbugs 0m 43s YARN-2915 passed
        +1 javadoc 0m 16s YARN-2915 passed
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 18s the patch passed
        +1 javac 0m 18s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 23s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 54s the patch passed
        -1 javadoc 0m 14s hadoop-yarn-server-common in the patch failed.
        +1 unit 0m 31s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        14m 5s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823985/YARN-5467-YARN-2915.v4.patch
        JIRA Issue YARN-5467
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b66b05676ab7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 0048ce1
        Default Java 1.8.0_101
        findbugs v3.0.0
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12794/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12794/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12794/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 43s YARN-2915 passed +1 compile 0m 20s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 24s YARN-2915 passed +1 mvneclipse 0m 12s YARN-2915 passed +1 findbugs 0m 43s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 18s the patch passed +1 javac 0m 18s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 54s the patch passed -1 javadoc 0m 14s hadoop-yarn-server-common in the patch failed. +1 unit 0m 31s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 14m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823985/YARN-5467-YARN-2915.v4.patch JIRA Issue YARN-5467 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b66b05676ab7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 0048ce1 Default Java 1.8.0_101 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12794/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12794/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12794/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 12s YARN-2915 passed
        +1 compile 0m 20s YARN-2915 passed
        +1 checkstyle 0m 13s YARN-2915 passed
        +1 mvnsite 0m 23s YARN-2915 passed
        +1 mvneclipse 0m 13s YARN-2915 passed
        +1 findbugs 0m 42s YARN-2915 passed
        +1 javadoc 0m 16s YARN-2915 passed
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 18s the patch passed
        +1 javac 0m 18s the patch passed
        -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2)
        +1 mvnsite 0m 21s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 47s the patch passed
        -1 javadoc 0m 16s hadoop-yarn-server-common in the patch failed.
        -1 unit 0m 33s hadoop-yarn-server-common in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        13m 27s



        Reason Tests
        Failed junit tests hadoop.yarn.server.federation.store.impl.TestMemoryFederationStateStore



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823975/YARN-5467-YARN-2915.v3.patch
        JIRA Issue YARN-5467
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 477558fee202 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 0048ce1
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12791/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12791/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/12791/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12791/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12791/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12791/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 12s YARN-2915 passed +1 compile 0m 20s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 23s YARN-2915 passed +1 mvneclipse 0m 13s YARN-2915 passed +1 findbugs 0m 42s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 18s the patch passed +1 javac 0m 18s the patch passed -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 47s the patch passed -1 javadoc 0m 16s hadoop-yarn-server-common in the patch failed. -1 unit 0m 33s hadoop-yarn-server-common in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 13m 27s Reason Tests Failed junit tests hadoop.yarn.server.federation.store.impl.TestMemoryFederationStateStore Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823975/YARN-5467-YARN-2915.v3.patch JIRA Issue YARN-5467 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 477558fee202 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 0048ce1 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12791/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/12791/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/12791/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/12791/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12791/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12791/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        subru Subru Krishnan added a comment -

        Thanks Giovanni Matteo Fumarola for working on this. Good job especially with the test coverage.

        I have a few minor comments:

        • Move the InputValidator classes to org.apache.hadoop.yarn.server.federation.store.utils package.
        • Align the InputValidator class names with the Store interface names.
        • Consider logging the exception before throwing. This way we need to only log in single place for any input validation errors instead of in each store impl.
        • In FederationApplicationInputValidator::checkApplicationId, we should also check if the value if parseable into an ApplicationId.
        • There are few typos in the exception message, for e.g: checkSubClusterPolicyConfiguration, checkQueue, etc.
        • Remove the Correct suffix from tests as they check both valid & invalid scenarios.
        • Nit: move the null tests before the invalid tests.
        • Can you integrate the _InputValidators_with MemoryFederationStateStore as now they are not being used anywhere.
        Show
        subru Subru Krishnan added a comment - Thanks Giovanni Matteo Fumarola for working on this. Good job especially with the test coverage. I have a few minor comments: Move the InputValidator classes to org.apache.hadoop.yarn.server.federation.store.utils package. Align the InputValidator class names with the Store interface names. Consider logging the exception before throwing. This way we need to only log in single place for any input validation errors instead of in each store impl. In FederationApplicationInputValidator::checkApplicationId , we should also check if the value if parseable into an ApplicationId . There are few typos in the exception message, for e.g: checkSubClusterPolicyConfiguration , checkQueue , etc. Remove the Correct suffix from tests as they check both valid & invalid scenarios. Nit: move the null tests before the invalid tests. Can you integrate the _InputValidators_with MemoryFederationStateStore as now they are not being used anywhere.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 40s YARN-2915 passed
        +1 compile 0m 21s YARN-2915 passed
        +1 checkstyle 0m 13s YARN-2915 passed
        +1 mvnsite 0m 24s YARN-2915 passed
        +1 mvneclipse 0m 12s YARN-2915 passed
        +1 findbugs 0m 42s YARN-2915 passed
        +1 javadoc 0m 16s YARN-2915 passed
        +1 mvninstall 0m 20s the patch passed
        +1 compile 0m 18s the patch passed
        +1 javac 0m 18s the patch passed
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 57s the patch passed
        +1 javadoc 0m 15s the patch passed
        +1 unit 0m 33s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        13m 17s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823540/YARN-5467-YARN-2915.v2.patch
        JIRA Issue YARN-5467
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0ae57cf5ff79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / b689f55
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12761/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12761/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 40s YARN-2915 passed +1 compile 0m 21s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 24s YARN-2915 passed +1 mvneclipse 0m 12s YARN-2915 passed +1 findbugs 0m 42s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed +1 mvninstall 0m 20s the patch passed +1 compile 0m 18s the patch passed +1 javac 0m 18s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 57s the patch passed +1 javadoc 0m 15s the patch passed +1 unit 0m 33s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 13m 17s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823540/YARN-5467-YARN-2915.v2.patch JIRA Issue YARN-5467 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0ae57cf5ff79 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / b689f55 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12761/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12761/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 8m 26s YARN-2915 passed
        +1 compile 0m 23s YARN-2915 passed
        +1 checkstyle 0m 13s YARN-2915 passed
        +1 mvnsite 0m 29s YARN-2915 passed
        +1 mvneclipse 0m 13s YARN-2915 passed
        +1 findbugs 0m 50s YARN-2915 passed
        +1 javadoc 0m 18s YARN-2915 passed
        +1 mvninstall 0m 23s the patch passed
        +1 compile 0m 23s the patch passed
        +1 javac 0m 23s the patch passed
        -1 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 mvnsite 0m 22s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 57s the patch passed
        +1 javadoc 0m 14s the patch passed
        +1 unit 0m 37s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        15m 30s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823526/YARN-5467-YARN-2915.v1.patch
        JIRA Issue YARN-5467
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f06f2982996e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / b689f55
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12760/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12760/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12760/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 26s YARN-2915 passed +1 compile 0m 23s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 29s YARN-2915 passed +1 mvneclipse 0m 13s YARN-2915 passed +1 findbugs 0m 50s YARN-2915 passed +1 javadoc 0m 18s YARN-2915 passed +1 mvninstall 0m 23s the patch passed +1 compile 0m 23s the patch passed +1 javac 0m 23s the patch passed -1 checkstyle 0m 12s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 57s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 0m 37s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 15m 30s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823526/YARN-5467-YARN-2915.v1.patch JIRA Issue YARN-5467 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f06f2982996e 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / b689f55 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12760/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12760/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12760/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 50s YARN-2915 passed
        +1 compile 0m 21s YARN-2915 passed
        +1 checkstyle 0m 13s YARN-2915 passed
        +1 mvnsite 0m 23s YARN-2915 passed
        +1 mvneclipse 0m 14s YARN-2915 passed
        +1 findbugs 0m 42s YARN-2915 passed
        +1 javadoc 0m 16s YARN-2915 passed
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 18s the patch passed
        +1 javac 0m 18s the patch passed
        -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0)
        +1 mvnsite 0m 20s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 48s the patch passed
        +1 javadoc 0m 14s the patch passed
        +1 unit 0m 30s hadoop-yarn-server-common in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        12m 58s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823385/YARN-5467-YARN-2915.v0.patch
        JIRA Issue YARN-5467
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux cb6636c91244 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / b689f55
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12751/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12751/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/12751/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 50s YARN-2915 passed +1 compile 0m 21s YARN-2915 passed +1 checkstyle 0m 13s YARN-2915 passed +1 mvnsite 0m 23s YARN-2915 passed +1 mvneclipse 0m 14s YARN-2915 passed +1 findbugs 0m 42s YARN-2915 passed +1 javadoc 0m 16s YARN-2915 passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 18s the patch passed +1 javac 0m 18s the patch passed -1 checkstyle 0m 10s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 48s the patch passed +1 javadoc 0m 14s the patch passed +1 unit 0m 30s hadoop-yarn-server-common in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 12m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12823385/YARN-5467-YARN-2915.v0.patch JIRA Issue YARN-5467 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux cb6636c91244 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / b689f55 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/12751/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/12751/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common Console output https://builds.apache.org/job/PreCommit-YARN-Build/12751/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            giovanni.fumarola Giovanni Matteo Fumarola
            Reporter:
            subru Subru Krishnan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development