Details

    • Hadoop Flags:
      Reviewed

      Description

      As detailed in the proposal in the umbrella JIRA, we are introducing a new component that routes client request to appropriate ResourceManager(s). This JIRA tracks the creation of a proxy for ResourceManager Admin API in the Router. This provides a placeholder for:
      1) throttling mis-behaving clients (YARN-1546)
      3) mask the access to multiple RMs (YARN-3659)

      We are planning to follow the interceptor pattern like we did in YARN-2884 to generalize the approach and have only dynamically coupling for Federation.

      1. YARN-5413-YARN-2915.v1.patch
        80 kB
        Giovanni Matteo Fumarola
      2. YARN-5413-YARN-2915.v2.patch
        86 kB
        Giovanni Matteo Fumarola
      3. YARN-5413-YARN-2915.v3.patch
        88 kB
        Giovanni Matteo Fumarola

        Activity

        Hide
        subru Subru Krishnan added a comment -

        Thanks Giovanni Matteo Fumarola for addressing all my comments, I have committed this to branch YARN-2915.

        Show
        subru Subru Krishnan added a comment - Thanks Giovanni Matteo Fumarola for addressing all my comments, I have committed this to branch YARN-2915 .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 7 new or modified test files.
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 17m 43s YARN-2915 passed
        +1 compile 10m 58s YARN-2915 passed
        +1 checkstyle 0m 48s YARN-2915 passed
        +1 mvnsite 1m 52s YARN-2915 passed
        +1 mvneclipse 1m 5s YARN-2915 passed
        -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 1 extant Findbugs warnings.
        +1 javadoc 1m 39s YARN-2915 passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 21s the patch passed
        +1 compile 8m 44s the patch passed
        +1 javac 8m 44s the patch passed
        -0 checkstyle 0m 45s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 206 unchanged - 0 fixed = 213 total (was 206)
        +1 mvnsite 1m 43s the patch passed
        +1 mvneclipse 1m 1s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 53s the patch passed
        +1 javadoc 1m 23s the patch passed
        +1 unit 0m 30s hadoop-yarn-api in the patch passed.
        +1 unit 2m 34s hadoop-yarn-common in the patch passed.
        +1 unit 1m 16s hadoop-yarn-server-common in the patch passed.
        +1 unit 0m 20s hadoop-yarn-server-router in the patch passed.
        +1 asflicense 0m 30s The patch does not generate ASF License warnings.
        71m 11s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-5413
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867216/YARN-5413-YARN-2915.v3.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux 3492e4f4da2f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 0a93a32
        Default Java 1.8.0_121
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15885/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15885/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15885/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15885/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 7 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 17m 43s YARN-2915 passed +1 compile 10m 58s YARN-2915 passed +1 checkstyle 0m 48s YARN-2915 passed +1 mvnsite 1m 52s YARN-2915 passed +1 mvneclipse 1m 5s YARN-2915 passed -1 findbugs 0m 59s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 1 extant Findbugs warnings. +1 javadoc 1m 39s YARN-2915 passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 21s the patch passed +1 compile 8m 44s the patch passed +1 javac 8m 44s the patch passed -0 checkstyle 0m 45s hadoop-yarn-project/hadoop-yarn: The patch generated 7 new + 206 unchanged - 0 fixed = 213 total (was 206) +1 mvnsite 1m 43s the patch passed +1 mvneclipse 1m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 53s the patch passed +1 javadoc 1m 23s the patch passed +1 unit 0m 30s hadoop-yarn-api in the patch passed. +1 unit 2m 34s hadoop-yarn-common in the patch passed. +1 unit 1m 16s hadoop-yarn-server-common in the patch passed. +1 unit 0m 20s hadoop-yarn-server-router in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 71m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-5413 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867216/YARN-5413-YARN-2915.v3.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux 3492e4f4da2f 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 0a93a32 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15885/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15885/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15885/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/15885/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        giovanni.fumarola Giovanni Matteo Fumarola added a comment -

        Thanks Subru Krishnan for the feedback. I fixed some of the checkstyle warnings and the missing javadocs.

        Show
        giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Subru Krishnan for the feedback. I fixed some of the checkstyle warnings and the missing javadocs.
        Hide
        subru Subru Krishnan added a comment -

        Thanks Giovanni Matteo Fumarola for the quick turnaround. The patch looks mostly good, can you fix the checkstyle warnings? Also, you missed fixing the class Javadocs.

        Show
        subru Subru Krishnan added a comment - Thanks Giovanni Matteo Fumarola for the quick turnaround. The patch looks mostly good, can you fix the checkstyle warnings? Also, you missed fixing the class Javadocs.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 20s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 6 new or modified test files.
        0 mvndep 0m 39s Maven dependency ordering for branch
        +1 mvninstall 13m 15s YARN-2915 passed
        +1 compile 11m 1s YARN-2915 passed
        +1 checkstyle 0m 44s YARN-2915 passed
        +1 mvnsite 1m 45s YARN-2915 passed
        +1 mvneclipse 1m 21s YARN-2915 passed
        -1 findbugs 0m 54s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 1 extant Findbugs warnings.
        +1 javadoc 1m 25s YARN-2915 passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 19s the patch passed
        +1 compile 8m 49s the patch passed
        +1 javac 8m 49s the patch passed
        -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 21 new + 206 unchanged - 0 fixed = 227 total (was 206)
        +1 mvnsite 2m 4s the patch passed
        +1 mvneclipse 1m 28s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 39s the patch passed
        +1 javadoc 1m 19s the patch passed
        -1 unit 0m 33s hadoop-yarn-api in the patch failed.
        +1 unit 2m 25s hadoop-yarn-common in the patch passed.
        +1 unit 1m 16s hadoop-yarn-server-common in the patch passed.
        +1 unit 0m 27s hadoop-yarn-server-router in the patch passed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        68m 24s



        Reason Tests
        Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue YARN-5413
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867014/YARN-5413-YARN-2915.v2.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux c9981e2131d4 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 0a93a32
        Default Java 1.8.0_121
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15867/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15867/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/15867/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15867/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15867/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 6 new or modified test files. 0 mvndep 0m 39s Maven dependency ordering for branch +1 mvninstall 13m 15s YARN-2915 passed +1 compile 11m 1s YARN-2915 passed +1 checkstyle 0m 44s YARN-2915 passed +1 mvnsite 1m 45s YARN-2915 passed +1 mvneclipse 1m 21s YARN-2915 passed -1 findbugs 0m 54s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in YARN-2915 has 1 extant Findbugs warnings. +1 javadoc 1m 25s YARN-2915 passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 19s the patch passed +1 compile 8m 49s the patch passed +1 javac 8m 49s the patch passed -0 checkstyle 0m 52s hadoop-yarn-project/hadoop-yarn: The patch generated 21 new + 206 unchanged - 0 fixed = 227 total (was 206) +1 mvnsite 2m 4s the patch passed +1 mvneclipse 1m 28s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 39s the patch passed +1 javadoc 1m 19s the patch passed -1 unit 0m 33s hadoop-yarn-api in the patch failed. +1 unit 2m 25s hadoop-yarn-common in the patch passed. +1 unit 1m 16s hadoop-yarn-server-common in the patch passed. +1 unit 0m 27s hadoop-yarn-server-router in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 68m 24s Reason Tests Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue YARN-5413 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12867014/YARN-5413-YARN-2915.v2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux c9981e2131d4 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 0a93a32 Default Java 1.8.0_121 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-YARN-Build/15867/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15867/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15867/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15867/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/15867/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        giovanni.fumarola Giovanni Matteo Fumarola added a comment -

        Thanks Subru Krishnan for the feedback.

        Please add a Bind host for the Router and use it for both client RM and admin protocols.

        Done.

        Can you look at reusing configs from client-RM, say LRUCache size.

        Done, I am using an unique one for the entire router.

        There's a typo, use RM_ADMIN_CLIENT_THREAD_COUNT instead of RM_CLIENT_THREAD_COUNT.

        Done.

        Can you link (@code/@link) the appropriate classes in Javadoc. This has to be done for client-RM also.

        Done.

        I see getInterceptorClassNames/createRequestInterceptorChain is being used again. Can you create a JIRA to refactor this to common class as I feel it can be done using templatization.

        YARN-6572 Refactoring Router services to use common util classes for pipeline creations.

        Show
        giovanni.fumarola Giovanni Matteo Fumarola added a comment - Thanks Subru Krishnan for the feedback. Please add a Bind host for the Router and use it for both client RM and admin protocols. Done. Can you look at reusing configs from client-RM, say LRUCache size. Done, I am using an unique one for the entire router. There's a typo, use RM_ADMIN_CLIENT_THREAD_COUNT instead of RM_CLIENT_THREAD_COUNT. Done. Can you link (@code/@link) the appropriate classes in Javadoc. This has to be done for client-RM also. Done. I see getInterceptorClassNames/createRequestInterceptorChain is being used again. Can you create a JIRA to refactor this to common class as I feel it can be done using templatization. YARN-6572 Refactoring Router services to use common util classes for pipeline creations.
        Hide
        subru Subru Krishnan added a comment -

        Thanks Giovanni Matteo Fumarola for the patch. I looked at it and have a few minor comments:

        • Please add a Bind host for the Router and use it for both client RM and admin protocols.
        • Can you look at reusing configs from client-RM, say LRUCache size.
        • There's a typo, use RM_ADMIN_CLIENT_THREAD_COUNT instead of RM_CLIENT_THREAD_COUNT.
        • Can you link (@code/@link) the appropriate classes in Javadoc. This has to be done for client-RM also.
        • I see getInterceptorClassNames/createRequestInterceptorChain is being used again. Can you create a JIRA to refactor this to common class as I feel it can be done using templatization.
        Show
        subru Subru Krishnan added a comment - Thanks Giovanni Matteo Fumarola for the patch. I looked at it and have a few minor comments: Please add a Bind host for the Router and use it for both client RM and admin protocols. Can you look at reusing configs from client-RM, say LRUCache size. There's a typo, use RM_ADMIN_CLIENT_THREAD_COUNT instead of RM_CLIENT_THREAD_COUNT. Can you link (@code/@link) the appropriate classes in Javadoc. This has to be done for client-RM also. I see getInterceptorClassNames/createRequestInterceptorChain is being used again. Can you create a JIRA to refactor this to common class as I feel it can be done using templatization.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
        0 mvndep 0m 11s Maven dependency ordering for branch
        +1 mvninstall 17m 7s YARN-2915 passed
        +1 compile 10m 2s YARN-2915 passed
        +1 checkstyle 0m 53s YARN-2915 passed
        +1 mvnsite 1m 28s YARN-2915 passed
        +1 mvneclipse 0m 49s YARN-2915 passed
        +1 findbugs 2m 22s YARN-2915 passed
        +1 javadoc 0m 54s YARN-2915 passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 1m 1s the patch passed
        +1 compile 8m 50s the patch passed
        +1 javac 8m 50s the patch passed
        -0 checkstyle 0m 45s hadoop-yarn-project/hadoop-yarn: The patch generated 21 new + 206 unchanged - 0 fixed = 227 total (was 206)
        +1 mvnsite 1m 15s the patch passed
        +1 mvneclipse 0m 48s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 51s the patch passed
        +1 javadoc 0m 54s the patch passed
        -1 unit 0m 30s hadoop-yarn-api in the patch failed.
        +1 unit 1m 20s hadoop-yarn-server-common in the patch passed.
        +1 unit 0m 20s hadoop-yarn-server-router in the patch passed.
        +1 asflicense 0m 28s The patch does not generate ASF License warnings.
        62m 0s



        Reason Tests
        Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ac17dc
        JIRA Issue YARN-5413
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866527/YARN-5413-YARN-2915.v1.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux faca39871a8e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision YARN-2915 / 9ffb5d2
        Default Java 1.8.0_121
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15846/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/15846/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt
        Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15846/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/15846/console
        Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 17m 7s YARN-2915 passed +1 compile 10m 2s YARN-2915 passed +1 checkstyle 0m 53s YARN-2915 passed +1 mvnsite 1m 28s YARN-2915 passed +1 mvneclipse 0m 49s YARN-2915 passed +1 findbugs 2m 22s YARN-2915 passed +1 javadoc 0m 54s YARN-2915 passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 1s the patch passed +1 compile 8m 50s the patch passed +1 javac 8m 50s the patch passed -0 checkstyle 0m 45s hadoop-yarn-project/hadoop-yarn: The patch generated 21 new + 206 unchanged - 0 fixed = 227 total (was 206) +1 mvnsite 1m 15s the patch passed +1 mvneclipse 0m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 51s the patch passed +1 javadoc 0m 54s the patch passed -1 unit 0m 30s hadoop-yarn-api in the patch failed. +1 unit 1m 20s hadoop-yarn-server-common in the patch passed. +1 unit 0m 20s hadoop-yarn-server-router in the patch passed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 62m 0s Reason Tests Failed junit tests hadoop.yarn.conf.TestYarnConfigurationFields Subsystem Report/Notes Docker Image:yetus/hadoop:0ac17dc JIRA Issue YARN-5413 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866527/YARN-5413-YARN-2915.v1.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux faca39871a8e 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision YARN-2915 / 9ffb5d2 Default Java 1.8.0_121 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/15846/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/15846/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-api.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/15846/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/15846/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            giovanni.fumarola Giovanni Matteo Fumarola
            Reporter:
            subru Subru Krishnan
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development