Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5257

Fix unreleased resources and null dereferences

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.9.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The following code contain potential problems:

      Unreleased Resource: Streams	TopCLI.java:738
      Unreleased Resource: Streams	Graph.java:189
      Unreleased Resource: Streams	CgroupsLCEResourcesHandler.java:291
      Unreleased Resource: Streams	UnmanagedAMLauncher.java:195
      Unreleased Resource: Streams	CGroupsHandlerImpl.java:319
      Unreleased Resource: Streams	TrafficController.java:629
      Null Dereference	ApplicationImpl.java:465
      Null Dereference	VisualizeStateMachine.java:52
      Null Dereference	ContainerImpl.java:1089
      Null Dereference	QueueManager.java:219
      Null Dereference	QueueManager.java:232
      Null Dereference	ResourceLocalizationService.java:1016
      Null Dereference	ResourceLocalizationService.java:1023
      Null Dereference	ResourceLocalizationService.java:1040
      Null Dereference	ResourceLocalizationService.java:1052
      Null Dereference	ProcfsBasedProcessTree.java:802
      Null Dereference	TimelineClientImpl.java:639
      Null Dereference	LocalizedResource.java:206
      

        Issue Links

          Activity

          Hide
          yufeigu Yufei Gu added a comment -

          Thanks Robert Kanter for the review and commit.

          Show
          yufeigu Yufei Gu added a comment - Thanks Robert Kanter for the review and commit.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11045 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11045/)
          YARN-5257. Fix unreleased resources and null dereferences (yufeigu via (rkanter: rev 9262797e86453fc04b7ca3710b73b21fcdf9e6b4)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TrafficController.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/TopCLI.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/LocalizedResource.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/VisualizeStateMachine.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11045 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11045/ ) YARN-5257 . Fix unreleased resources and null dereferences (yufeigu via (rkanter: rev 9262797e86453fc04b7ca3710b73b21fcdf9e6b4) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/client/api/impl/TimelineClientImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/application/ApplicationImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/util/ProcfsBasedProcessTree.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/linux/resources/TrafficController.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/TopCLI.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/LocalizedResource.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/VisualizeStateMachine.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/localizer/ResourceLocalizationService.java
          Hide
          rkanter Robert Kanter added a comment -

          Thanks Yufei Gu. Committed to branch-2 and trunk!

          Show
          rkanter Robert Kanter added a comment - Thanks Yufei Gu . Committed to branch-2 and trunk!
          Hide
          rkanter Robert Kanter added a comment -

          +1

          Show
          rkanter Robert Kanter added a comment - +1
          Hide
          yufeigu Yufei Gu added a comment -

          The unit test failure is unrelated.

          Show
          yufeigu Yufei Gu added a comment - The unit test failure is unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 51s Maven dependency ordering for branch
          +1 mvninstall 7m 23s trunk passed
          +1 compile 5m 17s trunk passed
          +1 checkstyle 0m 51s trunk passed
          +1 mvnsite 2m 11s trunk passed
          +1 mvneclipse 1m 22s trunk passed
          +1 findbugs 3m 7s trunk passed
          +1 javadoc 1m 56s trunk passed
          0 mvndep 0m 14s Maven dependency ordering for patch
          +1 mvninstall 1m 46s the patch passed
          +1 compile 6m 9s the patch passed
          +1 javac 6m 9s the patch passed
          +1 checkstyle 1m 1s the patch passed
          +1 mvnsite 2m 25s the patch passed
          +1 mvneclipse 1m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 4m 6s the patch passed
          +1 javadoc 1m 53s the patch passed
          -1 unit 2m 55s hadoop-yarn-common in the patch failed.
          +1 unit 15m 1s hadoop-yarn-server-nodemanager in the patch passed.
          +1 unit 17m 22s hadoop-yarn-client in the patch passed.
          +1 unit 0m 48s hadoop-yarn-applications-unmanaged-am-launcher in the patch passed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          88m 8s



          Reason Tests
          Failed junit tests hadoop.yarn.client.api.impl.TestTimelineClientV2Impl



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue YARN-5257
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842703/YARN-5257.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 436e53433c3c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4c38f11
          Default Java 1.8.0_111
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/14253/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14253/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/14253/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 51s Maven dependency ordering for branch +1 mvninstall 7m 23s trunk passed +1 compile 5m 17s trunk passed +1 checkstyle 0m 51s trunk passed +1 mvnsite 2m 11s trunk passed +1 mvneclipse 1m 22s trunk passed +1 findbugs 3m 7s trunk passed +1 javadoc 1m 56s trunk passed 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 46s the patch passed +1 compile 6m 9s the patch passed +1 javac 6m 9s the patch passed +1 checkstyle 1m 1s the patch passed +1 mvnsite 2m 25s the patch passed +1 mvneclipse 1m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 4m 6s the patch passed +1 javadoc 1m 53s the patch passed -1 unit 2m 55s hadoop-yarn-common in the patch failed. +1 unit 15m 1s hadoop-yarn-server-nodemanager in the patch passed. +1 unit 17m 22s hadoop-yarn-client in the patch passed. +1 unit 0m 48s hadoop-yarn-applications-unmanaged-am-launcher in the patch passed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 88m 8s Reason Tests Failed junit tests hadoop.yarn.client.api.impl.TestTimelineClientV2Impl Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue YARN-5257 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842703/YARN-5257.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 436e53433c3c 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4c38f11 Default Java 1.8.0_111 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/14253/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/14253/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/14253/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

            People

            • Assignee:
              yufeigu Yufei Gu
              Reporter:
              yufeigu Yufei Gu
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development