Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-5098

Yarn Application log Aggreagation fails due to NM can not get correct HDFS delegation token

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: yarn
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Environment : HA cluster

      Yarn application logs for long running application could not be gathered because Nodemanager failed to talk to HDFS with below error.

      2016-05-16 18:18:28,533 INFO  logaggregation.AppLogAggregatorImpl (AppLogAggregatorImpl.java:finishLogAggregation(555)) - Application just finished : application_1463170334122_0002
      2016-05-16 18:18:28,545 WARN  ipc.Client (Client.java:run(705)) - Exception encountered while connecting to the server :
      org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.security.token.SecretManager$InvalidToken): token (HDFS_DELEGATION_TOKEN token 171 for hrt_qa) can't be found in cache
              at org.apache.hadoop.security.SaslRpcClient.saslConnect(SaslRpcClient.java:375)
              at org.apache.hadoop.ipc.Client$Connection.setupSaslConnection(Client.java:583)
              at org.apache.hadoop.ipc.Client$Connection.access$1900(Client.java:398)
              at org.apache.hadoop.ipc.Client$Connection$2.run(Client.java:752)
              at org.apache.hadoop.ipc.Client$Connection$2.run(Client.java:748)
              at java.security.AccessController.doPrivileged(Native Method)
              at javax.security.auth.Subject.doAs(Subject.java:422)
              at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1719)
              at org.apache.hadoop.ipc.Client$Connection.setupIOstreams(Client.java:747)
              at org.apache.hadoop.ipc.Client$Connection.access$3100(Client.java:398)
              at org.apache.hadoop.ipc.Client.getConnection(Client.java:1597)
              at org.apache.hadoop.ipc.Client.call(Client.java:1439)
              at org.apache.hadoop.ipc.Client.call(Client.java:1386)
              at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:240)
              at com.sun.proxy.$Proxy83.getServerDefaults(Unknown Source)
              at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB.getServerDefaults(ClientNamenodeProtocolTranslatorPB.java:282)
              at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
              at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
              at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
              at java.lang.reflect.Method.invoke(Method.java:498)
              at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:256)
              at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:104)
              at com.sun.proxy.$Proxy84.getServerDefaults(Unknown Source)
              at org.apache.hadoop.hdfs.DFSClient.getServerDefaults(DFSClient.java:1018)
              at org.apache.hadoop.fs.Hdfs.getServerDefaults(Hdfs.java:156)
              at org.apache.hadoop.fs.AbstractFileSystem.create(AbstractFileSystem.java:550)
              at org.apache.hadoop.fs.FileContext$3.next(FileContext.java:687)
      
      1. YARN-5098.1.patch
        10 kB
        Jian He
      2. YARN-5098.1.patch
        8 kB
        Jian He
      3. YARN-5098.2.patch
        10 kB
        Jian He
      4. YARN-5098.3.patch
        10 kB
        Jian He

        Issue Links

          Activity

          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Some useful discussion related to delegation token done in YARN-4783 which can be referred. But this JIRA has closed as wont fix.
          Yesha Vora can you check it once YARN-4783?

          Show
          rohithsharma Rohith Sharma K S added a comment - Some useful discussion related to delegation token done in YARN-4783 which can be referred. But this JIRA has closed as wont fix. Yesha Vora can you check it once YARN-4783 ?
          Hide
          jlowe Jason Lowe added a comment -

          The original description of this JIRA showed that the HDFS token lifespan was configured to a maximum of half a day, so it's not surprising that the nodemanagers cannot use those tokens to successfully aggregate the application logs 3 days later. Either the HDFS tokens need a longer max lifespan for apps like this or the nodemanager needs to be updated with a new HDFS token to use for log aggregation. YARN-2704 added the ability to do the latter, but I believe it requires a few things to work properly:

          • the RM needs to be configured as a proxy user so it can request tokens on behalf of other users
          • the app needs to be submitted without an HDFS token so the RM will acquire and manage it directly on the app's behalf

          Are these conditions true for this scenario? cc: Jian He

          Show
          jlowe Jason Lowe added a comment - The original description of this JIRA showed that the HDFS token lifespan was configured to a maximum of half a day, so it's not surprising that the nodemanagers cannot use those tokens to successfully aggregate the application logs 3 days later. Either the HDFS tokens need a longer max lifespan for apps like this or the nodemanager needs to be updated with a new HDFS token to use for log aggregation. YARN-2704 added the ability to do the latter, but I believe it requires a few things to work properly: the RM needs to be configured as a proxy user so it can request tokens on behalf of other users the app needs to be submitted without an HDFS token so the RM will acquire and manage it directly on the app's behalf Are these conditions true for this scenario? cc: Jian He
          Hide
          jianhe Jian He added a comment -

          the app needs to be submitted without an HDFS token so the RM will acquire and manage it directly on the app's behalf

          Btw, this is not necessary, RM will try to get the token on app's behalf if the token is going to expire, regardless whether the app provided the token or not in the first place.

          I debugged this, with YARN-2704, in normal case, RM should get the new token and distribute it to NM if the token is going to expire. The problem here is that RM gets shutdown for a long time during which the token expired. After RM restart, RM tries to recover the app and renew the token. Obviously the renew will fail because the token is expired, and so the log aggregation failed when the app completed.

          One solution in my mind is to let RM request a new token and distribute it to NM, if the token renewal fails on app recovery. Right now the failure is just ignored and continue.

          Show
          jianhe Jian He added a comment - the app needs to be submitted without an HDFS token so the RM will acquire and manage it directly on the app's behalf Btw, this is not necessary, RM will try to get the token on app's behalf if the token is going to expire, regardless whether the app provided the token or not in the first place. I debugged this, with YARN-2704 , in normal case, RM should get the new token and distribute it to NM if the token is going to expire. The problem here is that RM gets shutdown for a long time during which the token expired. After RM restart, RM tries to recover the app and renew the token. Obviously the renew will fail because the token is expired, and so the log aggregation failed when the app completed. One solution in my mind is to let RM request a new token and distribute it to NM, if the token renewal fails on app recovery. Right now the failure is just ignored and continue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 5m 59s trunk passed
          +1 compile 0m 28s trunk passed
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 52s trunk passed
          +1 javadoc 0m 22s trunk passed
          +1 mvninstall 0m 28s the patch passed
          +1 compile 0m 26s the patch passed
          +1 javac 0m 26s the patch passed
          -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 7 new + 89 unchanged - 0 fixed = 96 total (was 89)
          +1 mvnsite 0m 31s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 1s the patch passed
          +1 javadoc 0m 19s the patch passed
          -1 unit 34m 17s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 15s Patch does not generate ASF License warnings.
          47m 25s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestContainerResourceUsage
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805102/YARN-5098.1.patch
          JIRA Issue YARN-5098
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 30da2c14c7bd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 757050f
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11589/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11589/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11589/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11589/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11589/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 5m 59s trunk passed +1 compile 0m 28s trunk passed +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 52s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 28s the patch passed +1 compile 0m 26s the patch passed +1 javac 0m 26s the patch passed -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 7 new + 89 unchanged - 0 fixed = 96 total (was 89) +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 1s the patch passed +1 javadoc 0m 19s the patch passed -1 unit 34m 17s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s Patch does not generate ASF License warnings. 47m 25s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestContainerResourceUsage   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12805102/YARN-5098.1.patch JIRA Issue YARN-5098 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 30da2c14c7bd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 757050f Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11589/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11589/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11589/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11589/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11589/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Fix checkstyle and unit test issues.

          The patch looks good overall, few comments

          • Overall, I think we can simplify this code if we simply always manage our own tokens for localization and log-aggregation for long-running applications / services. Today, it's too complicated: for the first day, we use the user's token T, second day we get a new token T' but share it for all the apps originally sharing T, after RM restart we use a new token T'' which is different for each of the apps originally sharing T. We can simplify this by always managing it ourselves and managing them per-user!
          • There are a few unused imports.
          • Unrelated to the patch, but let's rename requestNewHdfsDelegationToken() -> requestNewHdfsDelegationTokenAsProxyUser()
          • Why this change?
            -    LOG.info("Renewed delegation-token= [" + dttr + "], for "
            -        + dttr.referringAppIds);
            +    LOG.info("Renewed delegation-token= [" + dttr + "]");
            
          • Testcase
            • Should use the same user for both tokens?
            • Add a comment saying the rm2 is simulating RM restart
            • Can we rewrite the following, it is a little confusing
                          if (dttr.token.equals(expectedToken)) {
                            secondRenewInvoked = true;
                            super.renewToken(dttr);
                          } else {
                            firstRenewInvoked = true;
                            throw new InvalidToken("Failed to renew");
                          }
              

              to

                          if (dttr.token.equals(updatedtoken)) {
                            super.renewToken(dttr);
                          } else if (dttr.token.equals(originalToken) {
                            throw new InvalidToken("Failed to renew");
                          } else {
                            throw new IOException("Unexpected");
                          }
              

              and assert that firstRenewInvoked and secondRenewInvoked are set?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Fix checkstyle and unit test issues. The patch looks good overall, few comments Overall, I think we can simplify this code if we simply always manage our own tokens for localization and log-aggregation for long-running applications / services. Today, it's too complicated: for the first day, we use the user's token T, second day we get a new token T' but share it for all the apps originally sharing T, after RM restart we use a new token T'' which is different for each of the apps originally sharing T. We can simplify this by always managing it ourselves and managing them per-user! There are a few unused imports. Unrelated to the patch, but let's rename requestNewHdfsDelegationToken() -> requestNewHdfsDelegationTokenAsProxyUser() Why this change? - LOG.info( "Renewed delegation-token= [" + dttr + "], for " - + dttr.referringAppIds); + LOG.info( "Renewed delegation-token= [" + dttr + "]" ); Testcase Should use the same user for both tokens? Add a comment saying the rm2 is simulating RM restart Can we rewrite the following, it is a little confusing if (dttr.token.equals(expectedToken)) { secondRenewInvoked = true ; super .renewToken(dttr); } else { firstRenewInvoked = true ; throw new InvalidToken( "Failed to renew" ); } to if (dttr.token.equals(updatedtoken)) { super .renewToken(dttr); } else if (dttr.token.equals(originalToken) { throw new InvalidToken( "Failed to renew" ); } else { throw new IOException( "Unexpected" ); } and assert that firstRenewInvoked and secondRenewInvoked are set?
          Hide
          jianhe Jian He added a comment -

          Overall, I think we can simplify this code i

          created YARN-5175

          Why this change?

          The 'dttr' already prints the dttr.referringAppIds, so it duplicated

          updated the patch

          Show
          jianhe Jian He added a comment - Overall, I think we can simplify this code i created YARN-5175 Why this change? The 'dttr' already prints the dttr.referringAppIds, so it duplicated updated the patch
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 10s trunk passed
          +1 compile 0m 27s trunk passed
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 0m 31s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 52s trunk passed
          +1 javadoc 0m 21s trunk passed
          +1 mvninstall 0m 27s the patch passed
          +1 compile 0m 25s the patch passed
          +1 javac 0m 25s the patch passed
          -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 7 new + 88 unchanged - 0 fixed = 95 total (was 88)
          +1 mvnsite 0m 31s the patch passed
          +1 mvneclipse 0m 9s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 3s the patch passed
          +1 javadoc 0m 20s the patch passed
          -1 unit 35m 49s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 15s Patch does not generate ASF License warnings.
          48m 59s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806746/YARN-5098.1.patch
          JIRA Issue YARN-5098
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 921a56fd862a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 21890c4
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11740/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11740/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11740/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11740/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11740/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 10s trunk passed +1 compile 0m 27s trunk passed +1 checkstyle 0m 20s trunk passed +1 mvnsite 0m 31s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 52s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 27s the patch passed +1 compile 0m 25s the patch passed +1 javac 0m 25s the patch passed -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 7 new + 88 unchanged - 0 fixed = 95 total (was 88) +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 9s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 3s the patch passed +1 javadoc 0m 20s the patch passed -1 unit 35m 49s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s Patch does not generate ASF License warnings. 48m 59s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.security.TestClientToAMTokens   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806746/YARN-5098.1.patch JIRA Issue YARN-5098 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 921a56fd862a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 21890c4 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11740/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11740/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11740/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11740/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11740/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          TestClientToAMTokens is tracked by YARN-5163
          The other tests are related to HADOOP-12687 and passing locally

          Show
          jianhe Jian He added a comment - TestClientToAMTokens is tracked by YARN-5163 The other tests are related to HADOOP-12687 and passing locally
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Okay, the latest patch looks good to me except for the checkstyle warnings. Are all or some of them addressable?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Okay, the latest patch looks good to me except for the checkstyle warnings. Are all or some of them addressable?
          Hide
          jianhe Jian He added a comment -

          Fix the check style warnings. Left the ones that are invalid.

          Show
          jianhe Jian He added a comment - Fix the check style warnings. Left the ones that are invalid.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 20s trunk passed
          +1 compile 0m 37s trunk passed
          +1 checkstyle 0m 25s trunk passed
          +1 mvnsite 0m 48s trunk passed
          +1 mvneclipse 0m 11s trunk passed
          +1 findbugs 1m 8s trunk passed
          +1 javadoc 0m 20s trunk passed
          +1 mvninstall 0m 29s the patch passed
          +1 compile 0m 27s the patch passed
          +1 javac 0m 27s the patch passed
          -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 88 unchanged - 0 fixed = 91 total (was 88)
          +1 mvnsite 0m 31s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 6s the patch passed
          +1 javadoc 0m 18s the patch passed
          -1 unit 34m 15s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          49m 39s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.yarn.server.resourcemanager.TestRMRestart
            hadoop.yarn.server.resourcemanager.TestRMAdminService
            hadoop.yarn.server.resourcemanager.TestClientRMTokens



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807515/YARN-5098.2.patch
          JIRA Issue YARN-5098
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 39d779f2325b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0bc05e4
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11798/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11798/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11798/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11798/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11798/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 20s trunk passed +1 compile 0m 37s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 48s trunk passed +1 mvneclipse 0m 11s trunk passed +1 findbugs 1m 8s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 29s the patch passed +1 compile 0m 27s the patch passed +1 javac 0m 27s the patch passed -1 checkstyle 0m 19s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 3 new + 88 unchanged - 0 fixed = 91 total (was 88) +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 6s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 34m 15s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 49m 39s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestRMAdminService   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807515/YARN-5098.2.patch JIRA Issue YARN-5098 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 39d779f2325b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0bc05e4 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11798/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11798/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11798/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11798/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11798/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          fixed the long lines. the warning about whitespace is invalid. that line does not have whitespace in the end.

          Show
          jianhe Jian He added a comment - fixed the long lines. the warning about whitespace is invalid. that line does not have whitespace in the end.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 21s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 44s trunk passed
          +1 compile 0m 33s trunk passed
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 37s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 1m 4s trunk passed
          +1 javadoc 0m 22s trunk passed
          +1 mvninstall 0m 33s the patch passed
          +1 compile 0m 31s the patch passed
          +1 javac 0m 31s the patch passed
          -1 checkstyle 0m 21s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 88 unchanged - 0 fixed = 89 total (was 88)
          +1 mvnsite 0m 36s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 7s the patch passed
          +1 javadoc 0m 18s the patch passed
          -1 unit 35m 41s hadoop-yarn-server-resourcemanager in the patch failed.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          50m 24s



          Reason Tests
          Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:2c91fd8
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807827/YARN-5098.3.patch
          JIRA Issue YARN-5098
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 08f59fc3b597 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 97e2449
          Default Java 1.8.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11826/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/11826/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11826/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11826/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11826/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 44s trunk passed +1 compile 0m 33s trunk passed +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 4s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 33s the patch passed +1 compile 0m 31s the patch passed +1 javac 0m 31s the patch passed -1 checkstyle 0m 21s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 1 new + 88 unchanged - 0 fixed = 89 total (was 88) +1 mvnsite 0m 36s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 7s the patch passed +1 javadoc 0m 18s the patch passed -1 unit 35m 41s hadoop-yarn-server-resourcemanager in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 50m 24s Reason Tests Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807827/YARN-5098.3.patch JIRA Issue YARN-5098 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 08f59fc3b597 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 97e2449 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11826/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/11826/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/11826/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11826/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11826/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          jianhe Jian He added a comment -

          the last checkstyle warning is invalid

          Show
          jianhe Jian He added a comment - the last checkstyle warning is invalid
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Okay, looks good to me, the tests are failing because of the same old Jenkins host-name / security issue.

          +1, checking this in.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Okay, looks good to me, the tests are failing because of the same old Jenkins host-name / security issue. +1, checking this in.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #9907 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9907/)
          YARN-5098. Fixed ResourceManager's DelegationTokenRenewer to replace (vinodkv: rev f10ebc67f57a4a2e3cc916c41154ab9b6a4635c9)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestDelegationTokenRenewer.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9907 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9907/ ) YARN-5098 . Fixed ResourceManager's DelegationTokenRenewer to replace (vinodkv: rev f10ebc67f57a4a2e3cc916c41154ab9b6a4635c9) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/security/TestDelegationTokenRenewer.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/security/DelegationTokenRenewer.java
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Committed this to trunk and branch-2. Thanks Jian!

          Also pulled this into 2.8.0 given that it's a bug fix.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Committed this to trunk and branch-2. Thanks Jian! Also pulled this into 2.8.0 given that it's a bug fix.

            People

            • Assignee:
              jianhe Jian He
              Reporter:
              yeshavora Yesha Vora
            • Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development