Details

    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Hide
      This breaks rolling upgrades because it changes the major version of the NM state store schema. Therefore when a new NM comes up on an old state store it crashes.

      The state store versions for this change have been updated in YARN-6798.
      Show
      This breaks rolling upgrades because it changes the major version of the NM state store schema. Therefore when a new NM comes up on an old state store it crashes. The state store versions for this change have been updated in YARN-6798 .

      Description

      This JIRA is about extending the NMStateStore to save queued container information whenever a new container is added to the NM queue.
      It also removes the information from the state store when the queued container starts its execution.

      1. YARN-5049.001.patch
        15 kB
        Konstantinos Karanasos
      2. YARN-5049.002.patch
        16 kB
        Konstantinos Karanasos
      3. YARN-5049.003.patch
        16 kB
        Konstantinos Karanasos
      4. YARN-5049-addendum.branch-2.001.patch
        2 kB
        Arun Suresh

        Issue Links

          Activity

          Hide
          asuresh Arun Suresh added a comment -

          Thanks for the rev Subru Krishnan and for raising the issue Varun Saxena.
          Committed the addendum to branch-2, branch-2.9 and branch-2.9.0

          Show
          asuresh Arun Suresh added a comment - Thanks for the rev Subru Krishnan and for raising the issue Varun Saxena . Committed the addendum to branch-2, branch-2.9 and branch-2.9.0
          Hide
          subru Subru Krishnan added a comment -

          +1 to the addendum patch. Thanks Varun Saxena for reporting it and Arun Suresh for fixing it. The test failure is unrelated and tracked in YARN-7478.

          Show
          subru Subru Krishnan added a comment - +1 to the addendum patch. Thanks Varun Saxena for reporting it and Arun Suresh for fixing it. The test failure is unrelated and tracked in YARN-7478 .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 25m 29s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                branch-2 Compile Tests
          +1 mvninstall 13m 22s branch-2 passed
          +1 compile 0m 44s branch-2 passed
          +1 checkstyle 0m 18s branch-2 passed
          +1 mvnsite 0m 34s branch-2 passed
          +1 findbugs 0m 56s branch-2 passed
          +1 javadoc 0m 22s branch-2 passed
                Patch Compile Tests
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 42s the patch passed
          +1 javac 0m 42s the patch passed
          +1 checkstyle 0m 14s the patch passed
          +1 mvnsite 0m 29s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 8s the patch passed
          +1 javadoc 0m 18s the patch passed
                Other Tests
          -1 unit 15m 31s hadoop-yarn-server-nodemanager in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          61m 55s



          Reason Tests
          Failed junit tests TEST-cetest



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:17213a0
          JIRA Issue YARN-5049
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897239/YARN-5049-addendum.branch-2.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux 256ab345af97 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 5cd92ed
          maven version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00)
          Default Java 1.7.0_151
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/18452/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/18452/testReport/
          Max. process+thread count 156 (vs. ulimit of 5000)
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/18452/console
          Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 25m 29s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-2 Compile Tests +1 mvninstall 13m 22s branch-2 passed +1 compile 0m 44s branch-2 passed +1 checkstyle 0m 18s branch-2 passed +1 mvnsite 0m 34s branch-2 passed +1 findbugs 0m 56s branch-2 passed +1 javadoc 0m 22s branch-2 passed       Patch Compile Tests +1 mvninstall 0m 31s the patch passed +1 compile 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 8s the patch passed +1 javadoc 0m 18s the patch passed       Other Tests -1 unit 15m 31s hadoop-yarn-server-nodemanager in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 61m 55s Reason Tests Failed junit tests TEST-cetest Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:17213a0 JIRA Issue YARN-5049 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12897239/YARN-5049-addendum.branch-2.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 256ab345af97 4.4.0-64-generic #85-Ubuntu SMP Mon Feb 20 11:50:30 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision branch-2 / 5cd92ed maven version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) Default Java 1.7.0_151 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/18452/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/18452/testReport/ Max. process+thread count 156 (vs. ulimit of 5000) modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/18452/console Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Attaching addendum patch for branch-2

          Show
          asuresh Arun Suresh added a comment - Attaching addendum patch for branch-2
          Hide
          asuresh Arun Suresh added a comment -

          Reopening, since during the branch-2 merge, one line was duplicated.

          Show
          asuresh Arun Suresh added a comment - Reopening, since during the branch-2 merge, one line was duplicated.
          Hide
          asuresh Arun Suresh added a comment -

          Committed to branch-2 as well

          Show
          asuresh Arun Suresh added a comment - Committed to branch-2 as well
          Hide
          asuresh Arun Suresh added a comment -

          Re-opening for branch-2 commit

          Show
          asuresh Arun Suresh added a comment - Re-opening for branch-2 commit
          Hide
          asuresh Arun Suresh added a comment -

          Reverted from branch-2. and re-targeting for 3.x until we find a proper solution.

          Show
          asuresh Arun Suresh added a comment - Reverted from branch-2. and re-targeting for 3.x until we find a proper solution.
          Hide
          asuresh Arun Suresh added a comment -

          Thanks for clarifying Jason Lowe. Had an offline discussion with Konstantinos Karanasos. Will revert from branch-2.
          I also like the idea of lazily updating the version number. Will think about it a bit and raise a JIRA

          Show
          asuresh Arun Suresh added a comment - Thanks for clarifying Jason Lowe . Had an offline discussion with Konstantinos Karanasos . Will revert from branch-2. I also like the idea of lazily updating the version number. Will think about it a bit and raise a JIRA
          Hide
          jlowe Jason Lowe added a comment -

          The major version should change when an older version of the software should not try to use the state store. If we only bump the minor version then the old software will happily use the state store because all schemas with the same major version are "compatible."

          So we need to think about two scenarios:

          1. What happens if we upgrade to a newer version of software that sees the old schema without these keys?
          2. What happens if we downgrade from a newer version of software with these keys to an older one that doesn't know about them?

          For #1 I think it's easy. Old software doesn't support queued containers, so those keys won't be there. No queued containers means nothing to restore for that subsystem, so we should be fine during recovery.

          For #2 it's more complicated. If we have queued containers then do a rolling downgrade then we could end up losing those containers because the old software doesn't support them. Therefore I think we can't support rolling downgrades as soon as queued containers are used.

          So it looks like the proper way forward is to bump the major version because of the lack of rolling downgrade support. IMHO the version number should be updated "lazily," meaning if we're currently on schema version 1 but never use queued containers then it stays at version 1. If we're on version 1 when a queued container needs to be saved in the state store then we update the major version at that time. This has a number of important benefits to the end user:

          • No need for a "migration script" that needs to be run manually
          • Users don't lose the ability to do a rolling downgrade until they leverage the functionality that broke the ability to downgrade.

          This matches the precedent set by the container ID epoch change for RM work-preserving restart in 2.6. 2.5 apps were supported on 2.6 until the user did a work-preserving RM restart, since that's what caused the epoch ID to be added to the container ID, breaking any 2.5 app that tried to parse a container ID.

          Show
          jlowe Jason Lowe added a comment - The major version should change when an older version of the software should not try to use the state store. If we only bump the minor version then the old software will happily use the state store because all schemas with the same major version are "compatible." So we need to think about two scenarios: What happens if we upgrade to a newer version of software that sees the old schema without these keys? What happens if we downgrade from a newer version of software with these keys to an older one that doesn't know about them? For #1 I think it's easy. Old software doesn't support queued containers, so those keys won't be there. No queued containers means nothing to restore for that subsystem, so we should be fine during recovery. For #2 it's more complicated. If we have queued containers then do a rolling downgrade then we could end up losing those containers because the old software doesn't support them. Therefore I think we can't support rolling downgrades as soon as queued containers are used. So it looks like the proper way forward is to bump the major version because of the lack of rolling downgrade support. IMHO the version number should be updated "lazily," meaning if we're currently on schema version 1 but never use queued containers then it stays at version 1. If we're on version 1 when a queued container needs to be saved in the state store then we update the major version at that time. This has a number of important benefits to the end user: No need for a "migration script" that needs to be run manually Users don't lose the ability to do a rolling downgrade until they leverage the functionality that broke the ability to downgrade. This matches the precedent set by the container ID epoch change for RM work-preserving restart in 2.6. 2.5 apps were supported on 2.6 until the user did a work-preserving RM restart, since that's what caused the epoch ID to be added to the container ID, breaking any 2.5 app that tried to parse a container ID.
          Hide
          asuresh Arun Suresh added a comment -

          Thanks for brining this up Jason Lowe..
          I am now wondering what the criteria is for updating the major and minor version number of the NMLevelDBStateStore.
          This particular patch adds a new key suffix /queued to the state store. Thus, the schema has changed but the old schema is still readable by the new version of NM. But roll back of the NM to the old version will not be possible (if it has queued atleast 1 container the container is in the queued at the time of the rollback)
          Given the above, I feel this warrants just a minor version (instead of a major version update which is what this patch included), in which case the exception you specified will not be thrown (since minor versions are compatible).
          If you agree, I can update the patch (or create a new JIRA) to just modify the minor version, and everything should be fine... else I will revert the patch from branch-2 until we have a migration script.

          Show
          asuresh Arun Suresh added a comment - Thanks for brining this up Jason Lowe .. I am now wondering what the criteria is for updating the major and minor version number of the NMLevelDBStateStore . This particular patch adds a new key suffix /queued to the state store. Thus, the schema has changed but the old schema is still readable by the new version of NM. But roll back of the NM to the old version will not be possible (if it has queued atleast 1 container the container is in the queued at the time of the rollback) Given the above, I feel this warrants just a minor version (instead of a major version update which is what this patch included), in which case the exception you specified will not be thrown (since minor versions are compatible). If you agree, I can update the patch (or create a new JIRA) to just modify the minor version, and everything should be fine... else I will revert the patch from branch-2 until we have a migration script.
          Hide
          jlowe Jason Lowe added a comment -

          Sorry for getting here late, as I just ran into this by accident. This breaks rolling upgrades because it changes the major version of the NM state store schema. Therefore when a new NM comes up on an old state store it crashes like this:

          2016-08-18 19:37:26,713 INFO  [main] service.AbstractService (AbstractService.java:noteFailure(272)) - Service NodeManager failed in state INITED; cause: org.apache.hadoop.service.ServiceStateException: java.io.IOException: Incompatible version for NM state: expecting NM state version 2.0, but loading version 1.0
          org.apache.hadoop.service.ServiceStateException: java.io.IOException: Incompatible version for NM state: expecting NM state version 2.0, but loading version 1.0
          	at org.apache.hadoop.service.ServiceStateException.convert(ServiceStateException.java:59)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:172)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartRecoveryStore(NodeManager.java:236)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:300)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManager(NodeManager.java:762)
          	at org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java:823)
          Caused by: java.io.IOException: Incompatible version for NM state: expecting NM state version 2.0, but loading version 1.0
          	at org.apache.hadoop.yarn.server.nodemanager.recovery.NMLeveldbStateStoreService.checkVersion(NMLeveldbStateStoreService.java:1226)
          	at org.apache.hadoop.yarn.server.nodemanager.recovery.NMLeveldbStateStoreService.initStorage(NMLeveldbStateStoreService.java:1085)
          	at org.apache.hadoop.yarn.server.nodemanager.recovery.NMStateStoreService.serviceInit(NMStateStoreService.java:249)
          	at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163)
          	... 5 more
          

          Breaking the compatibility, while annoying, is not terrible if this just went into trunk. However this was also put into branch-2, therefore this breaks rolling upgrades from 2.8->2.9. As such this should be reverted from branch-2 until there's a migration path from schema 1 to schema 2 that doesn't break the NM startup.

          Show
          jlowe Jason Lowe added a comment - Sorry for getting here late, as I just ran into this by accident. This breaks rolling upgrades because it changes the major version of the NM state store schema. Therefore when a new NM comes up on an old state store it crashes like this: 2016-08-18 19:37:26,713 INFO [main] service.AbstractService (AbstractService.java:noteFailure(272)) - Service NodeManager failed in state INITED; cause: org.apache.hadoop.service.ServiceStateException: java.io.IOException: Incompatible version for NM state: expecting NM state version 2.0, but loading version 1.0 org.apache.hadoop.service.ServiceStateException: java.io.IOException: Incompatible version for NM state: expecting NM state version 2.0, but loading version 1.0 at org.apache.hadoop.service.ServiceStateException.convert(ServiceStateException.java:59) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:172) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartRecoveryStore(NodeManager.java:236) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.serviceInit(NodeManager.java:300) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.initAndStartNodeManager(NodeManager.java:762) at org.apache.hadoop.yarn.server.nodemanager.NodeManager.main(NodeManager.java:823) Caused by: java.io.IOException: Incompatible version for NM state: expecting NM state version 2.0, but loading version 1.0 at org.apache.hadoop.yarn.server.nodemanager.recovery.NMLeveldbStateStoreService.checkVersion(NMLeveldbStateStoreService.java:1226) at org.apache.hadoop.yarn.server.nodemanager.recovery.NMLeveldbStateStoreService.initStorage(NMLeveldbStateStoreService.java:1085) at org.apache.hadoop.yarn.server.nodemanager.recovery.NMStateStoreService.serviceInit(NMStateStoreService.java:249) at org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) ... 5 more Breaking the compatibility, while annoying, is not terrible if this just went into trunk. However this was also put into branch-2, therefore this breaks rolling upgrades from 2.8->2.9. As such this should be reverted from branch-2 until there's a migration path from schema 1 to schema 2 that doesn't break the NM startup.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9749 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9749/)
          YARN-5049. Extend NMStateStore to save queued container information. (arun suresh: rev d464f4d1c4dec483852fc8c0496787cba0af8f57)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMStateStoreService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMNullStateStoreService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/queuing/QueuingContainerManagerImpl.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/recovery/TestNMLeveldbStateStoreService.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMMemoryStateStoreService.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9749 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9749/ ) YARN-5049 . Extend NMStateStore to save queued container information. (arun suresh: rev d464f4d1c4dec483852fc8c0496787cba0af8f57) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMStateStoreService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMNullStateStoreService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/ContainerManagerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMLeveldbStateStoreService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/queuing/QueuingContainerManagerImpl.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/recovery/TestNMLeveldbStateStoreService.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/recovery/NMMemoryStateStoreService.java
          Hide
          asuresh Arun Suresh added a comment -

          +1, Committed this to trunk..

          Show
          asuresh Arun Suresh added a comment - +1, Committed this to trunk..
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Jenkins just completed. There is a single checkstyle issue that is not related to my code, so I think we are good.

          Show
          kkaranasos Konstantinos Karanasos added a comment - Jenkins just completed. There is a single checkstyle issue that is not related to my code, so I think we are good.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 6m 48s trunk passed
          +1 compile 0m 23s trunk passed with JDK v1.8.0_91
          +1 compile 0m 27s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 0m 30s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 53s trunk passed
          +1 javadoc 0m 18s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 25s the patch passed
          +1 compile 0m 22s the patch passed with JDK v1.8.0_91
          +1 javac 0m 22s the patch passed
          +1 compile 0m 26s the patch passed with JDK v1.7.0_95
          +1 javac 0m 26s the patch passed
          -1 checkstyle 0m 16s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 153 unchanged - 0 fixed = 154 total (was 153)
          +1 mvnsite 0m 25s the patch passed
          +1 mvneclipse 0m 10s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 9s the patch passed
          +1 javadoc 0m 20s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 22s the patch passed with JDK v1.7.0_95
          +1 unit 11m 32s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91.
          +1 unit 11m 57s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          39m 11s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803498/YARN-5049.003.patch
          JIRA Issue YARN-5049
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8e9ab3dbc585 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 7251bb9
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11423/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11423/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11423/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 48s trunk passed +1 compile 0m 23s trunk passed with JDK v1.8.0_91 +1 compile 0m 27s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 30s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 53s trunk passed +1 javadoc 0m 18s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 21s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 25s the patch passed +1 compile 0m 22s the patch passed with JDK v1.8.0_91 +1 javac 0m 22s the patch passed +1 compile 0m 26s the patch passed with JDK v1.7.0_95 +1 javac 0m 26s the patch passed -1 checkstyle 0m 16s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 153 unchanged - 0 fixed = 154 total (was 153) +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 9s the patch passed +1 javadoc 0m 20s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 22s the patch passed with JDK v1.7.0_95 +1 unit 11m 32s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91. +1 unit 11m 57s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 39m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803498/YARN-5049.003.patch JIRA Issue YARN-5049 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8e9ab3dbc585 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7251bb9 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11423/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11423/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11423/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Looks good..
          +1 pending Jenkins..

          Show
          asuresh Arun Suresh added a comment - Looks good.. +1 pending Jenkins..
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Thanks for the review, Arun Suresh!

          Fixed the VERSION problem you mentioned and attaching new version of the patch.

          Show
          kkaranasos Konstantinos Karanasos added a comment - Thanks for the review, Arun Suresh ! Fixed the VERSION problem you mentioned and attaching new version of the patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 22s trunk passed
          +1 compile 0m 32s trunk passed with JDK v1.8.0_91
          +1 compile 0m 32s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 22s trunk passed
          +1 mvnsite 0m 34s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 1m 0s trunk passed
          +1 javadoc 0m 24s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 25s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 30s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.8.0_91
          +1 javac 0m 28s the patch passed
          +1 compile 0m 28s the patch passed with JDK v1.7.0_95
          +1 javac 0m 28s the patch passed
          -1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 153 unchanged - 0 fixed = 154 total (was 153)
          +1 mvnsite 0m 31s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 12s the patch passed
          +1 javadoc 0m 21s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 24s the patch passed with JDK v1.7.0_95
          +1 unit 12m 24s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91.
          +1 unit 12m 31s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          43m 35s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803355/YARN-5049.002.patch
          JIRA Issue YARN-5049
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f5c0d74b7a25 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6e56578
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11408/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11408/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11408/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 22s trunk passed +1 compile 0m 32s trunk passed with JDK v1.8.0_91 +1 compile 0m 32s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 22s trunk passed +1 mvnsite 0m 34s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 1m 0s trunk passed +1 javadoc 0m 24s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 25s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 30s the patch passed +1 compile 0m 28s the patch passed with JDK v1.8.0_91 +1 javac 0m 28s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_95 +1 javac 0m 28s the patch passed -1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 153 unchanged - 0 fixed = 154 total (was 153) +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 12s the patch passed +1 javadoc 0m 21s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 24s the patch passed with JDK v1.7.0_95 +1 unit 12m 24s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91. +1 unit 12m 31s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 43m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803355/YARN-5049.002.patch JIRA Issue YARN-5049 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f5c0d74b7a25 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6e56578 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11408/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11408/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11408/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          asuresh Arun Suresh added a comment -

          Konstantinos Karanasos, The patch seems pretty straight forward..

          But I guess we need to update the CURRENT_VERSION_INFO. I guess it should be enough to update the minor version, since the new version of our store can read the old store layout.

          Show
          asuresh Arun Suresh added a comment - Konstantinos Karanasos , The patch seems pretty straight forward.. But I guess we need to update the CURRENT_VERSION_INFO. I guess it should be enough to update the minor version, since the new version of our store can read the old store layout.
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          New patch version with test cases (and fixed white space errors).

          Show
          kkaranasos Konstantinos Karanasos added a comment - New patch version with test cases (and fixed white space errors).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 9m 3s trunk passed
          +1 compile 0m 37s trunk passed with JDK v1.8.0_91
          +1 compile 0m 33s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 36s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 4s trunk passed
          +1 javadoc 0m 26s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 29s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 31s the patch passed
          +1 compile 0m 34s the patch passed with JDK v1.8.0_91
          +1 javac 0m 34s the patch passed
          +1 compile 0m 29s the patch passed with JDK v1.7.0_95
          +1 javac 0m 29s the patch passed
          -1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 143 unchanged - 0 fixed = 144 total (was 143)
          +1 mvnsite 0m 33s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 1m 22s the patch passed
          +1 javadoc 0m 26s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 27s the patch passed with JDK v1.7.0_95
          +1 unit 12m 48s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91.
          +1 unit 12m 42s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          45m 42s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803143/YARN-5049.001.patch
          JIRA Issue YARN-5049
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 48bc4d47f798 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 996a210
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11391/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt
          whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11391/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11391/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/11391/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 9m 3s trunk passed +1 compile 0m 37s trunk passed with JDK v1.8.0_91 +1 compile 0m 33s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 36s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 4s trunk passed +1 javadoc 0m 26s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 29s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 31s the patch passed +1 compile 0m 34s the patch passed with JDK v1.8.0_91 +1 javac 0m 34s the patch passed +1 compile 0m 29s the patch passed with JDK v1.7.0_95 +1 javac 0m 29s the patch passed -1 checkstyle 0m 20s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager: patch generated 1 new + 143 unchanged - 0 fixed = 144 total (was 143) +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 22s the patch passed +1 javadoc 0m 26s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 27s the patch passed with JDK v1.7.0_95 +1 unit 12m 48s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_91. +1 unit 12m 42s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 45m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803143/YARN-5049.001.patch JIRA Issue YARN-5049 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 48bc4d47f798 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 996a210 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/11391/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/11391/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/11391/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager Console output https://builds.apache.org/job/PreCommit-YARN-Build/11391/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          kkaranasos Konstantinos Karanasos added a comment -

          Adding patch for this JIRA.
          Will add test cases shortly.

          Show
          kkaranasos Konstantinos Karanasos added a comment - Adding patch for this JIRA. Will add test cases shortly.

            People

            • Assignee:
              asuresh Arun Suresh
              Reporter:
              kkaranasos Konstantinos Karanasos
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development