Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4863

AHS Security login should be in serviceInit() instead of serviceStart()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: timelineserver
    • Labels:
      None
    • Target Version/s:

      Description

      Like other daemons, doSecureLogin() should get called in serviceInit but not serviceStart, otherwise, some FS operations could have problem during composite services get started.

      1. YARN-4863.patch
        2 kB
        Junping Du
      2. YARN-4863.patch
        2 kB
        Junping Du

        Activity

        Hide
        djp Junping Du added a comment -

        Update a quick patch to fix it. Straightforward enough, so no need unit test.

        Show
        djp Junping Du added a comment - Update a quick patch to fix it. Straightforward enough, so no need unit test.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 39s trunk passed
        +1 compile 0m 16s trunk passed with JDK v1.8.0_74
        +1 compile 0m 18s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 38s trunk passed
        +1 javadoc 0m 15s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 18s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.8.0_74
        +1 javac 0m 13s the patch passed
        +1 compile 0m 16s the patch passed with JDK v1.7.0_95
        +1 javac 0m 16s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 21s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 48s the patch passed
        +1 javadoc 0m 14s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 16s the patch passed with JDK v1.7.0_95
        +1 unit 2m 56s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_74.
        +1 unit 3m 11s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        19m 36s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795208/YARN-4863.patch
        JIRA Issue YARN-4863
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a049ff269b49 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 19b645c
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10865/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10865/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 39s trunk passed +1 compile 0m 16s trunk passed with JDK v1.8.0_74 +1 compile 0m 18s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 38s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 19s the patch passed +1 compile 0m 13s the patch passed with JDK v1.8.0_74 +1 javac 0m 13s the patch passed +1 compile 0m 16s the patch passed with JDK v1.7.0_95 +1 javac 0m 16s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 48s the patch passed +1 javadoc 0m 14s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 16s the patch passed with JDK v1.7.0_95 +1 unit 2m 56s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_74. +1 unit 3m 11s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 19m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795208/YARN-4863.patch JIRA Issue YARN-4863 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a049ff269b49 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 19b645c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10865/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice Console output https://builds.apache.org/job/PreCommit-YARN-Build/10865/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        conf is already there in serviceInit(), replace getConfig() with conf directly.

        Show
        djp Junping Du added a comment - conf is already there in serviceInit(), replace getConfig() with conf directly.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 23s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 40s trunk passed
        +1 compile 0m 17s trunk passed with JDK v1.8.0_74
        +1 compile 0m 19s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 39s trunk passed
        +1 javadoc 0m 15s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 19s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 19s the patch passed
        +1 compile 0m 13s the patch passed with JDK v1.8.0_74
        +1 javac 0m 13s the patch passed
        +1 compile 0m 16s the patch passed with JDK v1.7.0_95
        +1 javac 0m 16s the patch passed
        +1 checkstyle 0m 13s the patch passed
        +1 mvnsite 0m 20s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 findbugs 0m 46s the patch passed
        +1 javadoc 0m 13s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 17s the patch passed with JDK v1.7.0_95
        +1 unit 3m 32s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_74.
        +1 unit 3m 47s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 18s Patch does not generate ASF License warnings.
        21m 7s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795217/YARN-4863.patch
        JIRA Issue YARN-4863
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux bcce42abef00 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 19b645c
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10866/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10866/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 40s trunk passed +1 compile 0m 17s trunk passed with JDK v1.8.0_74 +1 compile 0m 19s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 39s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 19s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 19s the patch passed +1 compile 0m 13s the patch passed with JDK v1.8.0_74 +1 javac 0m 13s the patch passed +1 compile 0m 16s the patch passed with JDK v1.7.0_95 +1 javac 0m 16s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 46s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 17s the patch passed with JDK v1.7.0_95 +1 unit 3m 32s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.8.0_74. +1 unit 3m 47s hadoop-yarn-server-applicationhistoryservice in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 21m 7s Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795217/YARN-4863.patch JIRA Issue YARN-4863 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bcce42abef00 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 19b645c Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10866/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice Console output https://builds.apache.org/job/PreCommit-YARN-Build/10866/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        xgong Xuan Gong added a comment -

        +1 lgtm. Will commit it tomorrow if there is no objection

        Show
        xgong Xuan Gong added a comment - +1 lgtm. Will commit it tomorrow if there is no objection
        Hide
        gtCarrera9 Li Lu added a comment -

        +1 LGTM.

        Show
        gtCarrera9 Li Lu added a comment - +1 LGTM.
        Hide
        xgong Xuan Gong added a comment -

        Committed into trunk/branch-2/branch-2.8. Thanks for the work, Junping, and Thanks for the review, Li.

        Show
        xgong Xuan Gong added a comment - Committed into trunk/branch-2/branch-2.8. Thanks for the work, Junping, and Thanks for the review, Li.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9518 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9518/)
        YARN-4863. AHS Security login should be in serviceInit() instead of (xgong: rev 80182809aed76fb9522d25db9bf5e445395dd573)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9518 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9518/ ) YARN-4863 . AHS Security login should be in serviceInit() instead of (xgong: rev 80182809aed76fb9522d25db9bf5e445395dd573) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java

          People

          • Assignee:
            djp Junping Du
            Reporter:
            djp Junping Du
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development