[YARN-4727] Unable to override the $HADOOP_CONF_DIR env variable for container

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.1, 2.5.2, 2.7.2, 2.6.4, 2.8.1
• Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.3, 3.1.0
• Component/s: nodemanager
• Target Version/s: 2.8.3, 2.7.5
• Assignee: Jason Darrell Lowe
• Reporter: Terence Yim
• Created: 24/Feb/16 01:24
• Updated: 28/Sep/17 17:45
• Resolved: 13/Sep/17 20:27

Description

Given the default config of "yarn.nodemanager.env-whitelist", application should be able to set the env variable $HADOOP_CONF_DIR to value other than the one in the NodeManager system environment. However, I believe due to a bug in the org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch class, it is not possible so.

From the sanitizeEnv() method in the ContainerLaunch class (https://github.com/apache/hadoop/blob/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java#L977)

putEnvIfNotNull(environment, 
    Environment.HADOOP_CONF_DIR.name(), 
    System.getenv(Environment.HADOOP_CONF_DIR.name())
    );

if (!Shell.WINDOWS) {
  environment.put("JVM_PID", "$$");
}

String[] whitelist = conf.get(YarnConfiguration.NM_ENV_WHITELIST, YarnConfiguration.DEFAULT_NM_ENV_WHITELIST).split(",");
    
for(String whitelistEnvVariable : whitelist) {
  putEnvIfAbsent(environment, whitelistEnvVariable.trim());
}

...

private static void putEnvIfAbsent(
    Map<String, String> environment, String variable) {
  if (environment.get(variable) == null) {
    putEnvIfNotNull(environment, variable, System.getenv(variable));
  }
}

So there two issues here.

1. the environment is already set with the system environment of the NM in the putEnvIfNotNull call, hence the putEnvIfAbsent call will never set it to some new value
2. Inside the putEnvIfAbsent call, it uses the system environment of the NM, which it should be using the one from the launchContext instead.

Issue Links

• is required by: OOZIE-3062 Set HADOOP_CONF_DIR for spark action