Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4709

NMWebServices produces incorrect JSON for containers

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      Following exception is thrown when we run below command.

      root@varun-Inspiron-5558:/opt1/hadoop3/bin# ./yarn logs -applicationId application_1455999168135_0002 -am ALL -logFiles ALL

      Container: container_e31_1455999168135_0002_01_000001
      =======================================================
      LogType:syslogstderrstdout
      Log Upload Time:Sun Feb 21 01:44:55 +0530 2016
      Log Contents:
      java.lang.Exception: Cannot find this log on the local disk.
      End of LogType:syslogstderrstdout

      LogType:syslog
      Log Upload Time:Sun Feb 21 01:44:55 +0530 2016
      Log Contents:
      2016-02-21 01:44:49,565 INFO [main] org.apache.hadoop.mapreduce.v2.app.MRAppMaster: Created MRAppMaster for application appattempt_1455999168135_0002_000001
      2016-02-21 01:44:49,914 INFO [main] org.apache.hadoop.mapreduce.v2.app.MRAppMaster:
      /************************************************************

      This is because we annotate containerLogFiles list with XmlElementWrapper which generates XML output as under. And when we read this XML at client side, reading the value associated with containerLogFiles also leads to one value being syslogstderrstdout because both parent and child tags are same. This leads to the exception.

      <containerLogFiles>
        <containerLogFiles>syslog</containerLogFiles>
        <containerLogFiles>stderr</containerLogFiles>
        <containerLogFiles>stdout</containerLogFiles>
      </containerLogFiles>
      

      Moreover, as we use XMLElementWrapper, the JSON generated is as under. This JSON cannot be properly parsed by JSON parser(as a list). This is because child containerLogsFiles entries are treated as a key-value pair(map) and hence only last entry i.e. stdout is picked up. This was found while working on YARN-4517. This makes output unusable.
      This will be an issue for 2 REST endpoints i.e. /ws/v1/node/containers and /ws/v1/node/containers/{{containerId}}

        "containerLogFiles":[
          {
            "containerLogFiles":"syslog",
            "containerLogFiles":"stderr",
            "containerLogFiles":"stdout"
          }
        ]
      

      Ideally the JSON output should be as under.

      "containerLogFiles":["syslog","stderr","stdout"]
      

      We can indicate in the JAXB context to ignore the outer wrapper while marshalling to JSON. But this can only be done at class level. If we do so for ContainerInfo, it would break backward compatibility.
      Hence, to fix it we can remove XmlElementWrapper annotation for containerLogFiles list.
      Another solution would be to wrap the list inside another class.

      But going with former as of now as we do not specify XmlElementWrapper for lists at most of the places in our code.

      1. YARN-4709.01.patch
        7 kB
        Varun Saxena
      2. YARN-4709.02.patch
        7 kB
        Varun Saxena

        Issue Links

          Activity

          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 16m 58s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 55s Maven dependency ordering for branch
          +1 mvninstall 7m 8s trunk passed
          +1 compile 1m 51s trunk passed with JDK v1.8.0_72
          +1 compile 2m 11s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 35s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 2m 1s trunk passed
          +1 javadoc 0m 47s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 57s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 52s the patch passed
          +1 compile 1m 48s the patch passed with JDK v1.8.0_72
          +1 javac 1m 48s the patch passed
          +1 compile 2m 6s the patch passed with JDK v1.7.0_95
          +1 javac 2m 6s the patch passed
          +1 checkstyle 0m 30s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 22s the patch passed
          +1 javadoc 0m 43s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 53s the patch passed with JDK v1.7.0_95
          +1 unit 1m 55s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          +1 unit 8m 46s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72.
          +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 unit 9m 17s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          69m 32s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788894/YARN-4709.01.patch
          JIRA Issue YARN-4709
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 91a9414588c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d5abd29
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10587/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10587/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 16m 58s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 55s Maven dependency ordering for branch +1 mvninstall 7m 8s trunk passed +1 compile 1m 51s trunk passed with JDK v1.8.0_72 +1 compile 2m 11s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 35s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 0m 47s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 57s trunk passed with JDK v1.7.0_95 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 52s the patch passed +1 compile 1m 48s the patch passed with JDK v1.8.0_72 +1 javac 1m 48s the patch passed +1 compile 2m 6s the patch passed with JDK v1.7.0_95 +1 javac 2m 6s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 22s the patch passed +1 javadoc 0m 43s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 53s the patch passed with JDK v1.7.0_95 +1 unit 1m 55s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. +1 unit 8m 46s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72. +1 unit 2m 15s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 9m 17s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 69m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788894/YARN-4709.01.patch JIRA Issue YARN-4709 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 91a9414588c6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d5abd29 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10587/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10587/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          cc Varun Vasudev.
          Tagging Wangda Tan too as this JIRA has implications on YARN-4517(which is related to new Web UI implementation).

          Show
          varun_saxena Varun Saxena added a comment - cc Varun Vasudev . Tagging Wangda Tan too as this JIRA has implications on YARN-4517 (which is related to new Web UI implementation).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 10m 1s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 26s Maven dependency ordering for branch
          +1 mvninstall 6m 42s trunk passed
          +1 compile 1m 41s trunk passed with JDK v1.8.0_72
          +1 compile 2m 3s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 32s trunk passed
          +1 mvnsite 0m 58s trunk passed
          +1 mvneclipse 0m 25s trunk passed
          +1 findbugs 1m 55s trunk passed
          +1 javadoc 0m 43s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 53s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 49s the patch passed
          +1 compile 1m 39s the patch passed with JDK v1.8.0_72
          +1 javac 1m 39s the patch passed
          +1 compile 2m 0s the patch passed with JDK v1.7.0_95
          +1 javac 2m 0s the patch passed
          +1 checkstyle 0m 30s the patch passed
          +1 mvnsite 0m 53s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 17s the patch passed
          +1 javadoc 0m 40s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 49s the patch passed with JDK v1.7.0_95
          +1 unit 1m 49s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          -1 unit 8m 26s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72.
          +1 unit 2m 5s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          -1 unit 8m 55s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          59m 12s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesContainers
          JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesContainers



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788894/YARN-4709.01.patch
          JIRA Issue YARN-4709
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 56ad88cd1274 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d5abd29
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10594/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10594/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10594/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10594/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10594/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10594/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 26s Maven dependency ordering for branch +1 mvninstall 6m 42s trunk passed +1 compile 1m 41s trunk passed with JDK v1.8.0_72 +1 compile 2m 3s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 58s trunk passed +1 mvneclipse 0m 25s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 0m 43s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 53s trunk passed with JDK v1.7.0_95 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 49s the patch passed +1 compile 1m 39s the patch passed with JDK v1.8.0_72 +1 javac 1m 39s the patch passed +1 compile 2m 0s the patch passed with JDK v1.7.0_95 +1 javac 2m 0s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvnsite 0m 53s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 17s the patch passed +1 javadoc 0m 40s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 49s the patch passed with JDK v1.7.0_95 +1 unit 1m 49s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. -1 unit 8m 26s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.8.0_72. +1 unit 2m 5s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. -1 unit 8m 55s hadoop-yarn-server-nodemanager in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 59m 12s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesContainers JDK v1.7.0_95 Failed junit tests hadoop.yarn.server.nodemanager.webapp.TestNMWebServicesContainers Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788894/YARN-4709.01.patch JIRA Issue YARN-4709 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 56ad88cd1274 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d5abd29 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-YARN-Build/10594/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10594/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10594/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-YARN-Build/10594/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10594/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10594/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 6m 52s trunk passed
          +1 compile 1m 52s trunk passed with JDK v1.8.0_72
          +1 compile 2m 11s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 34s trunk passed
          +1 mvnsite 1m 0s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 1m 56s trunk passed
          +1 javadoc 0m 46s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 58s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 53s the patch passed
          +1 compile 1m 50s the patch passed with JDK v1.8.0_72
          +1 javac 1m 50s the patch passed
          +1 compile 2m 9s the patch passed with JDK v1.7.0_95
          +1 javac 2m 9s the patch passed
          +1 checkstyle 0m 31s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 20s the patch passed
          +1 javadoc 0m 41s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 53s the patch passed with JDK v1.7.0_95
          +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          +1 unit 8m 52s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72.
          +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 unit 9m 29s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 19s Patch does not generate ASF License warnings.
          51m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788986/YARN-4709.02.patch
          JIRA Issue YARN-4709
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8411eee3aaf1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5e7d4d5
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10599/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10599/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 6m 52s trunk passed +1 compile 1m 52s trunk passed with JDK v1.8.0_72 +1 compile 2m 11s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 34s trunk passed +1 mvnsite 1m 0s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 1m 56s trunk passed +1 javadoc 0m 46s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 58s trunk passed with JDK v1.7.0_95 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 53s the patch passed +1 compile 1m 50s the patch passed with JDK v1.8.0_72 +1 javac 1m 50s the patch passed +1 compile 2m 9s the patch passed with JDK v1.7.0_95 +1 javac 2m 9s the patch passed +1 checkstyle 0m 31s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 20s the patch passed +1 javadoc 0m 41s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 53s the patch passed with JDK v1.7.0_95 +1 unit 1m 52s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. +1 unit 8m 52s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72. +1 unit 2m 12s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 9m 29s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 19s Patch does not generate ASF License warnings. 51m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788986/YARN-4709.02.patch JIRA Issue YARN-4709 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8411eee3aaf1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5e7d4d5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10599/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10599/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 11s Maven dependency ordering for branch
          +1 mvninstall 7m 1s trunk passed
          +1 compile 1m 57s trunk passed with JDK v1.8.0_72
          +1 compile 2m 17s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 33s trunk passed
          +1 mvnsite 1m 2s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 2m 15s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72
          +1 javadoc 0m 59s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 10s Maven dependency ordering for patch
          +1 mvninstall 0m 56s the patch passed
          +1 compile 2m 16s the patch passed with JDK v1.8.0_72
          +1 javac 2m 16s the patch passed
          +1 compile 2m 36s the patch passed with JDK v1.7.0_95
          +1 javac 2m 36s the patch passed
          +1 checkstyle 0m 34s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 22s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 39s the patch passed
          +1 javadoc 0m 52s the patch passed with JDK v1.8.0_72
          +1 javadoc 0m 56s the patch passed with JDK v1.7.0_95
          +1 unit 2m 13s hadoop-yarn-common in the patch passed with JDK v1.8.0_72.
          +1 unit 9m 15s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72.
          +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 unit 9m 32s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 18s Patch does not generate ASF License warnings.
          55m 0s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788986/YARN-4709.02.patch
          JIRA Issue YARN-4709
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5f5cb61c373b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5e7d4d5
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10600/testReport/
          modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10600/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 11s Maven dependency ordering for branch +1 mvninstall 7m 1s trunk passed +1 compile 1m 57s trunk passed with JDK v1.8.0_72 +1 compile 2m 17s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 33s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 2m 15s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 59s trunk passed with JDK v1.7.0_95 0 mvndep 0m 10s Maven dependency ordering for patch +1 mvninstall 0m 56s the patch passed +1 compile 2m 16s the patch passed with JDK v1.8.0_72 +1 javac 2m 16s the patch passed +1 compile 2m 36s the patch passed with JDK v1.7.0_95 +1 javac 2m 36s the patch passed +1 checkstyle 0m 34s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 39s the patch passed +1 javadoc 0m 52s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 56s the patch passed with JDK v1.7.0_95 +1 unit 2m 13s hadoop-yarn-common in the patch passed with JDK v1.8.0_72. +1 unit 9m 15s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.8.0_72. +1 unit 2m 19s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 unit 9m 32s hadoop-yarn-server-nodemanager in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 18s Patch does not generate ASF License warnings. 55m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788986/YARN-4709.02.patch JIRA Issue YARN-4709 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5f5cb61c373b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5e7d4d5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10600/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn Console output https://builds.apache.org/job/PreCommit-YARN-Build/10600/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vvasudev Varun Vasudev added a comment -

          +1 for the fix. My apologies for missing this. I'll commit this tomorrow if no one objects.

          Show
          vvasudev Varun Vasudev added a comment - +1 for the fix. My apologies for missing this. I'll commit this tomorrow if no one objects.
          Hide
          vvasudev Varun Vasudev added a comment -

          Committed to trunk, branch-2 and branch-2.8. Thanks Varun Saxena!

          Show
          vvasudev Varun Vasudev added a comment - Committed to trunk, branch-2 and branch-2.8. Thanks Varun Saxena !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9345/)
          YARN-4709. NMWebServices produces incorrect JSON for containers. (vvasudev: rev 140cb5d74565aad848b40a251ec02b597a3a20d4)

          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServicesContainers.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/dao/ContainerInfo.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/WebServicesTestUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9345 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9345/ ) YARN-4709 . NMWebServices produces incorrect JSON for containers. (vvasudev: rev 140cb5d74565aad848b40a251ec02b597a3a20d4) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestNMWebServicesContainers.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/dao/ContainerInfo.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/WebServicesTestUtils.java
          Hide
          varun_saxena Varun Saxena added a comment -

          Thanks Varun Vasudev for the review and commit.
          By the way shouldn't resolution status be "Fixed" instead of Cannot Reproduce.

          Show
          varun_saxena Varun Saxena added a comment - Thanks Varun Vasudev for the review and commit. By the way shouldn't resolution status be "Fixed" instead of Cannot Reproduce.
          Hide
          vvasudev Varun Vasudev added a comment -

          Re-opening to fix resolution.

          Show
          vvasudev Varun Vasudev added a comment - Re-opening to fix resolution.

            People

            • Assignee:
              varun_saxena Varun Saxena
              Reporter:
              varun_saxena Varun Saxena
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development