[YARN-4671] There is no need to acquire CS lock when completing a container

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: MENG DING
• Reporter: MENG DING
• Created: 04/Feb/16 16:10
• Updated: 30/Aug/16 01:06
• Resolved: 01/Mar/16 21:16

Description

In YARN-4519, we discovered that there is no need to acquire CS lock in CS#completedContainerInternal, because:

• Access to critical section are already guarded by queue lock.
• It is not essential to guard schedulerHealth with cs lock in completedContainerInternal. All maps in schedulerHealth are concurrent maps. Even if schedulerHealth is not consistent at the moment, it will be eventually consistent.

With this fix, we can truly claim that CS#allocate doesn't require CS lock.