Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4617

LeafQueue#pendingOrderingPolicy should always use fixed ordering policy instead of using same as active applications ordering policy

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In discussion with Wangda Tan in the JIRA comment pointed out that LeafQueue#pendingOrderingPolicy should NOT be assumed to be same as active applications ordering policy. It causes an issue when using fair ordering policy.
      Expectations of this JIRA should include

      1. Create FifoOrderingPolicyForPendingApps which extends FifoOrderingPolicy.
      2. Comparator of new ordering policy should use RecoveryComparator,PriorityComparator and Fifocomparator in order respectively.
      3. Clean up LeafQueue#pendingOPForRecoveredApps which is no more required once new fixed ordering policy is created pending applications.
      1. 0006-YARN-4617.patch
        23 kB
        Rohith Sharma K S
      2. 0005-YARN-4617.patch
        22 kB
        Rohith Sharma K S
      3. 0004-YARN-4617.patch
        24 kB
        Rohith Sharma K S
      4. 0003-YARN-4617.patch
        24 kB
        Rohith Sharma K S
      5. 0001-YARN-4617.patch
        24 kB
        Rohith Sharma K S
      6. 0002-YARN-4617.patch
        23 kB
        Rohith Sharma K S
      7. 0001-YARN-4617.patch
        22 kB
        Rohith Sharma K S

        Activity

        Hide
        rohithsharma Rohith Sharma K S added a comment -

        thanks Jian He for committing the patch

        Show
        rohithsharma Rohith Sharma K S added a comment - thanks Jian He for committing the patch
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9210 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9210/)
        YARN-4617. LeafQueue#pendingOrderingPolicy should always use fixed (jianhe: rev f4a57d4a531e793373fe3118d644871a3b9ae0b1)

        • hadoop-yarn-project/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/MockSchedulableEntity.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestLeafQueue.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/RecoveryComparator.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/TestFifoOrderingPolicyForPendingApps.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/FifoOrderingPolicyForPendingApps.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java
        • hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/SchedulableEntity.java
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9210 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9210/ ) YARN-4617 . LeafQueue#pendingOrderingPolicy should always use fixed (jianhe: rev f4a57d4a531e793373fe3118d644871a3b9ae0b1) hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/MockSchedulableEntity.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/TestLeafQueue.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/RecoveryComparator.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/TestFifoOrderingPolicyForPendingApps.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/FifoOrderingPolicyForPendingApps.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/LeafQueue.java hadoop-yarn-project/hadoop-yarn/dev-support/findbugs-exclude.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/policy/SchedulableEntity.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerApplicationAttempt.java
        Hide
        jianhe Jian He added a comment - - edited

        thanks Sunil G and Naganarasimha G R for reviewing the patch too !

        Show
        jianhe Jian He added a comment - - edited thanks Sunil G and Naganarasimha G R for reviewing the patch too !
        Hide
        jianhe Jian He added a comment -

        Committed to trunk, branch-2, branch-2.8

        thanks Rohith Sharma K S, thanks Wangda for reviewing !

        Show
        jianhe Jian He added a comment - Committed to trunk, branch-2, branch-2.8 thanks Rohith Sharma K S , thanks Wangda for reviewing !
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
        0 mvndep 0m 48s Maven dependency ordering for branch
        +1 mvninstall 6m 50s trunk passed
        +1 compile 1m 53s trunk passed with JDK v1.8.0_66
        +1 compile 2m 7s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 34s trunk passed
        +1 mvnsite 3m 12s trunk passed
        +1 mvneclipse 0m 36s trunk passed
        0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        +1 findbugs 1m 10s trunk passed
        +1 javadoc 2m 12s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 47s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 19s Maven dependency ordering for patch
        +1 mvninstall 2m 41s the patch passed
        +1 compile 1m 50s the patch passed with JDK v1.8.0_66
        +1 javac 1m 50s the patch passed
        +1 compile 2m 8s the patch passed with JDK v1.7.0_91
        +1 javac 2m 8s the patch passed
        -1 checkstyle 0m 32s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 101 unchanged - 3 fixed = 102 total (was 104)
        +1 mvnsite 3m 15s the patch passed
        +1 mvneclipse 0m 31s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        +1 findbugs 1m 22s the patch passed
        +1 javadoc 2m 17s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 46s the patch passed with JDK v1.7.0_91
        -1 unit 76m 32s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 unit 61m 29s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 78m 6s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        -1 unit 62m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        324m 20s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785109/0006-YARN-4617.patch
        JIRA Issue YARN-4617
        Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
        uname Linux ce2287fd6f35 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 09d831c
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10431/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Max memory used 76MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10431/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. 0 mvndep 0m 48s Maven dependency ordering for branch +1 mvninstall 6m 50s trunk passed +1 compile 1m 53s trunk passed with JDK v1.8.0_66 +1 compile 2m 7s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 34s trunk passed +1 mvnsite 3m 12s trunk passed +1 mvneclipse 0m 36s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 10s trunk passed +1 javadoc 2m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 47s trunk passed with JDK v1.7.0_91 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 2m 41s the patch passed +1 compile 1m 50s the patch passed with JDK v1.8.0_66 +1 javac 1m 50s the patch passed +1 compile 2m 8s the patch passed with JDK v1.7.0_91 +1 javac 2m 8s the patch passed -1 checkstyle 0m 32s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 101 unchanged - 3 fixed = 102 total (was 104) +1 mvnsite 3m 15s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 22s the patch passed +1 javadoc 2m 17s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 46s the patch passed with JDK v1.7.0_91 -1 unit 76m 32s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 61m 29s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 78m 6s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 unit 62m 48s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 324m 20s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785109/0006-YARN-4617.patch JIRA Issue YARN-4617 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux ce2287fd6f35 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 09d831c Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10431/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10431/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10431/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 37s Maven dependency ordering for branch
        +1 mvninstall 7m 26s trunk passed
        +1 compile 2m 6s trunk passed with JDK v1.8.0_66
        +1 compile 2m 20s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 3m 33s trunk passed
        +1 mvneclipse 0m 37s trunk passed
        0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        +1 findbugs 1m 19s trunk passed
        -1 javadoc 1m 58s hadoop-yarn in trunk failed with JDK v1.8.0_66.
        +1 javadoc 5m 6s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 20s Maven dependency ordering for patch
        -1 mvninstall 1m 48s hadoop-yarn in the patch failed.
        -1 mvninstall 0m 30s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 compile 1m 29s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 javac 1m 29s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 compile 1m 39s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        -1 javac 1m 39s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        -1 checkstyle 0m 34s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 101 unchanged - 3 fixed = 102 total (was 104)
        -1 mvnsite 1m 52s hadoop-yarn in the patch failed.
        -1 mvnsite 0m 32s hadoop-yarn-server-resourcemanager in the patch failed.
        +1 mvneclipse 0m 33s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        -1 findbugs 0m 25s hadoop-yarn-server-resourcemanager in the patch failed.
        -1 javadoc 1m 54s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        +1 javadoc 4m 57s the patch passed with JDK v1.7.0_91
        -1 unit 15m 16s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 unit 0m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 16m 33s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        -1 unit 0m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        77m 13s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.TestNodeManagerResync



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785086/0005-YARN-4617.patch
        JIRA Issue YARN-4617
        Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
        uname Linux 90275e4a65c3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ee005e0
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn.txt
        mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        compile https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        javac https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn.txt
        mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10428/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10428/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 37s Maven dependency ordering for branch +1 mvninstall 7m 26s trunk passed +1 compile 2m 6s trunk passed with JDK v1.8.0_66 +1 compile 2m 20s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 37s trunk passed +1 mvnsite 3m 33s trunk passed +1 mvneclipse 0m 37s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 19s trunk passed -1 javadoc 1m 58s hadoop-yarn in trunk failed with JDK v1.8.0_66. +1 javadoc 5m 6s trunk passed with JDK v1.7.0_91 0 mvndep 0m 20s Maven dependency ordering for patch -1 mvninstall 1m 48s hadoop-yarn in the patch failed. -1 mvninstall 0m 30s hadoop-yarn-server-resourcemanager in the patch failed. -1 compile 1m 29s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 javac 1m 29s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 compile 1m 39s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 javac 1m 39s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 checkstyle 0m 34s hadoop-yarn-project/hadoop-yarn: patch generated 1 new + 101 unchanged - 3 fixed = 102 total (was 104) -1 mvnsite 1m 52s hadoop-yarn in the patch failed. -1 mvnsite 0m 32s hadoop-yarn-server-resourcemanager in the patch failed. +1 mvneclipse 0m 33s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn -1 findbugs 0m 25s hadoop-yarn-server-resourcemanager in the patch failed. -1 javadoc 1m 54s hadoop-yarn in the patch failed with JDK v1.8.0_66. +1 javadoc 4m 57s the patch passed with JDK v1.7.0_91 -1 unit 15m 16s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 0m 27s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 16m 33s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 unit 0m 30s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 77m 13s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.nodemanager.TestNodeManagerResync Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12785086/0005-YARN-4617.patch JIRA Issue YARN-4617 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux 90275e4a65c3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ee005e0 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn.txt mvninstall https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-mvninstall-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt compile https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt javac https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-compile-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn.txt mvnsite https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-mvnsite-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10428/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10428/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10428/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updating the patch fixing Jian He review comments. Changes made from 0004-YARN-4617 patch to 0005-YARN-4617 patch are

        1. Initialized this.pendingOrderingPolicy = new FifoOrderingPolicyForPendingApps(); in LeafQueue constructor.
        2. Removed LeafQueue#setPendingAppsOrderingPolicy method.
        3. Reverted CapacitySchedulerConfiguration since pending ordering policy object creation is made static.
        Show
        rohithsharma Rohith Sharma K S added a comment - Updating the patch fixing Jian He review comments. Changes made from 0004- YARN-4617 patch to 0005- YARN-4617 patch are Initialized this.pendingOrderingPolicy = new FifoOrderingPolicyForPendingApps(); in LeafQueue constructor. Removed LeafQueue#setPendingAppsOrderingPolicy method. Reverted CapacitySchedulerConfiguration since pending ordering policy object creation is made static.
        Hide
        jianhe Jian He added a comment -

        One more comment: I think for pending apps, we do not need to call addAllSchedulableEntities, because the passed-in argument will always be empty ?

          public synchronized void setPendingAppsOrderingPolicy(
              OrderingPolicy<FiCaSchedulerApp> pendingOrderingPolicy) {
            if (null != this.pendingOrderingPolicy) {
              pendingOrderingPolicy
                  .addAllSchedulableEntities(this.pendingOrderingPolicy
                      .getSchedulableEntities());
            }
            this.pendingOrderingPolicy = pendingOrderingPolicy;
          }
        

        So we may just need to initialize the pendingOrderingPolicy variable, like this.

         this.pendingOrderingPolicy = new FifoOrderingPolicyForPendingApps(); 

        Doing this, the CapacitySchedulerConfiguration#getPendingOrderingPolicy method can also be removed

        Show
        jianhe Jian He added a comment - One more comment: I think for pending apps, we do not need to call addAllSchedulableEntities, because the passed-in argument will always be empty ? public synchronized void setPendingAppsOrderingPolicy( OrderingPolicy<FiCaSchedulerApp> pendingOrderingPolicy) { if ( null != this .pendingOrderingPolicy) { pendingOrderingPolicy .addAllSchedulableEntities( this .pendingOrderingPolicy .getSchedulableEntities()); } this .pendingOrderingPolicy = pendingOrderingPolicy; } So we may just need to initialize the pendingOrderingPolicy variable, like this. this .pendingOrderingPolicy = new FifoOrderingPolicyForPendingApps(); Doing this, the CapacitySchedulerConfiguration#getPendingOrderingPolicy method can also be removed
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        test failures are unrelated to this patch..

        Show
        rohithsharma Rohith Sharma K S added a comment - test failures are unrelated to this patch..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 18s Maven dependency ordering for branch
        +1 mvninstall 6m 32s trunk passed
        +1 compile 1m 55s trunk passed with JDK v1.8.0_66
        +1 compile 2m 13s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 35s trunk passed
        +1 mvnsite 3m 26s trunk passed
        +1 mvneclipse 0m 33s trunk passed
        0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        +1 findbugs 1m 12s trunk passed
        +1 javadoc 2m 51s trunk passed with JDK v1.8.0_66
        +1 javadoc 4m 45s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 18s Maven dependency ordering for patch
        +1 mvninstall 2m 35s the patch passed
        +1 compile 1m 43s the patch passed with JDK v1.8.0_66
        +1 javac 1m 43s the patch passed
        +1 compile 2m 3s the patch passed with JDK v1.7.0_91
        +1 javac 2m 3s the patch passed
        -1 checkstyle 0m 32s hadoop-yarn-project/hadoop-yarn: patch generated 2 new + 133 unchanged - 3 fixed = 135 total (was 136)
        +1 mvnsite 3m 7s the patch passed
        +1 mvneclipse 0m 31s the patch passed
        +1 whitespace 0m 0s Patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        +1 findbugs 1m 18s the patch passed
        +1 javadoc 1m 59s the patch passed with JDK v1.8.0_66
        +1 javadoc 4m 34s the patch passed with JDK v1.7.0_91
        -1 unit 75m 10s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 unit 62m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 79m 20s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        -1 unit 64m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 23s Patch does not generate ASF License warnings.
        326m 0s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.TestAMAuthorization



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784900/0004-YARN-4617.patch
        JIRA Issue YARN-4617
        Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
        uname Linux 9400f906f675 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 662e17b
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10420/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10420/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 6m 32s trunk passed +1 compile 1m 55s trunk passed with JDK v1.8.0_66 +1 compile 2m 13s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 35s trunk passed +1 mvnsite 3m 26s trunk passed +1 mvneclipse 0m 33s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 12s trunk passed +1 javadoc 2m 51s trunk passed with JDK v1.8.0_66 +1 javadoc 4m 45s trunk passed with JDK v1.7.0_91 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 2m 35s the patch passed +1 compile 1m 43s the patch passed with JDK v1.8.0_66 +1 javac 1m 43s the patch passed +1 compile 2m 3s the patch passed with JDK v1.7.0_91 +1 javac 2m 3s the patch passed -1 checkstyle 0m 32s hadoop-yarn-project/hadoop-yarn: patch generated 2 new + 133 unchanged - 3 fixed = 135 total (was 136) +1 mvnsite 3m 7s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 18s the patch passed +1 javadoc 1m 59s the patch passed with JDK v1.8.0_66 +1 javadoc 4m 34s the patch passed with JDK v1.7.0_91 -1 unit 75m 10s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 62m 9s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 79m 20s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 unit 64m 50s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 326m 0s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784900/0004-YARN-4617.patch JIRA Issue YARN-4617 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux 9400f906f675 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 662e17b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10420/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10420/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10420/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        updated the patch fixing java doc errors. I verified in the java-1.8 version before and after the changes, and javadoc build was success. Let wait for Jenkins report.

        Show
        rohithsharma Rohith Sharma K S added a comment - updated the patch fixing java doc errors. I verified in the java-1.8 version before and after the changes, and javadoc build was success. Let wait for Jenkins report.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Looking for Jenkins report, test failures are known issues. Even TestRMRestart failure has JIRA YARN-4633.
        I am looking for java doc failure in java-1.8. I am not sure how it should be fixed, digging more on this part and I will upload new patch fixing java doc error.

        Show
        rohithsharma Rohith Sharma K S added a comment - Looking for Jenkins report, test failures are known issues. Even TestRMRestart failure has JIRA YARN-4633 . I am looking for java doc failure in java-1.8. I am not sure how it should be fixed, digging more on this part and I will upload new patch fixing java doc error.
        Hide
        sunilg Sunil G added a comment -

        +1 from my side too. Latest patch looks fine. From Jenkins, except TestRMRestart all others seems known pblm. Could u pls confirm.

        Show
        sunilg Sunil G added a comment - +1 from my side too. Latest patch looks fine. From Jenkins, except TestRMRestart all others seems known pblm. Could u pls confirm.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 34s Maven dependency ordering for branch
        +1 mvninstall 7m 33s trunk passed
        +1 compile 2m 10s trunk passed with JDK v1.8.0_66
        +1 compile 2m 29s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 3m 47s trunk passed
        +1 mvneclipse 0m 39s trunk passed
        0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        +1 findbugs 1m 24s trunk passed
        +1 javadoc 2m 38s trunk passed with JDK v1.8.0_66
        +1 javadoc 5m 9s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 19s Maven dependency ordering for patch
        +1 mvninstall 2m 58s the patch passed
        +1 compile 2m 17s the patch passed with JDK v1.8.0_66
        +1 javac 2m 17s the patch passed
        +1 compile 2m 24s the patch passed with JDK v1.7.0_91
        +1 javac 2m 24s the patch passed
        -1 checkstyle 0m 35s hadoop-yarn-project/hadoop-yarn: patch generated 3 new + 133 unchanged - 3 fixed = 136 total (was 136)
        +1 mvnsite 3m 35s the patch passed
        +1 mvneclipse 0m 33s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        +1 findbugs 1m 35s the patch passed
        -1 javadoc 1m 47s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 javadoc 0m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        +1 javadoc 5m 12s the patch passed with JDK v1.7.0_91
        -1 unit 79m 11s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 unit 66m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 83m 22s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        -1 unit 65m 29s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        345m 5s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMTokens



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784818/0003-YARN-4617.patch
        JIRA Issue YARN-4617
        Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
        uname Linux 2b2cbd16c2f6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 662e17b
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/whitespace-eol.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10411/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10411/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 34s Maven dependency ordering for branch +1 mvninstall 7m 33s trunk passed +1 compile 2m 10s trunk passed with JDK v1.8.0_66 +1 compile 2m 29s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 38s trunk passed +1 mvnsite 3m 47s trunk passed +1 mvneclipse 0m 39s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 24s trunk passed +1 javadoc 2m 38s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 9s trunk passed with JDK v1.7.0_91 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 2m 58s the patch passed +1 compile 2m 17s the patch passed with JDK v1.8.0_66 +1 javac 2m 17s the patch passed +1 compile 2m 24s the patch passed with JDK v1.7.0_91 +1 javac 2m 24s the patch passed -1 checkstyle 0m 35s hadoop-yarn-project/hadoop-yarn: patch generated 3 new + 133 unchanged - 3 fixed = 136 total (was 136) +1 mvnsite 3m 35s the patch passed +1 mvneclipse 0m 33s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 35s the patch passed -1 javadoc 1m 47s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 javadoc 0m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 5m 12s the patch passed with JDK v1.7.0_91 -1 unit 79m 11s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 66m 44s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 83m 22s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 unit 65m 29s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 345m 5s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12784818/0003-YARN-4617.patch JIRA Issue YARN-4617 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux 2b2cbd16c2f6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 662e17b Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10411/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10411/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10411/console This message was automatically generated.
        Hide
        leftnoteasy Wangda Tan added a comment -

        +1 to the patch, thanks Rohith Sharma K S!

        Show
        leftnoteasy Wangda Tan added a comment - +1 to the patch, thanks Rohith Sharma K S !
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Missed to maintain order of patch number. Again uploaded the patch with new sequence number 0003-YARN-4617.patch, Kindly review 0003-YARN-4617.patch

        Show
        rohithsharma Rohith Sharma K S added a comment - Missed to maintain order of patch number. Again uploaded the patch with new sequence number 0003- YARN-4617 .patch , Kindly review 0003- YARN-4617 .patch
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        updating the patch fixing Jian He comment. Kindly review the updated patch.

        Show
        rohithsharma Rohith Sharma K S added a comment - updating the patch fixing Jian He comment. Kindly review the updated patch.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Right, no more required to recreate the pendingApps list object. I will upload patch with this change.

        Show
        rohithsharma Rohith Sharma K S added a comment - Right, no more required to recreate the pendingApps list object. I will upload patch with this change.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Rohith Sharma K S,
        Apart from the Jian He's comment, Patch LGTM...

        Show
        Naganarasimha Naganarasimha G R added a comment - Rohith Sharma K S , Apart from the Jian He 's comment, Patch LGTM...
        Hide
        jianhe Jian He added a comment -

        I think we do not need to refresh the pendingApps list when reInitializeQueue is called, as the policy just never changes.

        Show
        jianhe Jian He added a comment - I think we do not need to refresh the pendingApps list when reInitializeQueue is called, as the policy just never changes.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 21s Maven dependency ordering for branch
        +1 mvninstall 8m 16s trunk passed
        +1 compile 2m 4s trunk passed with JDK v1.8.0_66
        +1 compile 2m 21s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 3m 36s trunk passed
        +1 mvneclipse 0m 37s trunk passed
        0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        +1 findbugs 1m 19s trunk passed
        +1 javadoc 2m 21s trunk passed with JDK v1.8.0_66
        +1 javadoc 5m 1s trunk passed with JDK v1.7.0_91
        0 mvndep 0m 19s Maven dependency ordering for patch
        +1 mvninstall 2m 50s the patch passed
        +1 compile 2m 6s the patch passed with JDK v1.8.0_66
        +1 javac 2m 6s the patch passed
        +1 compile 2m 28s the patch passed with JDK v1.7.0_91
        +1 javac 2m 28s the patch passed
        -1 checkstyle 0m 33s hadoop-yarn-project/hadoop-yarn: patch generated 3 new + 133 unchanged - 3 fixed = 136 total (was 136)
        +1 mvnsite 3m 59s the patch passed
        +1 mvneclipse 0m 41s the patch passed
        -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 xml 0m 0s The patch has no ill-formed XML file.
        0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn
        +1 findbugs 1m 41s the patch passed
        -1 javadoc 2m 0s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        +1 javadoc 5m 52s the patch passed with JDK v1.7.0_91
        -1 unit 79m 22s hadoop-yarn in the patch failed with JDK v1.8.0_66.
        -1 unit 63m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 80m 18s hadoop-yarn in the patch failed with JDK v1.7.0_91.
        -1 unit 64m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 21s Patch does not generate ASF License warnings.
        338m 41s



        Reason Tests
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestRMRestart
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.TestClientRMTokens



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783791/0002-YARN-4617.patch
        JIRA Issue YARN-4617
        Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle
        uname Linux 56f8a39424fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ae9c61f
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/whitespace-eol.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10366/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10366/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 21s Maven dependency ordering for branch +1 mvninstall 8m 16s trunk passed +1 compile 2m 4s trunk passed with JDK v1.8.0_66 +1 compile 2m 21s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 32s trunk passed +1 mvnsite 3m 36s trunk passed +1 mvneclipse 0m 37s trunk passed 0 findbugs 0m 0s Skipped branch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 19s trunk passed +1 javadoc 2m 21s trunk passed with JDK v1.8.0_66 +1 javadoc 5m 1s trunk passed with JDK v1.7.0_91 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 2m 50s the patch passed +1 compile 2m 6s the patch passed with JDK v1.8.0_66 +1 javac 2m 6s the patch passed +1 compile 2m 28s the patch passed with JDK v1.7.0_91 +1 javac 2m 28s the patch passed -1 checkstyle 0m 33s hadoop-yarn-project/hadoop-yarn: patch generated 3 new + 133 unchanged - 3 fixed = 136 total (was 136) +1 mvnsite 3m 59s the patch passed +1 mvneclipse 0m 41s the patch passed -1 whitespace 0m 0s The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 xml 0m 0s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patch modules with no Java source: hadoop-yarn-project/hadoop-yarn +1 findbugs 1m 41s the patch passed -1 javadoc 2m 0s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 javadoc 0m 22s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 5m 52s the patch passed with JDK v1.7.0_91 -1 unit 79m 22s hadoop-yarn in the patch failed with JDK v1.8.0_66. -1 unit 63m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 80m 18s hadoop-yarn in the patch failed with JDK v1.7.0_91. -1 unit 64m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 338m 41s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestRMRestart   hadoop.yarn.server.resourcemanager.TestClientRMTokens JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.TestClientRMTokens Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783791/0002-YARN-4617.patch JIRA Issue YARN-4617 Optional Tests asflicense findbugs xml compile javac javadoc mvninstall mvnsite unit checkstyle uname Linux 56f8a39424fe 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ae9c61f Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-YARN-Build/10366/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10366/testReport/ modules C: hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10366/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the patch fixing comments.
        In the updated patch, I included the fix supposed to given in YARN-4547 since it is small.

        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the patch fixing comments. In the updated patch, I included the fix supposed to given in YARN-4547 since it is small.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        thanks Sunil G for the comments, I will update the patch fixing the comments

        I think we can return unmodifiable set here. Because we already say it read-only.

        Right, we have separate similar JIRA YARN-4547 to track active-applications. May be I can club both together in this patch only or-else I can do it in YARN-4547.

        isAttemptRecovering -->isRecovering , is this change needed?. May be isAttemptRecovering is more informative

        Since SchedulableEntity is generic interface, all the API's in the interface made generic. And SchedulableEntity can be for application/application-attempt. So I changed the API name isAttemptRecovering -->isRecovering generic.

        fsApp looks more readable.

        make sense, I reverted the changes made by YARN-4479 for leaf-queue, so earlier code has been retained. I will make a change in next patch.

        Show
        rohithsharma Rohith Sharma K S added a comment - thanks Sunil G for the comments, I will update the patch fixing the comments I think we can return unmodifiable set here. Because we already say it read-only. Right, we have separate similar JIRA YARN-4547 to track active-applications. May be I can club both together in this patch only or-else I can do it in YARN-4547 . isAttemptRecovering -->isRecovering , is this change needed?. May be isAttemptRecovering is more informative Since SchedulableEntity is generic interface, all the API's in the interface made generic. And SchedulableEntity can be for application/application-attempt. So I changed the API name isAttemptRecovering -->isRecovering generic. fsApp looks more readable. make sense, I reverted the changes made by YARN-4479 for leaf-queue, so earlier code has been retained. I will make a change in next patch.
        Hide
        sunilg Sunil G added a comment -

        Thanks Rohith Sharma K S for the patch.
        Overall looks good.

        Minor nits:
        1. Not introduced by this patch

           * Obtain (read-only) collection of pending applications.
            */
           public Collection<FiCaSchedulerApp> getPendingApplications() {
        

        I think we can return unmodifiable set here. Because we already say it read-only.

        2. isAttemptRecovering -->isRecovering , is this change needed?. May be isAttemptRecovering is more informative.
        3.
        In activateApplications

        -      fsApp.remove();
        +      i.remove();
        

        fsApp looks more readable.

        4. Some more information about this comparator as java doc in FifoOrderingPolicyForPendingApps class may be helpful.
        Similarly RecoveryComparator note also can be informative.

        Also as I see YARN-4479 has added more cases for pending apps. hence we dont need more tests, correct.

        Show
        sunilg Sunil G added a comment - Thanks Rohith Sharma K S for the patch. Overall looks good. Minor nits: 1. Not introduced by this patch * Obtain (read-only) collection of pending applications. */ public Collection<FiCaSchedulerApp> getPendingApplications() { I think we can return unmodifiable set here. Because we already say it read-only. 2. isAttemptRecovering --> isRecovering , is this change needed?. May be isAttemptRecovering is more informative. 3. In activateApplications - fsApp.remove(); + i.remove(); fsApp looks more readable. 4. Some more information about this comparator as java doc in FifoOrderingPolicyForPendingApps class may be helpful. Similarly RecoveryComparator note also can be informative. Also as I see YARN-4479 has added more cases for pending apps. hence we dont need more tests, correct.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 7m 47s trunk passed
        +1 compile 0m 27s trunk passed with JDK v1.8.0_66
        +1 compile 0m 29s trunk passed with JDK v1.7.0_91
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 37s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 10s trunk passed
        +1 javadoc 0m 28s trunk passed with JDK v1.8.0_66
        +1 javadoc 0m 28s trunk passed with JDK v1.7.0_91
        +1 mvninstall 0m 31s the patch passed
        +1 compile 0m 31s the patch passed with JDK v1.8.0_66
        +1 javac 0m 31s the patch passed
        +1 compile 0m 30s the patch passed with JDK v1.7.0_91
        +1 javac 0m 30s the patch passed
        -1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 4 new + 134 unchanged - 2 fixed = 138 total (was 136)
        +1 mvnsite 0m 35s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 0s The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 findbugs 1m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 0m 19s the patch passed with JDK v1.8.0_66
        +1 javadoc 0m 23s the patch passed with JDK v1.7.0_91
        -1 unit 67m 51s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
        -1 unit 67m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
        +1 asflicense 0m 17s Patch does not generate ASF License warnings.
        153m 11s



        Reason Tests
        FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
          org.apache.hadoop.yarn.server.resourcemanager.scheduler.policy.RecoveryComparator implements Comparator but not Serializable At RecoveryComparator.java:Serializable At RecoveryComparator.java:[lines 26-31]
        JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
        JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
          hadoop.yarn.server.resourcemanager.TestAMAuthorization
          hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler
          hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783551/0001-YARN-4617.patch
        JIRA Issue YARN-4617
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 703ff8a3d076 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 9eec6cb
        Default Java 1.7.0_91
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt
        whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/whitespace-eol.txt
        findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
        unit https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
        JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10352/testReport/
        modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
        Max memory used 77MB
        Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
        Console output https://builds.apache.org/job/PreCommit-YARN-Build/10352/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 7m 47s trunk passed +1 compile 0m 27s trunk passed with JDK v1.8.0_66 +1 compile 0m 29s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 37s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 10s trunk passed +1 javadoc 0m 28s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 28s trunk passed with JDK v1.7.0_91 +1 mvninstall 0m 31s the patch passed +1 compile 0m 31s the patch passed with JDK v1.8.0_66 +1 javac 0m 31s the patch passed +1 compile 0m 30s the patch passed with JDK v1.7.0_91 +1 javac 0m 30s the patch passed -1 checkstyle 0m 15s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: patch generated 4 new + 134 unchanged - 2 fixed = 138 total (was 136) +1 mvnsite 0m 35s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 13 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 findbugs 1m 28s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 19s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 23s the patch passed with JDK v1.7.0_91 -1 unit 67m 51s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 67m 21s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 153m 11s Reason Tests FindBugs module:hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager   org.apache.hadoop.yarn.server.resourcemanager.scheduler.policy.RecoveryComparator implements Comparator but not Serializable At RecoveryComparator.java:Serializable At RecoveryComparator.java: [lines 26-31] JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.yarn.server.resourcemanager.scheduler.TestAbstractYarnScheduler   hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783551/0001-YARN-4617.patch JIRA Issue YARN-4617 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 703ff8a3d076 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9eec6cb Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt whitespace https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/whitespace-eol.txt findbugs https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/new-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.html unit https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10352/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10352/testReport/ modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10352/console This message was automatically generated.
        Hide
        rohithsharma Rohith Sharma K S added a comment -

        Updated the patch with following changes

        1. Created separate ordering policy for pending apps and it is constant nevertheless of any ordering policy configured.
        2. LeafQueue#pendingOrderingPolicy loads always FifoOrderingPolicyForPendingApps
        3. Clean up LeafQueue#pendingOPForRecoveredApps since recovery comparator introduced.
        4. Newly added test TestFifoOrderingPolicyForPendingApps#testIterators verifies the order of applications in combine with recovering and non-recovering applications with priority configured.
        Show
        rohithsharma Rohith Sharma K S added a comment - Updated the patch with following changes Created separate ordering policy for pending apps and it is constant nevertheless of any ordering policy configured. LeafQueue#pendingOrderingPolicy loads always FifoOrderingPolicyForPendingApps Clean up LeafQueue#pendingOPForRecoveredApps since recovery comparator introduced. Newly added test TestFifoOrderingPolicyForPendingApps#testIterators verifies the order of applications in combine with recovering and non-recovering applications with priority configured.

          People

          • Assignee:
            rohithsharma Rohith Sharma K S
            Reporter:
            rohithsharma Rohith Sharma K S
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development