Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-4582

Label-related invalid resource request exception should be able to properly handled by application

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: scheduler
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Steps to reproduce
      ===============
      Submit mapreduce job

      1. map to label x
      2. reduce to label y

      Precondition

      1. Queue b to which reduce is submitted not having access to label specified

      Impact

      1. Jobs fail only of the RM-AM comunication timeout
        (About 10 mins i think)

      Should kill the job immediately when InvalidResourceException is received on RMContainerRequestor#makeRemoteRequest
      Logs

      2015-09-11 16:44:30,116 ERROR [RMCommunicator Allocator] org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator: ERROR IN CONTACTING RM. 
      org.apache.hadoop.yarn.exceptions.InvalidResourceRequestException: Invalid resource request, queue=b1 doesn't have permission to access all labels in resource request. labelExpression of resource request=1. Queue labels=3
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.validateResourceRequest(SchedulerUtils.java:304)
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:234)
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndvalidateRequest(SchedulerUtils.java:250)
      	at org.apache.hadoop.yarn.server.resourcemanager.RMServerUtils.normalizeAndValidateRequests(RMServerUtils.java:106)
      	at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.allocate(ApplicationMasterService.java:457)
      	at org.apache.hadoop.yarn.api.impl.pb.service.ApplicationMasterProtocolPBServiceImpl.allocate(ApplicationMasterProtocolPBServiceImpl.java:60)
      	at org.apache.hadoop.yarn.proto.ApplicationMasterProtocol$ApplicationMasterProtocolService$2.callBlockingMethod(ApplicationMasterProtocol.java:99)
      	at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:636)
      	at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:976)
      	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2230)
      	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2226)
      	at java.security.AccessController.doPrivileged(Native Method)
      	at javax.security.auth.Subject.doAs(Subject.java:422)
      	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1667)
      	at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2224)
      
      	at sun.reflect.GeneratedConstructorAccessor39.newInstance(Unknown Source)
      	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
      	at java.lang.reflect.Constructor.newInstance(Constructor.java:422)
      	at org.apache.hadoop.yarn.ipc.RPCUtil.instantiateException(RPCUtil.java:53)
      	at org.apache.hadoop.yarn.ipc.RPCUtil.instantiateYarnException(RPCUtil.java:75)
      	at org.apache.hadoop.yarn.ipc.RPCUtil.unwrapAndThrowException(RPCUtil.java:116)
      	at org.apache.hadoop.yarn.api.impl.pb.client.ApplicationMasterProtocolPBClientImpl.allocate(ApplicationMasterProtocolPBClientImpl.java:79)
      	at sun.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
      	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      	at java.lang.reflect.Method.invoke(Method.java:497)
      	at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:251)
      	at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:103)
      	at com.sun.proxy.$Proxy37.allocate(Unknown Source)
      	at org.apache.hadoop.mapreduce.v2.app.rm.RMContainerRequestor.makeRemoteRequest(RMContainerRequestor.java:203)
      	at org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator.getResources(RMContainerAllocator.java:694)
      	at org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator.heartbeat(RMContainerAllocator.java:263)
      	at org.apache.hadoop.mapreduce.v2.app.rm.RMCommunicator$AllocatorRunnable.run(RMCommunicator.java:281)
      	at java.lang.Thread.run(Thread.java:745)
      Caused by: org.apache.hadoop.ipc.RemoteException(org.apache.hadoop.yarn.exceptions.InvalidResourceRequestException): Invalid resource request, queue=b1 doesn't have permission to access all labels in resource request. labelExpression of resource request=1. Queue labels=3
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.validateResourceRequest(SchedulerUtils.java:304)
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.java:234)
      	at org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.normalizeAndvalidateRequest(SchedulerUtils.java:250)
      	at org.apache.hadoop.yarn.server.resourcemanager.RMServerUtils.normalizeAndValidateRequests(RMServerUtils.java:106)
      	at org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService.allocate(ApplicationMasterService.java:457)
      	at org.apache.hadoop.yarn.api.impl.pb.service.ApplicationMasterProtocolPBServiceImpl.allocate(ApplicationMasterProtocolPBServiceImpl.java:60)
      	at org.apache.hadoop.yarn.proto.ApplicationMasterProtocol$ApplicationMasterProtocolService$2.callBlockingMethod(ApplicationMasterProtocol.java:99)
      	at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:636)
      	at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:976)
      	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2230)
      	at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2226)
      	at java.security.AccessController.doPrivileged(Native Method)
      	at javax.security.auth.Subject.doAs(Subject.java:422)
      	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1667)
      	at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2224)
      
      	at org.apache.hadoop.ipc.Client.call(Client.java:1440)
      	at org.apache.hadoop.ipc.Client.call(Client.java:1371)
      	at org.apache.hadoop.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:229)
      	at com.sun.proxy.$Proxy36.allocate(Unknown Source)
      	at org.apache.hadoop.yarn.api.impl.pb.client.ApplicationMasterProtocolPBClientImpl.allocate(ApplicationMasterProtocolPBClientImpl.java:77)
      	... 11 more
      2015-09-11 16:44:31,120 ERROR [RMCommunicator Allocator] org.apache.hadoop.mapreduce.v2.app.rm.RMContainerAllocator: Could not contact RM after 360000 milliseconds.
      
      1. 0001-MAPREDUCE-6476.patch
        8 kB
        Bibin A Chundatt
      2. 0002-MAPREDUCE-6476.patch
        10 kB
        Bibin A Chundatt

        Issue Links

          Activity

          Hide
          bibinchundatt Bibin A Chundatt added a comment -
          Show
          bibinchundatt Bibin A Chundatt added a comment - \cc Wangda Tan
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          We can solve this in two ways

          1. Create InvalidLabelResourceException extending InvalidResourceException and based on this exception we can kill application/job using eventHandler.handle(new JobEvent(jobId, JobEventType.JOB_KILL))
          2. ResourceRequestAllocate response we can send the accessible labels too for the queue.

          Cons of first approach is that if REDUCE is not having access then will wait till the exception to be received at AM , but simple implementation.

          Thoughts??
          \cc Wangda Tan

          Show
          bibinchundatt Bibin A Chundatt added a comment - We can solve this in two ways Create InvalidLabelResourceException extending InvalidResourceException and based on this exception we can kill application/job using eventHandler.handle(new JobEvent(jobId, JobEventType.JOB_KILL)) ResourceRequestAllocate response we can send the accessible labels too for the queue. Cons of first approach is that if REDUCE is not having access then will wait till the exception to be received at AM , but simple implementation. Thoughts?? \cc Wangda Tan
          Hide
          leftnoteasy Wangda Tan added a comment -

          Bibin A Chundatt,

          I think approach#1 seems more straightforward to me. In addition, I'm not sure if there's any other InvalidResourceRequestException we should handle as well, such as requested resource exceeds max-allocation.

          Show
          leftnoteasy Wangda Tan added a comment - Bibin A Chundatt , I think approach#1 seems more straightforward to me. In addition, I'm not sure if there's any other InvalidResourceRequestException we should handle as well, such as requested resource exceeds max-allocation.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Hi Wangda Tan
          Sorry for delayed response

          I think as part of MAPREDUCE-5279 check for max cluster core and memory was added RMContainerAllocator#handleEvent. I thought will send the accessible label to AM Option 2.
          As per your suggestion Option 1 will implement and update the patch soon.

          Show
          bibinchundatt Bibin A Chundatt added a comment - Hi Wangda Tan Sorry for delayed response I think as part of MAPREDUCE-5279 check for max cluster core and memory was added RMContainerAllocator#handleEvent . I thought will send the accessible label to AM Option 2 . As per your suggestion Option 1 will implement and update the patch soon.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Please do review patch attached

          Show
          bibinchundatt Bibin A Chundatt added a comment - Please do review patch attached
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 0s trunk passed
          +1 compile 8m 54s trunk passed with JDK v1.8.0_66
          +1 compile 10m 2s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 1m 37s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 3m 26s trunk passed
          +1 javadoc 1m 18s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 42s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 29s the patch passed
          +1 compile 8m 48s the patch passed with JDK v1.8.0_66
          +1 javac 8m 48s the patch passed
          +1 compile 9m 23s the patch passed with JDK v1.7.0_91
          +1 javac 9m 23s the patch passed
          -1 checkstyle 1m 2s Patch generated 4 new checkstyle issues in root (total was 132, now 136).
          +1 mvnsite 1m 38s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 51s the patch passed
          +1 javadoc 1m 19s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 41s the patch passed with JDK v1.7.0_91
          +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          -1 unit 60m 17s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 9m 45s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          -1 unit 61m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 10m 1s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          215m 14s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779583/0001-MAPREDUCE-6476.patch
          JIRA Issue MAPREDUCE-6476
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 7784b55dcd83 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fb00794
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 0s trunk passed +1 compile 8m 54s trunk passed with JDK v1.8.0_66 +1 compile 10m 2s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 6s trunk passed +1 mvnsite 1m 37s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 3m 26s trunk passed +1 javadoc 1m 18s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 42s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 29s the patch passed +1 compile 8m 48s the patch passed with JDK v1.8.0_66 +1 javac 8m 48s the patch passed +1 compile 9m 23s the patch passed with JDK v1.7.0_91 +1 javac 9m 23s the patch passed -1 checkstyle 1m 2s Patch generated 4 new checkstyle issues in root (total was 132, now 136). +1 mvnsite 1m 38s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 51s the patch passed +1 javadoc 1m 19s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 41s the patch passed with JDK v1.7.0_91 +1 unit 0m 25s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 60m 17s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 9m 45s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. -1 unit 61m 43s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 10m 1s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 215m 14s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779583/0001-MAPREDUCE-6476.patch JIRA Issue MAPREDUCE-6476 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 7784b55dcd83 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fb00794 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6240/console This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Thanks Bibin A Chundatt,
          Some comments:
          1) You can put InvalidLabelResourceRequestException into a separate catch, just like

          try {
          ...
          } catch ( InvalidLabelResourceRequestException e) {
             ...
          }
          

          Instead of checking e instanceof InvalidLabelResourceRequestException.
          TestSchedulerUtils could be updated as well.

          2) Diagnostic message:

          String diagMsg = "Request dont have access to label so killing app";
          

          I suggest to update it to "Requested node-label-expression is invalid:", with exception message.

          Show
          leftnoteasy Wangda Tan added a comment - Thanks Bibin A Chundatt , Some comments: 1) You can put InvalidLabelResourceRequestException into a separate catch, just like try { ... } catch ( InvalidLabelResourceRequestException e) { ... } Instead of checking e instanceof InvalidLabelResourceRequestException . TestSchedulerUtils could be updated as well. 2) Diagnostic message: String diagMsg = "Request dont have access to label so killing app" ; I suggest to update it to "Requested node-label-expression is invalid:", with exception message.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Wangda Tan
          Thnk you for review . uploaded latest patch for review

          Show
          bibinchundatt Bibin A Chundatt added a comment - Wangda Tan Thnk you for review . uploaded latest patch for review
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 22s trunk passed
          +1 compile 9m 16s trunk passed with JDK v1.8.0_66
          +1 compile 9m 36s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 7s trunk passed
          +1 mvnsite 1m 39s trunk passed
          +1 mvneclipse 0m 41s trunk passed
          +1 findbugs 3m 33s trunk passed
          +1 javadoc 1m 22s trunk passed with JDK v1.8.0_66
          +1 javadoc 3m 48s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 24s the patch passed
          +1 compile 9m 9s the patch passed with JDK v1.8.0_66
          +1 javac 9m 9s the patch passed
          +1 compile 9m 35s the patch passed with JDK v1.7.0_91
          +1 javac 9m 35s the patch passed
          -1 checkstyle 1m 3s Patch generated 3 new checkstyle issues in root (total was 132, now 135).
          +1 mvnsite 1m 38s the patch passed
          +1 mvneclipse 0m 43s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 57s the patch passed
          +1 javadoc 1m 21s the patch passed with JDK v1.8.0_66
          +1 javadoc 3m 39s the patch passed with JDK v1.7.0_91
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          -1 unit 60m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          -1 unit 9m 32s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          -1 unit 61m 37s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          -1 unit 10m 12s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_91.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          216m 49s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
            hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779792/0002-MAPREDUCE-6476.patch
          JIRA Issue MAPREDUCE-6476
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bf33ea315965 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d0a22ba
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 22s trunk passed +1 compile 9m 16s trunk passed with JDK v1.8.0_66 +1 compile 9m 36s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 7s trunk passed +1 mvnsite 1m 39s trunk passed +1 mvneclipse 0m 41s trunk passed +1 findbugs 3m 33s trunk passed +1 javadoc 1m 22s trunk passed with JDK v1.8.0_66 +1 javadoc 3m 48s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 24s the patch passed +1 compile 9m 9s the patch passed with JDK v1.8.0_66 +1 javac 9m 9s the patch passed +1 compile 9m 35s the patch passed with JDK v1.7.0_91 +1 javac 9m 35s the patch passed -1 checkstyle 1m 3s Patch generated 3 new checkstyle issues in root (total was 132, now 135). +1 mvnsite 1m 38s the patch passed +1 mvneclipse 0m 43s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 57s the patch passed +1 javadoc 1m 21s the patch passed with JDK v1.8.0_66 +1 javadoc 3m 39s the patch passed with JDK v1.7.0_91 +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 60m 32s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. -1 unit 9m 32s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. -1 unit 61m 37s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. -1 unit 10m 12s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 216m 49s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization   hadoop.mapreduce.jobhistory.TestJobHistoryEventHandler Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779792/0002-MAPREDUCE-6476.patch JIRA Issue MAPREDUCE-6476 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bf33ea315965 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0a22ba Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6244/console This message was automatically generated.
          Hide
          leftnoteasy Wangda Tan added a comment -

          Looks good, +1, thanks Bibin A Chundatt.

          Show
          leftnoteasy Wangda Tan added a comment - Looks good, +1, thanks Bibin A Chundatt .
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Thank you Wangda for review

          Show
          bibinchundatt Bibin A Chundatt added a comment - Thank you Wangda for review
          Hide
          leftnoteasy Wangda Tan added a comment -

          Committed to branch-2/branch-2.8/trunk, thanks Bibin A Chundatt!

          Show
          leftnoteasy Wangda Tan added a comment - Committed to branch-2/branch-2.8/trunk, thanks Bibin A Chundatt !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9090 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9090/)
          YARN-4582. Label-related invalid resource request exception should be (wangda: rev 9e792da01419998c2ebfafd7161070150d85d3ac)

          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerUtils.java
          • hadoop-yarn-project/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/exceptions/InvalidLabelResourceRequestException.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9090 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9090/ ) YARN-4582 . Label-related invalid resource request exception should be (wangda: rev 9e792da01419998c2ebfafd7161070150d85d3ac) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/SchedulerUtils.java hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/TestSchedulerUtils.java hadoop-yarn-project/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api/src/main/java/org/apache/hadoop/yarn/exceptions/InvalidLabelResourceRequestException.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/rm/RMContainerAllocator.java
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 29s trunk passed
          +1 compile 9m 8s trunk passed with JDK v1.8.0_66
          +1 compile 10m 3s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 14s trunk passed
          +1 mvnsite 1m 58s trunk passed
          +1 mvneclipse 0m 45s trunk passed
          +1 findbugs 3m 57s trunk passed
          -1 javadoc 0m 36s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66.
          +1 javadoc 4m 6s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 24s the patch passed
          +1 compile 8m 54s the patch passed with JDK v1.8.0_66
          +1 javac 8m 54s the patch passed
          +1 compile 9m 30s the patch passed with JDK v1.7.0_91
          +1 javac 9m 30s the patch passed
          -1 checkstyle 1m 5s Patch generated 3 new checkstyle issues in root (total was 132, now 135).
          +1 mvnsite 1m 39s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 57s the patch passed
          -1 javadoc 0m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 javadoc 3m 41s the patch passed with JDK v1.7.0_91
          +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66.
          -1 unit 62m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66.
          +1 unit 9m 39s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_91.
          -1 unit 64m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91.
          +1 unit 10m 12s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          223m 27s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization
          JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler
            hadoop.yarn.server.resourcemanager.TestClientRMTokens
            hadoop.yarn.server.resourcemanager.TestAMAuthorization



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779792/0002-MAPREDUCE-6476.patch
          JIRA Issue YARN-4582
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fc9377923d09 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 103d3cf
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/diff-checkstyle-root.txt
          javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10240/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/10240/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 29s trunk passed +1 compile 9m 8s trunk passed with JDK v1.8.0_66 +1 compile 10m 3s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 14s trunk passed +1 mvnsite 1m 58s trunk passed +1 mvneclipse 0m 45s trunk passed +1 findbugs 3m 57s trunk passed -1 javadoc 0m 36s hadoop-yarn-server-resourcemanager in trunk failed with JDK v1.8.0_66. +1 javadoc 4m 6s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 24s the patch passed +1 compile 8m 54s the patch passed with JDK v1.8.0_66 +1 javac 8m 54s the patch passed +1 compile 9m 30s the patch passed with JDK v1.7.0_91 +1 javac 9m 30s the patch passed -1 checkstyle 1m 5s Patch generated 3 new checkstyle issues in root (total was 132, now 135). +1 mvnsite 1m 39s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 57s the patch passed -1 javadoc 0m 25s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 javadoc 3m 41s the patch passed with JDK v1.7.0_91 +1 unit 0m 26s hadoop-yarn-api in the patch passed with JDK v1.8.0_66. -1 unit 62m 2s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.8.0_66. +1 unit 9m 39s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66. +1 unit 0m 27s hadoop-yarn-api in the patch passed with JDK v1.7.0_91. -1 unit 64m 31s hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_91. +1 unit 10m 12s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 223m 27s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization JDK v1.7.0_91 Failed junit tests hadoop.yarn.server.resourcemanager.scheduler.fifo.TestFifoScheduler   hadoop.yarn.server.resourcemanager.TestClientRMTokens   hadoop.yarn.server.resourcemanager.TestAMAuthorization Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12779792/0002-MAPREDUCE-6476.patch JIRA Issue YARN-4582 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fc9377923d09 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 103d3cf Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/branch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt checkstyle https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/diff-checkstyle-root.txt javadoc https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-YARN-Build/10240/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-YARN-Build/10240/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-YARN-Build/10240/console This message was automatically generated.
          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          Thank you for review and commit Wangda Tan

          Show
          bibinchundatt Bibin A Chundatt added a comment - Thank you for review and commit Wangda Tan

            People

            • Assignee:
              bibinchundatt Bibin A Chundatt
              Reporter:
              bibinchundatt Bibin A Chundatt
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development